rust-clippy/clippy_lints/src/redundant_field_names.rs

64 lines
1.8 KiB
Rust
Raw Normal View History

use rustc::lint::*;
use rustc::hir::*;
use utils::{in_macro, is_range_expression, match_var, span_lint_and_sugg};
/// **What it does:** Checks for fields in struct literals where shorthands
/// could be used.
///
/// **Why is this bad?** If the field and variable names are the same,
/// the field name is redundant.
///
/// **Known problems:** None.
///
/// **Example:**
/// ```rust
/// let bar: u8 = 123;
///
/// struct Foo {
/// bar: u8,
/// }
///
/// let foo = Foo{ bar: bar }
/// ```
declare_lint! {
pub REDUNDANT_FIELD_NAMES,
Warn,
"checks for fields in struct literals where shorthands could be used"
}
pub struct RedundantFieldNames;
impl LintPass for RedundantFieldNames {
fn get_lints(&self) -> LintArray {
lint_array!(REDUNDANT_FIELD_NAMES)
}
}
impl<'a, 'tcx> LateLintPass<'a, 'tcx> for RedundantFieldNames {
fn check_expr(&mut self, cx: &LateContext<'a, 'tcx>, expr: &'tcx Expr) {
// Do not care about range expressions.
// They could have redundant field name when desugared to structs.
// e.g. `start..end` is desugared to `Range { start: start, end: end }`
if in_macro(expr.span) || is_range_expression(expr.span) {
return;
}
2018-03-05 08:40:42 +00:00
if let ExprStruct(_, ref fields, _) = expr.node {
for field in fields {
let name = field.name.node;
if match_var(&field.expr, name) && !field.is_shorthand {
span_lint_and_sugg (
cx,
REDUNDANT_FIELD_NAMES,
field.span,
"redundant field names in struct initialization",
"replace it with",
name.to_string()
);
}
}
}
}
}