2021-03-12 14:30:50 +00:00
|
|
|
use super::ITER_NEXT_LOOP;
|
2021-03-25 18:29:11 +00:00
|
|
|
use clippy_utils::diagnostics::span_lint;
|
|
|
|
use clippy_utils::is_trait_method;
|
2021-03-12 14:30:50 +00:00
|
|
|
use rustc_hir::Expr;
|
|
|
|
use rustc_lint::LateContext;
|
2021-03-25 18:29:11 +00:00
|
|
|
use rustc_span::sym;
|
2021-03-12 14:30:50 +00:00
|
|
|
|
|
|
|
pub(super) fn check(cx: &LateContext<'_>, arg: &Expr<'_>, expr: &Expr<'_>) -> bool {
|
2021-03-25 18:29:11 +00:00
|
|
|
if is_trait_method(cx, arg, sym::Iterator) {
|
2021-03-12 14:30:50 +00:00
|
|
|
span_lint(
|
|
|
|
cx,
|
|
|
|
ITER_NEXT_LOOP,
|
|
|
|
expr.span,
|
|
|
|
"you are iterating over `Iterator::next()` which is an Option; this will compile but is \
|
|
|
|
probably not what you want",
|
|
|
|
);
|
|
|
|
true
|
|
|
|
} else {
|
|
|
|
false
|
|
|
|
}
|
|
|
|
}
|