rust-clippy/tests/ui/used_underscore_binding.rs

125 lines
3 KiB
Rust
Raw Normal View History

// aux-build:proc_macro_derive.rs
#![feature(rustc_private)]
2018-07-28 15:34:52 +00:00
#![warn(clippy::all)]
#![allow(clippy::disallowed_names, clippy::eq_op)]
2018-07-28 15:34:52 +00:00
#![warn(clippy::used_underscore_binding)]
2016-02-22 14:42:24 +00:00
#[macro_use]
extern crate proc_macro_derive;
// This should not trigger the lint. There's underscore binding inside the external derive that
// would trigger the `used_underscore_binding` lint.
#[derive(DeriveSomething)]
struct Baz;
2016-06-15 14:27:56 +00:00
macro_rules! test_macro {
() => {{
let _foo = 42;
_foo + 1
2018-12-09 22:26:16 +00:00
}};
2016-06-15 14:27:56 +00:00
}
2019-01-31 01:15:29 +00:00
/// Tests that we lint if we use a binding with a single leading underscore
fn prefix_underscore(_foo: u32) -> u32 {
2017-02-08 13:58:07 +00:00
_foo + 1
2015-12-10 20:54:43 +00:00
}
2019-01-31 01:15:29 +00:00
/// Tests that we lint if we use a `_`-variable defined outside within a macro expansion
2019-05-12 03:40:05 +00:00
fn in_macro_or_desugar(_foo: u32) {
2016-06-15 14:27:56 +00:00
println!("{}", _foo);
assert_eq!(_foo, _foo);
2017-02-08 13:58:07 +00:00
2016-06-15 14:27:56 +00:00
test_macro!() + 1;
}
2015-12-19 00:29:22 +00:00
// Struct for testing use of fields prefixed with an underscore
struct StructFieldTest {
_underscore_field: u32,
}
2019-01-31 01:15:29 +00:00
/// Tests that we lint the use of a struct field which is prefixed with an underscore
2015-12-19 00:29:22 +00:00
fn in_struct_field() {
let mut s = StructFieldTest { _underscore_field: 0 };
2017-02-08 13:58:07 +00:00
s._underscore_field += 1;
2015-12-19 00:29:22 +00:00
}
/// Tests that we do not lint if the struct field is used in code created with derive.
#[derive(Clone, Debug)]
pub struct UnderscoreInStruct {
_foo: u32,
}
2019-01-31 01:15:29 +00:00
/// Tests that we do not lint if the underscore is not a prefix
2015-12-13 00:31:34 +00:00
fn non_prefix_underscore(some_foo: u32) -> u32 {
some_foo + 1
2015-12-10 20:54:43 +00:00
}
2019-01-31 01:15:29 +00:00
/// Tests that we do not lint if we do not use the binding (simple case)
fn unused_underscore_simple(_foo: u32) -> u32 {
1
}
2019-01-31 01:15:29 +00:00
/// Tests that we do not lint if we do not use the binding (complex case). This checks for
/// compatibility with the built-in `unused_variables` lint.
fn unused_underscore_complex(mut _foo: u32) -> u32 {
_foo += 1;
_foo = 2;
2015-12-13 00:31:34 +00:00
1
2015-12-10 20:54:43 +00:00
}
2015-12-13 00:31:34 +00:00
/// Test that we do not lint for multiple underscores
fn multiple_underscores(__foo: u32) -> u32 {
__foo + 1
}
2015-12-17 21:52:30 +00:00
// Non-variable bindings with preceding underscore
fn _fn_test() {}
struct _StructTest;
enum _EnumTest {
2016-02-01 11:51:33 +00:00
_Empty,
2018-12-09 22:26:16 +00:00
_Value(_StructTest),
2015-12-17 21:52:30 +00:00
}
2019-01-31 01:15:29 +00:00
/// Tests that we do not lint for non-variable bindings
2015-12-17 21:52:30 +00:00
fn non_variables() {
_fn_test();
let _s = _StructTest;
2016-02-01 11:51:33 +00:00
let _e = match _EnumTest::_Value(_StructTest) {
_EnumTest::_Empty => 0,
_EnumTest::_Value(_st) => 1,
2015-12-17 21:52:30 +00:00
};
let f = _fn_test;
f();
}
// Tests that we do not lint if the binding comes from await desugaring,
// but we do lint the awaited expression. See issue 5360.
async fn await_desugaring() {
async fn foo() {}
fn uses_i(_i: i32) {}
foo().await;
({
let _i = 5;
uses_i(_i);
foo()
})
.await
}
2015-12-17 21:52:30 +00:00
2015-12-13 00:31:34 +00:00
fn main() {
let foo = 0u32;
// tests of unused_underscore lint
let _ = prefix_underscore(foo);
2019-05-12 03:40:05 +00:00
in_macro_or_desugar(foo);
2015-12-19 00:29:22 +00:00
in_struct_field();
2015-12-13 00:31:34 +00:00
// possible false positives
let _ = non_prefix_underscore(foo);
let _ = unused_underscore_simple(foo);
let _ = unused_underscore_complex(foo);
let _ = multiple_underscores(foo);
2015-12-17 21:52:30 +00:00
non_variables();
await_desugaring();
2015-12-13 00:31:34 +00:00
}