2022-05-21 11:24:00 +00:00
|
|
|
|
use clippy_utils::diagnostics::{span_lint_and_help, span_lint_and_note, span_lint_and_sugg, span_lint_and_then};
|
2021-03-25 18:29:11 +00:00
|
|
|
|
use clippy_utils::paths;
|
2022-06-04 11:34:07 +00:00
|
|
|
|
use clippy_utils::ty::{implements_trait, implements_trait_with_env, is_copy};
|
2022-04-26 12:04:23 +00:00
|
|
|
|
use clippy_utils::{is_lint_allowed, match_def_path};
|
2018-11-27 20:14:15 +00:00
|
|
|
|
use if_chain::if_chain;
|
2022-05-21 11:24:00 +00:00
|
|
|
|
use rustc_errors::Applicability;
|
2022-06-16 15:39:06 +00:00
|
|
|
|
use rustc_hir::def_id::DefId;
|
2022-01-15 22:07:52 +00:00
|
|
|
|
use rustc_hir::intravisit::{walk_expr, walk_fn, walk_item, FnKind, Visitor};
|
2020-04-20 18:05:15 +00:00
|
|
|
|
use rustc_hir::{
|
2022-06-16 15:39:06 +00:00
|
|
|
|
self as hir, BlockCheckMode, BodyId, Constness, Expr, ExprKind, FnDecl, HirId, Impl, Item, ItemKind, UnsafeSource,
|
|
|
|
|
Unsafety,
|
2020-04-20 18:05:15 +00:00
|
|
|
|
};
|
2020-01-12 06:08:41 +00:00
|
|
|
|
use rustc_lint::{LateContext, LateLintPass};
|
2022-01-15 22:07:52 +00:00
|
|
|
|
use rustc_middle::hir::nested_filter;
|
2022-06-16 15:39:06 +00:00
|
|
|
|
use rustc_middle::traits::Reveal;
|
|
|
|
|
use rustc_middle::ty::{
|
|
|
|
|
self, Binder, BoundConstness, GenericParamDefKind, ImplPolarity, ParamEnv, PredicateKind, TraitPredicate, TraitRef,
|
2022-08-27 21:10:06 +00:00
|
|
|
|
Ty, TyCtxt,
|
2022-06-16 15:39:06 +00:00
|
|
|
|
};
|
2020-01-11 11:37:08 +00:00
|
|
|
|
use rustc_session::{declare_lint_pass, declare_tool_lint};
|
2021-05-20 10:30:31 +00:00
|
|
|
|
use rustc_span::source_map::Span;
|
2022-02-26 13:26:21 +00:00
|
|
|
|
use rustc_span::sym;
|
2016-01-21 17:19:02 +00:00
|
|
|
|
|
2018-03-28 13:24:26 +00:00
|
|
|
|
declare_clippy_lint! {
|
2021-07-29 10:16:06 +00:00
|
|
|
|
/// ### What it does
|
|
|
|
|
/// Checks for deriving `Hash` but implementing `PartialEq`
|
2019-03-05 16:50:33 +00:00
|
|
|
|
/// explicitly or vice versa.
|
|
|
|
|
///
|
2021-07-29 10:16:06 +00:00
|
|
|
|
/// ### Why is this bad?
|
|
|
|
|
/// The implementation of these traits must agree (for
|
2019-03-05 16:50:33 +00:00
|
|
|
|
/// example for use with `HashMap`) so it’s probably a bad idea to use a
|
|
|
|
|
/// default-generated `Hash` implementation with an explicitly defined
|
|
|
|
|
/// `PartialEq`. In particular, the following must hold for any type:
|
|
|
|
|
///
|
2019-03-05 22:23:50 +00:00
|
|
|
|
/// ```text
|
2019-03-05 16:50:33 +00:00
|
|
|
|
/// k1 == k2 ⇒ hash(k1) == hash(k2)
|
|
|
|
|
/// ```
|
|
|
|
|
///
|
2021-07-29 10:16:06 +00:00
|
|
|
|
/// ### Example
|
2019-03-05 22:23:50 +00:00
|
|
|
|
/// ```ignore
|
2019-03-05 16:50:33 +00:00
|
|
|
|
/// #[derive(Hash)]
|
|
|
|
|
/// struct Foo;
|
|
|
|
|
///
|
|
|
|
|
/// impl PartialEq for Foo {
|
|
|
|
|
/// ...
|
|
|
|
|
/// }
|
|
|
|
|
/// ```
|
2021-12-06 11:33:31 +00:00
|
|
|
|
#[clippy::version = "pre 1.29.0"]
|
2016-02-15 22:38:09 +00:00
|
|
|
|
pub DERIVE_HASH_XOR_EQ,
|
2018-03-28 13:24:26 +00:00
|
|
|
|
correctness,
|
2016-01-21 17:19:02 +00:00
|
|
|
|
"deriving `Hash` but implementing `PartialEq` explicitly"
|
|
|
|
|
}
|
|
|
|
|
|
2020-08-11 13:43:21 +00:00
|
|
|
|
declare_clippy_lint! {
|
2021-07-29 10:16:06 +00:00
|
|
|
|
/// ### What it does
|
|
|
|
|
/// Checks for deriving `Ord` but implementing `PartialOrd`
|
2020-08-11 13:43:21 +00:00
|
|
|
|
/// explicitly or vice versa.
|
|
|
|
|
///
|
2021-07-29 10:16:06 +00:00
|
|
|
|
/// ### Why is this bad?
|
|
|
|
|
/// The implementation of these traits must agree (for
|
2020-08-11 13:43:21 +00:00
|
|
|
|
/// example for use with `sort`) so it’s probably a bad idea to use a
|
|
|
|
|
/// default-generated `Ord` implementation with an explicitly defined
|
|
|
|
|
/// `PartialOrd`. In particular, the following must hold for any type
|
|
|
|
|
/// implementing `Ord`:
|
|
|
|
|
///
|
|
|
|
|
/// ```text
|
|
|
|
|
/// k1.cmp(&k2) == k1.partial_cmp(&k2).unwrap()
|
|
|
|
|
/// ```
|
|
|
|
|
///
|
2021-07-29 10:16:06 +00:00
|
|
|
|
/// ### Example
|
2020-08-11 13:43:21 +00:00
|
|
|
|
/// ```rust,ignore
|
|
|
|
|
/// #[derive(Ord, PartialEq, Eq)]
|
|
|
|
|
/// struct Foo;
|
|
|
|
|
///
|
|
|
|
|
/// impl PartialOrd for Foo {
|
|
|
|
|
/// ...
|
|
|
|
|
/// }
|
|
|
|
|
/// ```
|
|
|
|
|
/// Use instead:
|
|
|
|
|
/// ```rust,ignore
|
|
|
|
|
/// #[derive(PartialEq, Eq)]
|
|
|
|
|
/// struct Foo;
|
|
|
|
|
///
|
|
|
|
|
/// impl PartialOrd for Foo {
|
|
|
|
|
/// fn partial_cmp(&self, other: &Foo) -> Option<Ordering> {
|
|
|
|
|
/// Some(self.cmp(other))
|
|
|
|
|
/// }
|
|
|
|
|
/// }
|
|
|
|
|
///
|
|
|
|
|
/// impl Ord for Foo {
|
|
|
|
|
/// ...
|
|
|
|
|
/// }
|
|
|
|
|
/// ```
|
|
|
|
|
/// or, if you don't need a custom ordering:
|
|
|
|
|
/// ```rust,ignore
|
|
|
|
|
/// #[derive(Ord, PartialOrd, PartialEq, Eq)]
|
|
|
|
|
/// struct Foo;
|
|
|
|
|
/// ```
|
2021-12-06 11:33:31 +00:00
|
|
|
|
#[clippy::version = "1.47.0"]
|
2020-08-11 13:43:21 +00:00
|
|
|
|
pub DERIVE_ORD_XOR_PARTIAL_ORD,
|
|
|
|
|
correctness,
|
|
|
|
|
"deriving `Ord` but implementing `PartialOrd` explicitly"
|
|
|
|
|
}
|
|
|
|
|
|
2018-03-28 13:24:26 +00:00
|
|
|
|
declare_clippy_lint! {
|
2021-07-29 10:16:06 +00:00
|
|
|
|
/// ### What it does
|
|
|
|
|
/// Checks for explicit `Clone` implementations for `Copy`
|
2019-03-05 16:50:33 +00:00
|
|
|
|
/// types.
|
|
|
|
|
///
|
2021-07-29 10:16:06 +00:00
|
|
|
|
/// ### Why is this bad?
|
2022-05-21 11:24:00 +00:00
|
|
|
|
/// To avoid surprising behavior, these traits should
|
|
|
|
|
/// agree and the behavior of `Copy` cannot be overridden. In almost all
|
2019-03-05 16:50:33 +00:00
|
|
|
|
/// situations a `Copy` type should have a `Clone` implementation that does
|
|
|
|
|
/// nothing more than copy the object, which is what `#[derive(Copy, Clone)]`
|
|
|
|
|
/// gets you.
|
|
|
|
|
///
|
2021-07-29 10:16:06 +00:00
|
|
|
|
/// ### Example
|
2019-08-03 16:42:05 +00:00
|
|
|
|
/// ```rust,ignore
|
2019-03-05 16:50:33 +00:00
|
|
|
|
/// #[derive(Copy)]
|
|
|
|
|
/// struct Foo;
|
|
|
|
|
///
|
|
|
|
|
/// impl Clone for Foo {
|
2019-08-03 16:42:05 +00:00
|
|
|
|
/// // ..
|
2019-03-05 16:50:33 +00:00
|
|
|
|
/// }
|
|
|
|
|
/// ```
|
2021-12-06 11:33:31 +00:00
|
|
|
|
#[clippy::version = "pre 1.29.0"]
|
2016-01-24 12:56:23 +00:00
|
|
|
|
pub EXPL_IMPL_CLONE_ON_COPY,
|
2018-03-28 13:24:26 +00:00
|
|
|
|
pedantic,
|
2016-01-24 12:56:23 +00:00
|
|
|
|
"implementing `Clone` explicitly on `Copy` types"
|
|
|
|
|
}
|
|
|
|
|
|
2020-04-19 21:11:30 +00:00
|
|
|
|
declare_clippy_lint! {
|
2021-07-29 10:16:06 +00:00
|
|
|
|
/// ### What it does
|
|
|
|
|
/// Checks for deriving `serde::Deserialize` on a type that
|
2020-04-19 21:11:30 +00:00
|
|
|
|
/// has methods using `unsafe`.
|
|
|
|
|
///
|
2021-07-29 10:16:06 +00:00
|
|
|
|
/// ### Why is this bad?
|
|
|
|
|
/// Deriving `serde::Deserialize` will create a constructor
|
2020-04-19 21:11:30 +00:00
|
|
|
|
/// that may violate invariants hold by another constructor.
|
|
|
|
|
///
|
2021-07-29 10:16:06 +00:00
|
|
|
|
/// ### Example
|
2020-04-19 21:11:30 +00:00
|
|
|
|
/// ```rust,ignore
|
|
|
|
|
/// use serde::Deserialize;
|
|
|
|
|
///
|
|
|
|
|
/// #[derive(Deserialize)]
|
|
|
|
|
/// pub struct Foo {
|
|
|
|
|
/// // ..
|
|
|
|
|
/// }
|
|
|
|
|
///
|
|
|
|
|
/// impl Foo {
|
|
|
|
|
/// pub fn new() -> Self {
|
|
|
|
|
/// // setup here ..
|
|
|
|
|
/// }
|
|
|
|
|
///
|
|
|
|
|
/// pub unsafe fn parts() -> (&str, &str) {
|
|
|
|
|
/// // assumes invariants hold
|
|
|
|
|
/// }
|
|
|
|
|
/// }
|
|
|
|
|
/// ```
|
2021-12-06 11:33:31 +00:00
|
|
|
|
#[clippy::version = "1.45.0"]
|
2020-04-19 21:11:30 +00:00
|
|
|
|
pub UNSAFE_DERIVE_DESERIALIZE,
|
2020-04-20 18:05:15 +00:00
|
|
|
|
pedantic,
|
2020-04-19 21:11:30 +00:00
|
|
|
|
"deriving `serde::Deserialize` on a type that has methods using `unsafe`"
|
|
|
|
|
}
|
|
|
|
|
|
2022-05-21 11:24:00 +00:00
|
|
|
|
declare_clippy_lint! {
|
|
|
|
|
/// ### What it does
|
|
|
|
|
/// Checks for types that derive `PartialEq` and could implement `Eq`.
|
|
|
|
|
///
|
|
|
|
|
/// ### Why is this bad?
|
|
|
|
|
/// If a type `T` derives `PartialEq` and all of its members implement `Eq`,
|
|
|
|
|
/// then `T` can always implement `Eq`. Implementing `Eq` allows `T` to be used
|
|
|
|
|
/// in APIs that require `Eq` types. It also allows structs containing `T` to derive
|
|
|
|
|
/// `Eq` themselves.
|
|
|
|
|
///
|
|
|
|
|
/// ### Example
|
|
|
|
|
/// ```rust
|
|
|
|
|
/// #[derive(PartialEq)]
|
|
|
|
|
/// struct Foo {
|
|
|
|
|
/// i_am_eq: i32,
|
|
|
|
|
/// i_am_eq_too: Vec<String>,
|
|
|
|
|
/// }
|
|
|
|
|
/// ```
|
|
|
|
|
/// Use instead:
|
|
|
|
|
/// ```rust
|
|
|
|
|
/// #[derive(PartialEq, Eq)]
|
|
|
|
|
/// struct Foo {
|
|
|
|
|
/// i_am_eq: i32,
|
|
|
|
|
/// i_am_eq_too: Vec<String>,
|
|
|
|
|
/// }
|
|
|
|
|
/// ```
|
2022-07-18 07:39:37 +00:00
|
|
|
|
#[clippy::version = "1.63.0"]
|
2022-05-21 11:24:00 +00:00
|
|
|
|
pub DERIVE_PARTIAL_EQ_WITHOUT_EQ,
|
|
|
|
|
style,
|
|
|
|
|
"deriving `PartialEq` on a type that can implement `Eq`, without implementing `Eq`"
|
|
|
|
|
}
|
|
|
|
|
|
2020-08-11 13:43:21 +00:00
|
|
|
|
declare_lint_pass!(Derive => [
|
|
|
|
|
EXPL_IMPL_CLONE_ON_COPY,
|
|
|
|
|
DERIVE_HASH_XOR_EQ,
|
|
|
|
|
DERIVE_ORD_XOR_PARTIAL_ORD,
|
2022-05-21 11:24:00 +00:00
|
|
|
|
UNSAFE_DERIVE_DESERIALIZE,
|
|
|
|
|
DERIVE_PARTIAL_EQ_WITHOUT_EQ
|
2020-08-11 13:43:21 +00:00
|
|
|
|
]);
|
2016-01-21 17:19:02 +00:00
|
|
|
|
|
2020-06-25 20:41:36 +00:00
|
|
|
|
impl<'tcx> LateLintPass<'tcx> for Derive {
|
|
|
|
|
fn check_item(&mut self, cx: &LateContext<'tcx>, item: &'tcx Item<'_>) {
|
2020-11-22 22:46:21 +00:00
|
|
|
|
if let ItemKind::Impl(Impl {
|
2020-01-18 05:14:36 +00:00
|
|
|
|
of_trait: Some(ref trait_ref),
|
|
|
|
|
..
|
2020-11-22 22:46:21 +00:00
|
|
|
|
}) = item.kind
|
2020-01-18 05:14:36 +00:00
|
|
|
|
{
|
2021-01-30 16:47:51 +00:00
|
|
|
|
let ty = cx.tcx.type_of(item.def_id);
|
2022-05-21 11:24:00 +00:00
|
|
|
|
let is_automatically_derived = cx.tcx.has_attr(item.def_id.to_def_id(), sym::automatically_derived);
|
2016-02-15 22:38:09 +00:00
|
|
|
|
|
|
|
|
|
check_hash_peq(cx, item.span, trait_ref, ty, is_automatically_derived);
|
2020-08-11 13:43:21 +00:00
|
|
|
|
check_ord_partial_ord(cx, item.span, trait_ref, ty, is_automatically_derived);
|
2016-02-15 22:38:09 +00:00
|
|
|
|
|
2020-04-19 21:11:30 +00:00
|
|
|
|
if is_automatically_derived {
|
|
|
|
|
check_unsafe_derive_deserialize(cx, item, trait_ref, ty);
|
2022-05-21 11:24:00 +00:00
|
|
|
|
check_partial_eq_without_eq(cx, item.span, trait_ref, ty);
|
2020-04-19 21:11:30 +00:00
|
|
|
|
} else {
|
2016-02-14 19:29:32 +00:00
|
|
|
|
check_copy_clone(cx, item, trait_ref, ty);
|
2016-01-21 17:19:02 +00:00
|
|
|
|
}
|
2016-06-05 18:46:27 +00:00
|
|
|
|
}
|
2016-01-24 12:56:23 +00:00
|
|
|
|
}
|
|
|
|
|
}
|
2016-01-21 17:19:02 +00:00
|
|
|
|
|
2016-02-15 22:38:09 +00:00
|
|
|
|
/// Implementation of the `DERIVE_HASH_XOR_EQ` lint.
|
2020-06-25 20:41:36 +00:00
|
|
|
|
fn check_hash_peq<'tcx>(
|
|
|
|
|
cx: &LateContext<'tcx>,
|
2016-12-21 11:14:54 +00:00
|
|
|
|
span: Span,
|
2022-06-04 11:34:07 +00:00
|
|
|
|
trait_ref: &hir::TraitRef<'_>,
|
2017-06-11 02:57:25 +00:00
|
|
|
|
ty: Ty<'tcx>,
|
2017-08-09 07:30:56 +00:00
|
|
|
|
hash_is_automatically_derived: bool,
|
2016-12-21 11:14:54 +00:00
|
|
|
|
) {
|
2017-10-23 19:18:02 +00:00
|
|
|
|
if_chain! {
|
|
|
|
|
if let Some(peq_trait_def_id) = cx.tcx.lang_items().eq_trait();
|
2020-10-28 22:36:07 +00:00
|
|
|
|
if let Some(def_id) = trait_ref.trait_def_id();
|
2022-02-26 13:26:21 +00:00
|
|
|
|
if cx.tcx.is_diagnostic_item(sym::Hash, def_id);
|
2017-10-23 19:18:02 +00:00
|
|
|
|
then {
|
|
|
|
|
// Look for the PartialEq implementations for `ty`
|
|
|
|
|
cx.tcx.for_each_relevant_impl(peq_trait_def_id, ty, |impl_id| {
|
2022-04-26 12:04:23 +00:00
|
|
|
|
let peq_is_automatically_derived = cx.tcx.has_attr(impl_id, sym::automatically_derived);
|
2017-11-04 19:55:56 +00:00
|
|
|
|
|
2017-10-23 19:18:02 +00:00
|
|
|
|
if peq_is_automatically_derived == hash_is_automatically_derived {
|
|
|
|
|
return;
|
|
|
|
|
}
|
2017-11-04 19:55:56 +00:00
|
|
|
|
|
2017-10-23 19:18:02 +00:00
|
|
|
|
let trait_ref = cx.tcx.impl_trait_ref(impl_id).expect("must be a trait implementation");
|
2017-11-04 19:55:56 +00:00
|
|
|
|
|
2017-10-23 19:18:02 +00:00
|
|
|
|
// Only care about `impl PartialEq<Foo> for Foo`
|
|
|
|
|
// For `impl PartialEq<B> for A, input_types is [A, B]
|
|
|
|
|
if trait_ref.substs.type_at(1) == ty {
|
|
|
|
|
let mess = if peq_is_automatically_derived {
|
|
|
|
|
"you are implementing `Hash` explicitly but have derived `PartialEq`"
|
|
|
|
|
} else {
|
|
|
|
|
"you are deriving `Hash` but have implemented `PartialEq` explicitly"
|
|
|
|
|
};
|
2017-11-04 19:55:56 +00:00
|
|
|
|
|
2017-10-23 19:18:02 +00:00
|
|
|
|
span_lint_and_then(
|
2020-04-24 09:57:34 +00:00
|
|
|
|
cx,
|
|
|
|
|
DERIVE_HASH_XOR_EQ,
|
|
|
|
|
span,
|
2017-10-23 19:18:02 +00:00
|
|
|
|
mess,
|
2020-04-17 06:08:00 +00:00
|
|
|
|
|diag| {
|
2020-04-24 09:57:34 +00:00
|
|
|
|
if let Some(local_def_id) = impl_id.as_local() {
|
2020-08-12 10:22:56 +00:00
|
|
|
|
let hir_id = cx.tcx.hir().local_def_id_to_hir_id(local_def_id);
|
2020-04-24 09:57:34 +00:00
|
|
|
|
diag.span_note(
|
|
|
|
|
cx.tcx.hir().span(hir_id),
|
|
|
|
|
"`PartialEq` implemented here"
|
|
|
|
|
);
|
|
|
|
|
}
|
2017-10-23 19:18:02 +00:00
|
|
|
|
}
|
2020-04-24 09:57:34 +00:00
|
|
|
|
);
|
2017-10-23 19:18:02 +00:00
|
|
|
|
}
|
|
|
|
|
});
|
|
|
|
|
}
|
|
|
|
|
}
|
2016-01-24 12:56:23 +00:00
|
|
|
|
}
|
2016-01-21 17:19:02 +00:00
|
|
|
|
|
2020-08-11 13:43:21 +00:00
|
|
|
|
/// Implementation of the `DERIVE_ORD_XOR_PARTIAL_ORD` lint.
|
|
|
|
|
fn check_ord_partial_ord<'tcx>(
|
|
|
|
|
cx: &LateContext<'tcx>,
|
|
|
|
|
span: Span,
|
2022-06-04 11:34:07 +00:00
|
|
|
|
trait_ref: &hir::TraitRef<'_>,
|
2020-08-11 13:43:21 +00:00
|
|
|
|
ty: Ty<'tcx>,
|
|
|
|
|
ord_is_automatically_derived: bool,
|
|
|
|
|
) {
|
|
|
|
|
if_chain! {
|
2022-02-26 13:26:21 +00:00
|
|
|
|
if let Some(ord_trait_def_id) = cx.tcx.get_diagnostic_item(sym::Ord);
|
2020-08-11 13:43:21 +00:00
|
|
|
|
if let Some(partial_ord_trait_def_id) = cx.tcx.lang_items().partial_ord_trait();
|
|
|
|
|
if let Some(def_id) = &trait_ref.trait_def_id();
|
|
|
|
|
if *def_id == ord_trait_def_id;
|
|
|
|
|
then {
|
|
|
|
|
// Look for the PartialOrd implementations for `ty`
|
|
|
|
|
cx.tcx.for_each_relevant_impl(partial_ord_trait_def_id, ty, |impl_id| {
|
2022-04-26 12:04:23 +00:00
|
|
|
|
let partial_ord_is_automatically_derived = cx.tcx.has_attr(impl_id, sym::automatically_derived);
|
2020-08-11 13:43:21 +00:00
|
|
|
|
|
|
|
|
|
if partial_ord_is_automatically_derived == ord_is_automatically_derived {
|
|
|
|
|
return;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
let trait_ref = cx.tcx.impl_trait_ref(impl_id).expect("must be a trait implementation");
|
|
|
|
|
|
|
|
|
|
// Only care about `impl PartialOrd<Foo> for Foo`
|
|
|
|
|
// For `impl PartialOrd<B> for A, input_types is [A, B]
|
|
|
|
|
if trait_ref.substs.type_at(1) == ty {
|
|
|
|
|
let mess = if partial_ord_is_automatically_derived {
|
|
|
|
|
"you are implementing `Ord` explicitly but have derived `PartialOrd`"
|
|
|
|
|
} else {
|
|
|
|
|
"you are deriving `Ord` but have implemented `PartialOrd` explicitly"
|
|
|
|
|
};
|
|
|
|
|
|
|
|
|
|
span_lint_and_then(
|
|
|
|
|
cx,
|
|
|
|
|
DERIVE_ORD_XOR_PARTIAL_ORD,
|
|
|
|
|
span,
|
|
|
|
|
mess,
|
|
|
|
|
|diag| {
|
|
|
|
|
if let Some(local_def_id) = impl_id.as_local() {
|
2020-08-12 10:22:56 +00:00
|
|
|
|
let hir_id = cx.tcx.hir().local_def_id_to_hir_id(local_def_id);
|
2020-08-11 13:43:21 +00:00
|
|
|
|
diag.span_note(
|
|
|
|
|
cx.tcx.hir().span(hir_id),
|
|
|
|
|
"`PartialOrd` implemented here"
|
|
|
|
|
);
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
);
|
|
|
|
|
}
|
|
|
|
|
});
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
2016-01-24 12:56:23 +00:00
|
|
|
|
/// Implementation of the `EXPL_IMPL_CLONE_ON_COPY` lint.
|
2022-06-04 11:34:07 +00:00
|
|
|
|
fn check_copy_clone<'tcx>(cx: &LateContext<'tcx>, item: &Item<'_>, trait_ref: &hir::TraitRef<'_>, ty: Ty<'tcx>) {
|
2021-04-08 15:50:13 +00:00
|
|
|
|
let clone_id = match cx.tcx.lang_items().clone_trait() {
|
|
|
|
|
Some(id) if trait_ref.trait_def_id() == Some(id) => id,
|
|
|
|
|
_ => return,
|
|
|
|
|
};
|
|
|
|
|
let copy_id = match cx.tcx.lang_items().copy_trait() {
|
|
|
|
|
Some(id) => id,
|
|
|
|
|
None => return,
|
|
|
|
|
};
|
|
|
|
|
let (ty_adt, ty_subs) = match *ty.kind() {
|
|
|
|
|
// Unions can't derive clone.
|
|
|
|
|
ty::Adt(adt, subs) if !adt.is_union() => (adt, subs),
|
|
|
|
|
_ => return,
|
|
|
|
|
};
|
|
|
|
|
// If the current self type doesn't implement Copy (due to generic constraints), search to see if
|
|
|
|
|
// there's a Copy impl for any instance of the adt.
|
|
|
|
|
if !is_copy(cx, ty) {
|
|
|
|
|
if ty_subs.non_erasable_generics().next().is_some() {
|
2021-05-20 10:30:31 +00:00
|
|
|
|
let has_copy_impl = cx.tcx.all_local_trait_impls(()).get(©_id).map_or(false, |impls| {
|
|
|
|
|
impls
|
|
|
|
|
.iter()
|
2022-03-04 20:28:41 +00:00
|
|
|
|
.any(|&id| matches!(cx.tcx.type_of(id).kind(), ty::Adt(adt, _) if ty_adt.did() == adt.did()))
|
2021-05-20 10:30:31 +00:00
|
|
|
|
});
|
2021-04-08 15:50:13 +00:00
|
|
|
|
if !has_copy_impl {
|
|
|
|
|
return;
|
|
|
|
|
}
|
|
|
|
|
} else {
|
2017-04-28 15:03:18 +00:00
|
|
|
|
return;
|
2016-01-24 12:56:23 +00:00
|
|
|
|
}
|
|
|
|
|
}
|
2021-04-08 15:50:13 +00:00
|
|
|
|
// Derive constrains all generic types to requiring Clone. Check if any type is not constrained for
|
|
|
|
|
// this impl.
|
|
|
|
|
if ty_subs.types().any(|ty| !implements_trait(cx, ty, clone_id, &[])) {
|
|
|
|
|
return;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
span_lint_and_note(
|
|
|
|
|
cx,
|
|
|
|
|
EXPL_IMPL_CLONE_ON_COPY,
|
|
|
|
|
item.span,
|
|
|
|
|
"you are implementing `Clone` explicitly on a `Copy` type",
|
|
|
|
|
Some(item.span),
|
|
|
|
|
"consider deriving `Clone` or removing `Copy`",
|
|
|
|
|
);
|
2016-01-24 12:56:23 +00:00
|
|
|
|
}
|
2020-04-19 21:11:30 +00:00
|
|
|
|
|
|
|
|
|
/// Implementation of the `UNSAFE_DERIVE_DESERIALIZE` lint.
|
2020-06-25 20:41:36 +00:00
|
|
|
|
fn check_unsafe_derive_deserialize<'tcx>(
|
|
|
|
|
cx: &LateContext<'tcx>,
|
2020-04-20 18:05:15 +00:00
|
|
|
|
item: &Item<'_>,
|
2022-06-04 11:34:07 +00:00
|
|
|
|
trait_ref: &hir::TraitRef<'_>,
|
2020-04-19 21:11:30 +00:00
|
|
|
|
ty: Ty<'tcx>,
|
|
|
|
|
) {
|
2020-06-25 20:41:36 +00:00
|
|
|
|
fn has_unsafe<'tcx>(cx: &LateContext<'tcx>, item: &'tcx Item<'_>) -> bool {
|
2020-04-19 21:11:30 +00:00
|
|
|
|
let mut visitor = UnsafeVisitor { cx, has_unsafe: false };
|
|
|
|
|
walk_item(&mut visitor, item);
|
|
|
|
|
visitor.has_unsafe
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
if_chain! {
|
2020-10-28 22:36:07 +00:00
|
|
|
|
if let Some(trait_def_id) = trait_ref.trait_def_id();
|
|
|
|
|
if match_def_path(cx, trait_def_id, &paths::SERDE_DESERIALIZE);
|
2020-08-03 22:18:29 +00:00
|
|
|
|
if let ty::Adt(def, _) = ty.kind();
|
2022-03-04 20:28:41 +00:00
|
|
|
|
if let Some(local_def_id) = def.did().as_local();
|
2020-08-12 10:22:56 +00:00
|
|
|
|
let adt_hir_id = cx.tcx.hir().local_def_id_to_hir_id(local_def_id);
|
2021-07-15 08:44:10 +00:00
|
|
|
|
if !is_lint_allowed(cx, UNSAFE_DERIVE_DESERIALIZE, adt_hir_id);
|
2022-03-04 20:28:41 +00:00
|
|
|
|
if cx.tcx.inherent_impls(def.did())
|
2020-04-19 21:11:30 +00:00
|
|
|
|
.iter()
|
2021-10-20 20:38:10 +00:00
|
|
|
|
.map(|imp_did| cx.tcx.hir().expect_item(imp_did.expect_local()))
|
2020-04-19 21:11:30 +00:00
|
|
|
|
.any(|imp| has_unsafe(cx, imp));
|
|
|
|
|
then {
|
|
|
|
|
span_lint_and_help(
|
|
|
|
|
cx,
|
|
|
|
|
UNSAFE_DERIVE_DESERIALIZE,
|
|
|
|
|
item.span,
|
|
|
|
|
"you are deriving `serde::Deserialize` on a type that has methods using `unsafe`",
|
|
|
|
|
None,
|
|
|
|
|
"consider implementing `serde::Deserialize` manually. See https://serde.rs/impl-deserialize.html"
|
|
|
|
|
);
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
struct UnsafeVisitor<'a, 'tcx> {
|
2020-06-25 20:41:36 +00:00
|
|
|
|
cx: &'a LateContext<'tcx>,
|
2020-04-19 21:11:30 +00:00
|
|
|
|
has_unsafe: bool,
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
impl<'tcx> Visitor<'tcx> for UnsafeVisitor<'_, 'tcx> {
|
2022-01-15 22:07:52 +00:00
|
|
|
|
type NestedFilter = nested_filter::All;
|
2020-04-19 21:11:30 +00:00
|
|
|
|
|
2022-09-12 03:13:22 +00:00
|
|
|
|
fn visit_fn(&mut self, kind: FnKind<'tcx>, decl: &'tcx FnDecl<'_>, body_id: BodyId, _: Span, id: HirId) {
|
2020-04-19 21:11:30 +00:00
|
|
|
|
if self.has_unsafe {
|
|
|
|
|
return;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
if_chain! {
|
|
|
|
|
if let Some(header) = kind.header();
|
2021-10-07 09:21:30 +00:00
|
|
|
|
if header.unsafety == Unsafety::Unsafe;
|
2020-04-19 21:11:30 +00:00
|
|
|
|
then {
|
|
|
|
|
self.has_unsafe = true;
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
2022-09-12 03:13:22 +00:00
|
|
|
|
walk_fn(self, kind, decl, body_id, id);
|
2020-04-19 21:11:30 +00:00
|
|
|
|
}
|
|
|
|
|
|
2020-04-20 18:05:15 +00:00
|
|
|
|
fn visit_expr(&mut self, expr: &'tcx Expr<'_>) {
|
2020-04-19 21:11:30 +00:00
|
|
|
|
if self.has_unsafe {
|
|
|
|
|
return;
|
|
|
|
|
}
|
|
|
|
|
|
2020-04-20 18:05:15 +00:00
|
|
|
|
if let ExprKind::Block(block, _) = expr.kind {
|
2021-10-07 09:21:30 +00:00
|
|
|
|
if block.rules == BlockCheckMode::UnsafeBlock(UnsafeSource::UserProvided) {
|
2021-07-01 16:17:38 +00:00
|
|
|
|
self.has_unsafe = true;
|
2020-04-19 21:11:30 +00:00
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
walk_expr(self, expr);
|
|
|
|
|
}
|
|
|
|
|
|
2022-01-15 22:07:52 +00:00
|
|
|
|
fn nested_visit_map(&mut self) -> Self::Map {
|
|
|
|
|
self.cx.tcx.hir()
|
2020-04-19 21:11:30 +00:00
|
|
|
|
}
|
|
|
|
|
}
|
2022-05-21 11:24:00 +00:00
|
|
|
|
|
|
|
|
|
/// Implementation of the `DERIVE_PARTIAL_EQ_WITHOUT_EQ` lint.
|
2022-06-04 11:34:07 +00:00
|
|
|
|
fn check_partial_eq_without_eq<'tcx>(cx: &LateContext<'tcx>, span: Span, trait_ref: &hir::TraitRef<'_>, ty: Ty<'tcx>) {
|
2022-05-21 11:24:00 +00:00
|
|
|
|
if_chain! {
|
|
|
|
|
if let ty::Adt(adt, substs) = ty.kind();
|
2022-08-27 21:10:06 +00:00
|
|
|
|
if cx.tcx.visibility(adt.did()).is_public();
|
2022-05-21 11:24:00 +00:00
|
|
|
|
if let Some(eq_trait_def_id) = cx.tcx.get_diagnostic_item(sym::Eq);
|
|
|
|
|
if let Some(def_id) = trait_ref.trait_def_id();
|
|
|
|
|
if cx.tcx.is_diagnostic_item(sym::PartialEq, def_id);
|
2022-06-16 15:39:06 +00:00
|
|
|
|
let param_env = param_env_for_derived_eq(cx.tcx, adt.did(), eq_trait_def_id);
|
|
|
|
|
if !implements_trait_with_env(cx.tcx, param_env, ty, eq_trait_def_id, &[]);
|
|
|
|
|
// If all of our fields implement `Eq`, we can implement `Eq` too
|
|
|
|
|
if adt
|
|
|
|
|
.all_fields()
|
|
|
|
|
.map(|f| f.ty(cx.tcx, substs))
|
|
|
|
|
.all(|ty| implements_trait_with_env(cx.tcx, param_env, ty, eq_trait_def_id, &[]));
|
2022-05-21 11:24:00 +00:00
|
|
|
|
then {
|
|
|
|
|
span_lint_and_sugg(
|
|
|
|
|
cx,
|
|
|
|
|
DERIVE_PARTIAL_EQ_WITHOUT_EQ,
|
|
|
|
|
span.ctxt().outer_expn_data().call_site,
|
|
|
|
|
"you are deriving `PartialEq` and can implement `Eq`",
|
|
|
|
|
"consider deriving `Eq` as well",
|
|
|
|
|
"PartialEq, Eq".to_string(),
|
|
|
|
|
Applicability::MachineApplicable,
|
|
|
|
|
)
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
}
|
2022-06-16 15:39:06 +00:00
|
|
|
|
|
|
|
|
|
/// Creates the `ParamEnv` used for the give type's derived `Eq` impl.
|
|
|
|
|
fn param_env_for_derived_eq(tcx: TyCtxt<'_>, did: DefId, eq_trait_id: DefId) -> ParamEnv<'_> {
|
|
|
|
|
// Initial map from generic index to param def.
|
|
|
|
|
// Vec<(param_def, needs_eq)>
|
|
|
|
|
let mut params = tcx
|
|
|
|
|
.generics_of(did)
|
|
|
|
|
.params
|
|
|
|
|
.iter()
|
|
|
|
|
.map(|p| (p, matches!(p.kind, GenericParamDefKind::Type { .. })))
|
|
|
|
|
.collect::<Vec<_>>();
|
|
|
|
|
|
|
|
|
|
let ty_predicates = tcx.predicates_of(did).predicates;
|
|
|
|
|
for (p, _) in ty_predicates {
|
|
|
|
|
if let PredicateKind::Trait(p) = p.kind().skip_binder()
|
|
|
|
|
&& p.trait_ref.def_id == eq_trait_id
|
|
|
|
|
&& let ty::Param(self_ty) = p.trait_ref.self_ty().kind()
|
|
|
|
|
&& p.constness == BoundConstness::NotConst
|
|
|
|
|
{
|
|
|
|
|
// Flag types which already have an `Eq` bound.
|
|
|
|
|
params[self_ty.index as usize].1 = false;
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
ParamEnv::new(
|
|
|
|
|
tcx.mk_predicates(ty_predicates.iter().map(|&(p, _)| p).chain(
|
|
|
|
|
params.iter().filter(|&&(_, needs_eq)| needs_eq).map(|&(param, _)| {
|
|
|
|
|
tcx.mk_predicate(Binder::dummy(PredicateKind::Trait(TraitPredicate {
|
2022-08-31 13:24:45 +00:00
|
|
|
|
trait_ref: TraitRef::new(
|
|
|
|
|
eq_trait_id,
|
|
|
|
|
tcx.mk_substs(std::iter::once(tcx.mk_param_from_def(param))),
|
|
|
|
|
),
|
2022-06-16 15:39:06 +00:00
|
|
|
|
constness: BoundConstness::NotConst,
|
|
|
|
|
polarity: ImplPolarity::Positive,
|
|
|
|
|
})))
|
|
|
|
|
}),
|
|
|
|
|
)),
|
|
|
|
|
Reveal::UserFacing,
|
|
|
|
|
Constness::NotConst,
|
|
|
|
|
)
|
|
|
|
|
}
|