rust-clippy/tests/ui/nonminimal_bool.rs

159 lines
3.7 KiB
Rust
Raw Normal View History

//@no-rustfix: overlapping suggestions
#![feature(lint_reasons)]
#![allow(
unused,
clippy::diverging_sub_expression,
clippy::needless_if,
clippy::redundant_pattern_matching
)]
2020-01-13 22:41:11 +00:00
#![warn(clippy::nonminimal_bool)]
#![allow(clippy::useless_vec)]
2020-01-13 22:41:11 +00:00
fn main() {
let a: bool = unimplemented!();
let b: bool = unimplemented!();
let c: bool = unimplemented!();
let d: bool = unimplemented!();
let e: bool = unimplemented!();
let _ = !true;
//~^ ERROR: this boolean expression can be simplified
//~| NOTE: `-D clippy::nonminimal-bool` implied by `-D warnings`
2020-01-13 22:41:11 +00:00
let _ = !false;
//~^ ERROR: this boolean expression can be simplified
2020-01-13 22:41:11 +00:00
let _ = !!a;
//~^ ERROR: this boolean expression can be simplified
2020-01-13 22:41:11 +00:00
let _ = false || a;
//~^ ERROR: this boolean expression can be simplified
2020-01-13 22:41:11 +00:00
// don't lint on cfgs
let _ = cfg!(you_shall_not_not_pass) && a;
let _ = a || !b || !c || !d || !e;
let _ = !(!a && b);
//~^ ERROR: this boolean expression can be simplified
2020-01-13 22:41:11 +00:00
let _ = !(!a || b);
//~^ ERROR: this boolean expression can be simplified
2020-01-13 22:41:11 +00:00
let _ = !a && !(b && c);
//~^ ERROR: this boolean expression can be simplified
2020-01-13 22:41:11 +00:00
}
fn equality_stuff() {
let a: i32 = unimplemented!();
let b: i32 = unimplemented!();
let c: i32 = unimplemented!();
let d: i32 = unimplemented!();
let _ = a == b && c == 5 && a == b;
//~^ ERROR: this boolean expression can be simplified
2020-01-13 22:41:11 +00:00
let _ = a == b || c == 5 || a == b;
//~^ ERROR: this boolean expression can be simplified
2020-01-13 22:41:11 +00:00
let _ = a == b && c == 5 && b == a;
//~^ ERROR: this boolean expression can be simplified
2020-01-13 22:41:11 +00:00
let _ = a != b || !(a != b || c == d);
//~^ ERROR: this boolean expression can be simplified
2020-01-13 22:41:11 +00:00
let _ = a != b && !(a != b && c == d);
//~^ ERROR: this boolean expression can be simplified
2020-01-13 22:41:11 +00:00
}
fn issue3847(a: u32, b: u32) -> bool {
const THRESHOLD: u32 = 1_000;
if a < THRESHOLD && b >= THRESHOLD || a >= THRESHOLD && b < THRESHOLD {
return false;
}
true
}
fn issue4548() {
fn f(_i: u32, _j: u32) -> u32 {
unimplemented!();
}
let i = 0;
let j = 0;
if i != j && f(i, j) != 0 || i == j && f(i, j) != 1 {}
}
fn check_expect() {
let a: bool = unimplemented!();
#[expect(clippy::nonminimal_bool)]
let _ = !!a;
}
fn issue9428() {
if matches!(true, true) && true {
//~^ ERROR: this boolean expression can be simplified
println!("foo");
}
}
fn issue_10523() {
macro_rules! a {
($v:expr) => {
$v.is_some()
};
}
let x: Option<u32> = None;
if !a!(x) {}
}
fn issue_10523_1() {
macro_rules! a {
($v:expr) => {
!$v.is_some()
};
}
let x: Option<u32> = None;
if a!(x) {}
}
fn issue_10523_2() {
macro_rules! a {
() => {
!None::<u32>.is_some()
};
}
if a!() {}
}
fn issue_10435() {
let x = vec![0];
let y = vec![1];
let z = vec![2];
// vvv Should not lint
#[allow(clippy::nonminimal_bool)]
if !x.is_empty() && !(y.is_empty() || z.is_empty()) {
println!("{}", line!());
}
// vvv Should not lint (#10435 talks about a bug where it lints)
#[allow(clippy::nonminimal_bool)]
if !(x == [0]) {
println!("{}", line!());
}
}
fn issue10836() {
struct Foo(bool);
impl std::ops::Not for Foo {
type Output = bool;
fn not(self) -> Self::Output {
!self.0
}
}
// Should not lint
let _: bool = !!Foo(true);
}
fn issue11932() {
let x: i32 = unimplemented!();
#[allow(clippy::nonminimal_bool)]
let _ = x % 2 == 0 || {
// Should not lint
assert!(x > 0);
x % 3 == 0
};
}