rust-clippy/src/panic.rs

48 lines
1.5 KiB
Rust
Raw Normal View History

2015-12-23 21:37:52 +00:00
use rustc::lint::*;
use rustc::hir::*;
2016-02-12 17:35:44 +00:00
use syntax::ast::LitKind;
use utils::{span_lint, is_direct_expn_of, match_path, BEGIN_UNWIND};
2015-12-23 21:37:52 +00:00
/// **What it does:** This lint checks for missing parameters in `panic!`.
2015-12-23 21:37:52 +00:00
///
/// **Known problems:** Should you want to use curly brackets in `panic!` without any parameter,
/// this lint will warn.
///
/// **Example:**
/// ```
/// panic!("This `panic!` is probably missing a parameter there: {}");
2015-12-23 21:37:52 +00:00
/// ```
declare_lint! {
pub PANIC_PARAMS, Warn, "missing parameters in `panic!`"
}
2015-12-23 21:37:52 +00:00
#[allow(missing_copy_implementations)]
pub struct PanicPass;
impl LintPass for PanicPass {
fn get_lints(&self) -> LintArray {
lint_array!(PANIC_PARAMS)
}
}
impl LateLintPass for PanicPass {
fn check_expr(&mut self, cx: &LateContext, expr: &Expr) {
if_let_chain! {[
2015-12-24 09:57:31 +00:00
let ExprBlock(ref block) = expr.node,
let Some(ref ex) = block.expr,
let ExprCall(ref fun, ref params) = ex.node,
2015-12-23 21:37:52 +00:00
params.len() == 2,
let ExprPath(None, ref path) = fun.node,
match_path(path, &BEGIN_UNWIND),
let ExprLit(ref lit) = params[0].node,
is_direct_expn_of(cx, params[0].span, "panic").is_some(),
2016-02-12 17:35:44 +00:00
let LitKind::Str(ref string, _) = lit.node,
let Some(par) = string.find('{'),
string[par..].contains('}')
2015-12-23 21:37:52 +00:00
], {
span_lint(cx, PANIC_PARAMS, params[0].span,
"you probably are missing some parameter in your format string");
2015-12-23 21:37:52 +00:00
}}
}
}