rust-clippy/tests/ui/needless_borrow.rs

53 lines
1.1 KiB
Rust
Raw Normal View History

// run-rustfix
2018-07-28 15:34:52 +00:00
#[warn(clippy::all, clippy::needless_borrow)]
2016-04-26 13:49:53 +00:00
#[allow(unused_variables)]
fn main() {
let a = 5;
let _ = x(&a); // no warning
let _ = x(&&a); // warn
let mut b = 5;
mut_ref(&mut b); // no warning
mut_ref(&mut &mut b); // warn
2016-04-26 13:49:53 +00:00
let s = &String::from("hi");
let s_ident = f(&s); // should not error, because `&String` implements Copy, but `String` does not
let g_val = g(&Vec::new()); // should not error, because `&Vec<T>` derefs to `&[T]`
let vec = Vec::new();
let vec_val = g(&vec); // should not error, because `&Vec<T>` derefs to `&[T]`
h(&"foo"); // should not error, because the `&&str` is required, due to `&Trait`
let garbl = match 42 {
44 => &a,
45 => {
println!("foo");
&&a // FIXME: this should lint, too
},
46 => &&a,
_ => panic!(),
};
2016-04-26 13:49:53 +00:00
}
#[allow(clippy::needless_borrowed_reference)]
fn x(y: &i32) -> i32 {
*y
}
fn mut_ref(y: &mut i32) {
*y = 5;
}
2018-12-09 22:26:16 +00:00
fn f<T: Copy>(y: &T) -> T {
2016-04-26 13:49:53 +00:00
*y
}
fn g(y: &[u8]) -> u8 {
y[0]
}
trait Trait {}
impl<'a> Trait for &'a str {}
fn h(_: &dyn Trait) {}