2020-01-06 06:36:33 +00:00
|
|
|
error: in an `if` condition, avoid complex blocks or closures with blocks; instead, move the block or closure higher and bind it with a `let`
|
2024-02-17 12:16:29 +00:00
|
|
|
--> tests/ui/blocks_in_conditions.rs:25:5
|
2017-02-07 20:05:30 +00:00
|
|
|
|
|
2020-02-04 15:08:39 +00:00
|
|
|
LL | / if {
|
2023-11-30 07:41:54 +00:00
|
|
|
LL | |
|
2018-12-27 15:57:55 +00:00
|
|
|
LL | | let x = 3;
|
|
|
|
LL | | x == 3
|
|
|
|
LL | | } {
|
2017-04-23 13:25:22 +00:00
|
|
|
| |_____^
|
2017-02-07 20:05:30 +00:00
|
|
|
|
|
2023-11-30 07:41:54 +00:00
|
|
|
= note: `-D clippy::blocks-in-conditions` implied by `-D warnings`
|
|
|
|
= help: to override `-D warnings` add `#[allow(clippy::blocks_in_conditions)]`
|
2020-02-04 15:08:39 +00:00
|
|
|
help: try
|
|
|
|
|
|
2021-08-11 14:21:33 +00:00
|
|
|
LL ~ let res = {
|
2023-11-30 07:41:54 +00:00
|
|
|
LL +
|
2021-08-11 14:21:33 +00:00
|
|
|
LL + let x = 3;
|
|
|
|
LL + x == 3
|
|
|
|
LL ~ }; if res {
|
2020-02-04 15:08:39 +00:00
|
|
|
|
|
2017-02-07 20:05:30 +00:00
|
|
|
|
|
|
|
error: omit braces around single expression condition
|
2024-02-17 12:16:29 +00:00
|
|
|
--> tests/ui/blocks_in_conditions.rs:37:8
|
2017-02-07 20:05:30 +00:00
|
|
|
|
|
2021-03-12 14:30:50 +00:00
|
|
|
LL | if { true } { 6 } else { 10 }
|
2020-02-04 15:08:39 +00:00
|
|
|
| ^^^^^^^^ help: try: `true`
|
2017-02-07 20:05:30 +00:00
|
|
|
|
2017-05-17 12:19:44 +00:00
|
|
|
error: this boolean expression can be simplified
|
2024-02-17 12:16:29 +00:00
|
|
|
--> tests/ui/blocks_in_conditions.rs:43:8
|
2017-02-07 20:05:30 +00:00
|
|
|
|
|
2021-03-12 14:30:50 +00:00
|
|
|
LL | if true && x == 3 { 6 } else { 10 }
|
2017-07-21 08:40:23 +00:00
|
|
|
| ^^^^^^^^^^^^^^ help: try: `x == 3`
|
2017-02-07 20:05:30 +00:00
|
|
|
|
|
2018-08-01 14:30:44 +00:00
|
|
|
= note: `-D clippy::nonminimal-bool` implied by `-D warnings`
|
2023-08-01 12:02:21 +00:00
|
|
|
= help: to override `-D warnings` add `#[allow(clippy::nonminimal_bool)]`
|
2017-05-17 12:19:44 +00:00
|
|
|
|
2023-11-30 07:41:54 +00:00
|
|
|
error: in a `match` scrutinee, avoid complex blocks or closures with blocks; instead, move the block or closure higher and bind it with a `let`
|
2024-02-17 12:16:29 +00:00
|
|
|
--> tests/ui/blocks_in_conditions.rs:70:5
|
2023-11-22 01:29:44 +00:00
|
|
|
|
|
|
|
|
LL | / match {
|
2023-11-30 07:41:54 +00:00
|
|
|
LL | |
|
2023-11-22 01:29:44 +00:00
|
|
|
LL | | let opt = Some(2);
|
|
|
|
LL | | opt
|
|
|
|
LL | | } {
|
|
|
|
| |_____^
|
|
|
|
|
|
|
|
|
help: try
|
|
|
|
|
|
|
|
|
LL ~ let res = {
|
2023-11-30 07:41:54 +00:00
|
|
|
LL +
|
2023-11-22 01:29:44 +00:00
|
|
|
LL + let opt = Some(2);
|
|
|
|
LL + opt
|
|
|
|
LL ~ }; match res {
|
|
|
|
|
|
|
|
|
|
2024-02-11 20:16:11 +00:00
|
|
|
error: aborting due to 4 previous errors
|
2018-01-16 16:06:27 +00:00
|
|
|
|