rust-clippy/tests/ui/needless_pass_by_value.stderr

error: this argument is passed by value, but not consumed in the function body
  --> $DIR/needless_pass_by_value.rs:18:23
   |
LL | fn foo<T: Default>(v: Vec<T>, w: Vec<T>, mut x: Vec<T>, y: Vec<T>) -> Vec<T> {
   |                       ^^^^^^ help: consider changing the type to: `&[T]`
   |
   = note: `-D clippy::needless-pass-by-value` implied by `-D warnings`

error: this argument is passed by value, but not consumed in the function body
  --> $DIR/needless_pass_by_value.rs:32:11
   |
LL | fn bar(x: String, y: Wrapper) {
   |           ^^^^^^ help: consider changing the type to: `&str`

error: this argument is passed by value, but not consumed in the function body
  --> $DIR/needless_pass_by_value.rs:32:22
   |
LL | fn bar(x: String, y: Wrapper) {
   |                      ^^^^^^^ help: consider taking a reference instead: `&Wrapper`

error: this argument is passed by value, but not consumed in the function body
  --> $DIR/needless_pass_by_value.rs:38:71
   |
LL | fn test_borrow_trait<T: Borrow<str>, U: AsRef<str>, V>(t: T, u: U, v: V) {
   |                                                                       ^ help: consider taking a reference instead: `&V`

error: this argument is passed by value, but not consumed in the function body
  --> $DIR/needless_pass_by_value.rs:50:18
   |
LL | fn test_match(x: Option<Option<String>>, y: Option<Option<String>>) {
   |                  ^^^^^^^^^^^^^^^^^^^^^^ help: consider taking a reference instead: `&Option<Option<String>>`

error: this argument is passed by value, but not consumed in the function body
  --> $DIR/needless_pass_by_value.rs:63:24
   |
LL | fn test_destructure(x: Wrapper, y: Wrapper, z: Wrapper) {
   |                        ^^^^^^^ help: consider taking a reference instead: `&Wrapper`

error: this argument is passed by value, but not consumed in the function body
  --> $DIR/needless_pass_by_value.rs:63:36
   |
LL | fn test_destructure(x: Wrapper, y: Wrapper, z: Wrapper) {
   |                                    ^^^^^^^ help: consider taking a reference instead: `&Wrapper`

error: this argument is passed by value, but not consumed in the function body
  --> $DIR/needless_pass_by_value.rs:79:49
   |
LL | fn test_blanket_ref<T: Foo, S: Serialize>(_foo: T, _serializable: S) {}
   |                                                 ^ help: consider taking a reference instead: `&T`

error: this argument is passed by value, but not consumed in the function body
  --> $DIR/needless_pass_by_value.rs:81:18
   |
LL | fn issue_2114(s: String, t: String, u: Vec<i32>, v: Vec<i32>) {
   |                  ^^^^^^ help: consider taking a reference instead: `&String`

error: this argument is passed by value, but not consumed in the function body
  --> $DIR/needless_pass_by_value.rs:81:29
   |
LL | fn issue_2114(s: String, t: String, u: Vec<i32>, v: Vec<i32>) {
   |                             ^^^^^^
   |
help: consider changing the type to
   |
LL | fn issue_2114(s: String, t: &str, u: Vec<i32>, v: Vec<i32>) {
   |                             ^^^^
help: change `t.clone()` to
   |
LL |     let _ = t.to_string();
   |             ^^^^^^^^^^^^^

error: this argument is passed by value, but not consumed in the function body
  --> $DIR/needless_pass_by_value.rs:81:40
   |
LL | fn issue_2114(s: String, t: String, u: Vec<i32>, v: Vec<i32>) {
   |                                        ^^^^^^^^ help: consider taking a reference instead: `&Vec<i32>`

error: this argument is passed by value, but not consumed in the function body
  --> $DIR/needless_pass_by_value.rs:81:53
   |
LL | fn issue_2114(s: String, t: String, u: Vec<i32>, v: Vec<i32>) {
   |                                                     ^^^^^^^^
   |
help: consider changing the type to
   |
LL | fn issue_2114(s: String, t: String, u: Vec<i32>, v: &[i32]) {
   |                                                     ^^^^^^
help: change `v.clone()` to
   |
LL |     let _ = v.to_owned();
   |             ^^^^^^^^^^^^

error: this argument is passed by value, but not consumed in the function body
  --> $DIR/needless_pass_by_value.rs:94:12
   |
LL |         s: String,
   |            ^^^^^^ help: consider changing the type to: `&str`

error: this argument is passed by value, but not consumed in the function body
  --> $DIR/needless_pass_by_value.rs:95:12
   |
LL |         t: String,
   |            ^^^^^^ help: consider taking a reference instead: `&String`

error: this argument is passed by value, but not consumed in the function body
  --> $DIR/needless_pass_by_value.rs:104:23
   |
LL |     fn baz(&self, _u: U, _s: Self) {}
   |                       ^ help: consider taking a reference instead: `&U`

error: this argument is passed by value, but not consumed in the function body
  --> $DIR/needless_pass_by_value.rs:104:30
   |
LL |     fn baz(&self, _u: U, _s: Self) {}
   |                              ^^^^ help: consider taking a reference instead: `&Self`

error: this argument is passed by value, but not consumed in the function body
  --> $DIR/needless_pass_by_value.rs:126:24
   |
LL | fn bar_copy(x: u32, y: CopyWrapper) {
   |                        ^^^^^^^^^^^ help: consider taking a reference instead: `&CopyWrapper`
   |
help: consider marking this type as Copy
  --> $DIR/needless_pass_by_value.rs:124:1
   |
LL | struct CopyWrapper(u32);
   | ^^^^^^^^^^^^^^^^^^^^^^^^

error: this argument is passed by value, but not consumed in the function body
  --> $DIR/needless_pass_by_value.rs:132:29
   |
LL | fn test_destructure_copy(x: CopyWrapper, y: CopyWrapper, z: CopyWrapper) {
   |                             ^^^^^^^^^^^ help: consider taking a reference instead: `&CopyWrapper`
   |
help: consider marking this type as Copy
  --> $DIR/needless_pass_by_value.rs:124:1
   |
LL | struct CopyWrapper(u32);
   | ^^^^^^^^^^^^^^^^^^^^^^^^

error: this argument is passed by value, but not consumed in the function body
  --> $DIR/needless_pass_by_value.rs:132:45
   |
LL | fn test_destructure_copy(x: CopyWrapper, y: CopyWrapper, z: CopyWrapper) {
   |                                             ^^^^^^^^^^^ help: consider taking a reference instead: `&CopyWrapper`
   |
help: consider marking this type as Copy
  --> $DIR/needless_pass_by_value.rs:124:1
   |
LL | struct CopyWrapper(u32);
   | ^^^^^^^^^^^^^^^^^^^^^^^^

error: this argument is passed by value, but not consumed in the function body
  --> $DIR/needless_pass_by_value.rs:132:61
   |
LL | fn test_destructure_copy(x: CopyWrapper, y: CopyWrapper, z: CopyWrapper) {
   |                                                             ^^^^^^^^^^^ help: consider taking a reference instead: `&CopyWrapper`
   |
help: consider marking this type as Copy
  --> $DIR/needless_pass_by_value.rs:124:1
   |
LL | struct CopyWrapper(u32);
   | ^^^^^^^^^^^^^^^^^^^^^^^^

error: this argument is passed by value, but not consumed in the function body
  --> $DIR/needless_pass_by_value.rs:144:40
   |
LL | fn some_fun<'b, S: Bar<'b, ()>>(_item: S) {}
   |                                        ^ help: consider taking a reference instead: `&S`

error: this argument is passed by value, but not consumed in the function body
  --> $DIR/needless_pass_by_value.rs:149:20
   |
LL | fn more_fun(_item: impl Club<'static, i32>) {}
   |                    ^^^^^^^^^^^^^^^^^^^^^^^ help: consider taking a reference instead: `&impl Club<'static, i32>`

error: aborting due to 22 previous errors
Rename lint to needless_take_by_value And fixes false-positives for generics and `match` 2017-02-20 03:50:31 +00:00			`error: this argument is passed by value, but not consumed in the function body`
rustup improper_ctypes: `extern "C"` fns 2019-11-06 17:38:10 +00:00			`--> $DIR/needless_pass_by_value.rs:18:23`
Adapt the *.stderr files of the ui-tests to the tool_lints 2018-08-01 14:30:44 +00:00			`\|`
Update *.stderr files 2018-12-27 15:57:55 +00:00			`LL \| fn foo<T: Default>(v: Vec<T>, w: Vec<T>, mut x: Vec<T>, y: Vec<T>) -> Vec<T> {`
Adapt the *.stderr files of the ui-tests to the tool_lints 2018-08-01 14:30:44 +00:00			\| ^^^^^^ help: consider changing the type to: `&[T]`
			`\|`
			= note: `-D clippy::needless-pass-by-value` implied by `-D warnings`
Rename lint to needless_take_by_value And fixes false-positives for generics and `match` 2017-02-20 03:50:31 +00:00
			`error: this argument is passed by value, but not consumed in the function body`
rustup improper_ctypes: `extern "C"` fns 2019-11-06 17:38:10 +00:00			`--> $DIR/needless_pass_by_value.rs:32:11`
Rename lint to needless_take_by_value And fixes false-positives for generics and `match` 2017-02-20 03:50:31 +00:00			`\|`
Update *.stderr files 2018-12-27 15:57:55 +00:00			`LL \| fn bar(x: String, y: Wrapper) {`
Fix ui tests 2017-07-21 08:40:23 +00:00			\| ^^^^^^ help: consider changing the type to: `&str`
Rename lint to needless_take_by_value And fixes false-positives for generics and `match` 2017-02-20 03:50:31 +00:00
			`error: this argument is passed by value, but not consumed in the function body`
rustup improper_ctypes: `extern "C"` fns 2019-11-06 17:38:10 +00:00			`--> $DIR/needless_pass_by_value.rs:32:22`
Rename lint to needless_take_by_value And fixes false-positives for generics and `match` 2017-02-20 03:50:31 +00:00			`\|`
Update *.stderr files 2018-12-27 15:57:55 +00:00			`LL \| fn bar(x: String, y: Wrapper) {`
Fix ui tests 2017-07-21 08:40:23 +00:00			\| ^^^^^^^ help: consider taking a reference instead: `&Wrapper`
Rename lint to needless_take_by_value And fixes false-positives for generics and `match` 2017-02-20 03:50:31 +00:00
			`error: this argument is passed by value, but not consumed in the function body`
rustup improper_ctypes: `extern "C"` fns 2019-11-06 17:38:10 +00:00			`--> $DIR/needless_pass_by_value.rs:38:71`
Rename lint to needless_take_by_value And fixes false-positives for generics and `match` 2017-02-20 03:50:31 +00:00			`\|`
Update *.stderr files 2018-12-27 15:57:55 +00:00			`LL \| fn test_borrow_trait<T: Borrow<str>, U: AsRef<str>, V>(t: T, u: U, v: V) {`
Reduce false-positives for needless_pass_by_value lint Excluding a type whose reference also fulfills the trait bound. 2017-10-08 01:23:41 +00:00			\| ^ help: consider taking a reference instead: `&V`
Rename lint to needless_take_by_value And fixes false-positives for generics and `match` 2017-02-20 03:50:31 +00:00
Support non-moving usages at `match` This `match` is not moving the `String`: ```rust fn foo(x: Option<String>) -> i32 { match x { Some(_) => 1, None => 2, } } ``` With this change, it will be linted and suggested to add `` to deref it. ```rust fn foo(x: &Option<String>) -> i32 { match x { Some(_) => 1, None => 2, } } ``` 2017-02-20 07:45:37 +00:00			`error: this argument is passed by value, but not consumed in the function body`
rustup improper_ctypes: `extern "C"` fns 2019-11-06 17:38:10 +00:00			`--> $DIR/needless_pass_by_value.rs:50:18`
Support non-moving usages at `match` This `match` is not moving the `String`: ```rust fn foo(x: Option<String>) -> i32 { match x { Some(_) => 1, None => 2, } } ``` With this change, it will be linted and suggested to add `` to deref it. ```rust fn foo(x: &Option<String>) -> i32 { match x { Some(_) => 1, None => 2, } } ``` 2017-02-20 07:45:37 +00:00			`\|`
Update *.stderr files 2018-12-27 15:57:55 +00:00			`LL \| fn test_match(x: Option<Option<String>>, y: Option<Option<String>>) {`
Fix needless_pass_by_value This also accidentally improved the spans of the suggestions 2019-10-04 13:00:01 +00:00			\| ^^^^^^^^^^^^^^^^^^^^^^ help: consider taking a reference instead: `&Option<Option<String>>`
Support non-moving usages at `match` This `match` is not moving the `String`: ```rust fn foo(x: Option<String>) -> i32 { match x { Some(_) => 1, None => 2, } } ``` With this change, it will be linted and suggested to add `` to deref it. ```rust fn foo(x: &Option<String>) -> i32 { match x { Some(_) => 1, None => 2, } } ``` 2017-02-20 07:45:37 +00:00
			`error: this argument is passed by value, but not consumed in the function body`
rustup improper_ctypes: `extern "C"` fns 2019-11-06 17:38:10 +00:00			`--> $DIR/needless_pass_by_value.rs:63:24`
Support non-moving usages at `match` This `match` is not moving the `String`: ```rust fn foo(x: Option<String>) -> i32 { match x { Some(_) => 1, None => 2, } } ``` With this change, it will be linted and suggested to add `` to deref it. ```rust fn foo(x: &Option<String>) -> i32 { match x { Some(_) => 1, None => 2, } } ``` 2017-02-20 07:45:37 +00:00			`\|`
Update *.stderr files 2018-12-27 15:57:55 +00:00			`LL \| fn test_destructure(x: Wrapper, y: Wrapper, z: Wrapper) {`
Fix ui tests 2017-07-21 08:40:23 +00:00			\| ^^^^^^^ help: consider taking a reference instead: `&Wrapper`
Support non-moving usages at `match` This `match` is not moving the `String`: ```rust fn foo(x: Option<String>) -> i32 { match x { Some(_) => 1, None => 2, } } ``` With this change, it will be linted and suggested to add `` to deref it. ```rust fn foo(x: &Option<String>) -> i32 { match x { Some(_) => 1, None => 2, } } ``` 2017-02-20 07:45:37 +00:00
Fix suggestion for `let <pat>` 2017-02-20 09:18:31 +00:00			`error: this argument is passed by value, but not consumed in the function body`
rustup improper_ctypes: `extern "C"` fns 2019-11-06 17:38:10 +00:00			`--> $DIR/needless_pass_by_value.rs:63:36`
Fix suggestion for `let <pat>` 2017-02-20 09:18:31 +00:00			`\|`
Update *.stderr files 2018-12-27 15:57:55 +00:00			`LL \| fn test_destructure(x: Wrapper, y: Wrapper, z: Wrapper) {`
Fix needless_pass_by_value This also accidentally improved the spans of the suggestions 2019-10-04 13:00:01 +00:00			\| ^^^^^^^ help: consider taking a reference instead: `&Wrapper`
Reduce false-positives for needless_pass_by_value lint Excluding a type whose reference also fulfills the trait bound. 2017-10-08 01:23:41 +00:00
			`error: this argument is passed by value, but not consumed in the function body`
rustup improper_ctypes: `extern "C"` fns 2019-11-06 17:38:10 +00:00			`--> $DIR/needless_pass_by_value.rs:79:49`
Update rustc output 2017-07-10 13:29:29 +00:00			`\|`
Update *.stderr files 2018-12-27 15:57:55 +00:00			`LL \| fn test_blanket_ref<T: Foo, S: Serialize>(_foo: T, _serializable: S) {}`
Reduce false-positives for needless_pass_by_value lint Excluding a type whose reference also fulfills the trait bound. 2017-10-08 01:23:41 +00:00			\| ^ help: consider taking a reference instead: `&T`
Fix suggestion for `let <pat>` 2017-02-20 09:18:31 +00:00
Duplicate ptr_arg's suggestion logic 2017-10-08 08:51:44 +00:00			`error: this argument is passed by value, but not consumed in the function body`
rustup improper_ctypes: `extern "C"` fns 2019-11-06 17:38:10 +00:00			`--> $DIR/needless_pass_by_value.rs:81:18`
Duplicate ptr_arg's suggestion logic 2017-10-08 08:51:44 +00:00			`\|`
Update *.stderr files 2018-12-27 15:57:55 +00:00			`LL \| fn issue_2114(s: String, t: String, u: Vec<i32>, v: Vec<i32>) {`
Duplicate ptr_arg's suggestion logic 2017-10-08 08:51:44 +00:00			\| ^^^^^^ help: consider taking a reference instead: `&String`

			`error: this argument is passed by value, but not consumed in the function body`
rustup improper_ctypes: `extern "C"` fns 2019-11-06 17:38:10 +00:00			`--> $DIR/needless_pass_by_value.rs:81:29`
Duplicate ptr_arg's suggestion logic 2017-10-08 08:51:44 +00:00			`\|`
Update *.stderr files 2018-12-27 15:57:55 +00:00			`LL \| fn issue_2114(s: String, t: String, u: Vec<i32>, v: Vec<i32>) {`
Duplicate ptr_arg's suggestion logic 2017-10-08 08:51:44 +00:00			`\| ^^^^^^`
Rustup to rust-lang/rust#65773 2019-10-26 19:53:42 +00:00			`\|`
Duplicate ptr_arg's suggestion logic 2017-10-08 08:51:44 +00:00			`help: consider changing the type to`
			`\|`
Update *.stderr files 2018-12-27 15:57:55 +00:00			`LL \| fn issue_2114(s: String, t: &str, u: Vec<i32>, v: Vec<i32>) {`
Duplicate ptr_arg's suggestion logic 2017-10-08 08:51:44 +00:00			`\| ^^^^`
			help: change `t.clone()` to
			`\|`
Update *.stderr files 2018-12-27 15:57:55 +00:00			`LL \| let _ = t.to_string();`
Duplicate ptr_arg's suggestion logic 2017-10-08 08:51:44 +00:00			`\| ^^^^^^^^^^^^^`

			`error: this argument is passed by value, but not consumed in the function body`
rustup improper_ctypes: `extern "C"` fns 2019-11-06 17:38:10 +00:00			`--> $DIR/needless_pass_by_value.rs:81:40`
Duplicate ptr_arg's suggestion logic 2017-10-08 08:51:44 +00:00			`\|`
Update *.stderr files 2018-12-27 15:57:55 +00:00			`LL \| fn issue_2114(s: String, t: String, u: Vec<i32>, v: Vec<i32>) {`
Duplicate ptr_arg's suggestion logic 2017-10-08 08:51:44 +00:00			\| ^^^^^^^^ help: consider taking a reference instead: `&Vec<i32>`

			`error: this argument is passed by value, but not consumed in the function body`
rustup improper_ctypes: `extern "C"` fns 2019-11-06 17:38:10 +00:00			`--> $DIR/needless_pass_by_value.rs:81:53`
Duplicate ptr_arg's suggestion logic 2017-10-08 08:51:44 +00:00			`\|`
Update *.stderr files 2018-12-27 15:57:55 +00:00			`LL \| fn issue_2114(s: String, t: String, u: Vec<i32>, v: Vec<i32>) {`
Duplicate ptr_arg's suggestion logic 2017-10-08 08:51:44 +00:00			`\| ^^^^^^^^`
Rustup to rust-lang/rust#65773 2019-10-26 19:53:42 +00:00			`\|`
Duplicate ptr_arg's suggestion logic 2017-10-08 08:51:44 +00:00			`help: consider changing the type to`
			`\|`
Update *.stderr files 2018-12-27 15:57:55 +00:00			`LL \| fn issue_2114(s: String, t: String, u: Vec<i32>, v: &[i32]) {`
Duplicate ptr_arg's suggestion logic 2017-10-08 08:51:44 +00:00			`\| ^^^^^^`
			help: change `v.clone()` to
			`\|`
Update *.stderr files 2018-12-27 15:57:55 +00:00			`LL \| let _ = v.to_owned();`
Duplicate ptr_arg's suggestion logic 2017-10-08 08:51:44 +00:00			`\| ^^^^^^^^^^^^`

Extend needless_pass_by_value to methods 2017-11-03 08:24:10 +00:00			`error: this argument is passed by value, but not consumed in the function body`
rustup improper_ctypes: `extern "C"` fns 2019-11-06 17:38:10 +00:00			`--> $DIR/needless_pass_by_value.rs:94:12`
Update *.stderr files 2018-12-27 15:57:55 +00:00			`\|`
			`LL \| s: String,`
			\| ^^^^^^ help: consider changing the type to: `&str`
Extend needless_pass_by_value to methods 2017-11-03 08:24:10 +00:00
			`error: this argument is passed by value, but not consumed in the function body`
rustup improper_ctypes: `extern "C"` fns 2019-11-06 17:38:10 +00:00			`--> $DIR/needless_pass_by_value.rs:95:12`
Update *.stderr files 2018-12-27 15:57:55 +00:00			`\|`
			`LL \| t: String,`
			\| ^^^^^^ help: consider taking a reference instead: `&String`
Extend needless_pass_by_value to methods 2017-11-03 08:24:10 +00:00
			`error: this argument is passed by value, but not consumed in the function body`
rustup improper_ctypes: `extern "C"` fns 2019-11-06 17:38:10 +00:00			`--> $DIR/needless_pass_by_value.rs:104:23`
Update *.stderr files 2018-12-27 15:57:55 +00:00			`\|`
			`LL \| fn baz(&self, _u: U, _s: Self) {}`
			\| ^ help: consider taking a reference instead: `&U`
Extend needless_pass_by_value to methods 2017-11-03 08:24:10 +00:00
Add test to take `Self` as an argument 2017-11-03 08:56:26 +00:00			`error: this argument is passed by value, but not consumed in the function body`
rustup improper_ctypes: `extern "C"` fns 2019-11-06 17:38:10 +00:00			`--> $DIR/needless_pass_by_value.rs:104:30`
Update *.stderr files 2018-12-27 15:57:55 +00:00			`\|`
			`LL \| fn baz(&self, _u: U, _s: Self) {}`
			\| ^^^^ help: consider taking a reference instead: `&Self`
Only suggest implementing Copy if it can actually be done 2018-01-18 13:27:47 +00:00
			`error: this argument is passed by value, but not consumed in the function body`
rustup improper_ctypes: `extern "C"` fns 2019-11-06 17:38:10 +00:00			`--> $DIR/needless_pass_by_value.rs:126:24`
Update *.stderr files 2018-12-27 15:57:55 +00:00			`\|`
			`LL \| fn bar_copy(x: u32, y: CopyWrapper) {`
			\| ^^^^^^^^^^^ help: consider taking a reference instead: `&CopyWrapper`
			`\|`
Only suggest implementing Copy if it can actually be done 2018-01-18 13:27:47 +00:00			`help: consider marking this type as Copy`
rustup improper_ctypes: `extern "C"` fns 2019-11-06 17:38:10 +00:00			`--> $DIR/needless_pass_by_value.rs:124:1`
Update *.stderr files 2018-12-27 15:57:55 +00:00			`\|`
			`LL \| struct CopyWrapper(u32);`
			`\| ^^^^^^^^^^^^^^^^^^^^^^^^`
Only suggest implementing Copy if it can actually be done 2018-01-18 13:27:47 +00:00
			`error: this argument is passed by value, but not consumed in the function body`
rustup improper_ctypes: `extern "C"` fns 2019-11-06 17:38:10 +00:00			`--> $DIR/needless_pass_by_value.rs:132:29`
Update *.stderr files 2018-12-27 15:57:55 +00:00			`\|`
			`LL \| fn test_destructure_copy(x: CopyWrapper, y: CopyWrapper, z: CopyWrapper) {`
			\| ^^^^^^^^^^^ help: consider taking a reference instead: `&CopyWrapper`
			`\|`
Only suggest implementing Copy if it can actually be done 2018-01-18 13:27:47 +00:00			`help: consider marking this type as Copy`
rustup improper_ctypes: `extern "C"` fns 2019-11-06 17:38:10 +00:00			`--> $DIR/needless_pass_by_value.rs:124:1`
Update *.stderr files 2018-12-27 15:57:55 +00:00			`\|`
			`LL \| struct CopyWrapper(u32);`
			`\| ^^^^^^^^^^^^^^^^^^^^^^^^`
Only suggest implementing Copy if it can actually be done 2018-01-18 13:27:47 +00:00
			`error: this argument is passed by value, but not consumed in the function body`
rustup improper_ctypes: `extern "C"` fns 2019-11-06 17:38:10 +00:00			`--> $DIR/needless_pass_by_value.rs:132:45`
Update *.stderr files 2018-12-27 15:57:55 +00:00			`\|`
			`LL \| fn test_destructure_copy(x: CopyWrapper, y: CopyWrapper, z: CopyWrapper) {`
Fix needless_pass_by_value This also accidentally improved the spans of the suggestions 2019-10-04 13:00:01 +00:00			\| ^^^^^^^^^^^ help: consider taking a reference instead: `&CopyWrapper`
Update *.stderr files 2018-12-27 15:57:55 +00:00			`\|`
Only suggest implementing Copy if it can actually be done 2018-01-18 13:27:47 +00:00			`help: consider marking this type as Copy`
rustup improper_ctypes: `extern "C"` fns 2019-11-06 17:38:10 +00:00			`--> $DIR/needless_pass_by_value.rs:124:1`
Update *.stderr files 2018-12-27 15:57:55 +00:00			`\|`
			`LL \| struct CopyWrapper(u32);`
			`\| ^^^^^^^^^^^^^^^^^^^^^^^^`

			`error: this argument is passed by value, but not consumed in the function body`
rustup improper_ctypes: `extern "C"` fns 2019-11-06 17:38:10 +00:00			`--> $DIR/needless_pass_by_value.rs:132:61`
Update *.stderr files 2018-12-27 15:57:55 +00:00			`\|`
			`LL \| fn test_destructure_copy(x: CopyWrapper, y: CopyWrapper, z: CopyWrapper) {`
Fix needless_pass_by_value This also accidentally improved the spans of the suggestions 2019-10-04 13:00:01 +00:00			\| ^^^^^^^^^^^ help: consider taking a reference instead: `&CopyWrapper`
Update *.stderr files 2018-12-27 15:57:55 +00:00			`\|`
Only suggest implementing Copy if it can actually be done 2018-01-18 13:27:47 +00:00			`help: consider marking this type as Copy`
rustup improper_ctypes: `extern "C"` fns 2019-11-06 17:38:10 +00:00			`--> $DIR/needless_pass_by_value.rs:124:1`
Update *.stderr files 2018-12-27 15:57:55 +00:00			`\|`
			`LL \| struct CopyWrapper(u32);`
			`\| ^^^^^^^^^^^^^^^^^^^^^^^^`
Add test to take `Self` as an argument 2017-11-03 08:56:26 +00:00
Fix 'impossible case reached' ICE 2018-10-01 20:33:20 +00:00			`error: this argument is passed by value, but not consumed in the function body`
rustup improper_ctypes: `extern "C"` fns 2019-11-06 17:38:10 +00:00			`--> $DIR/needless_pass_by_value.rs:144:40`
Update *.stderr files 2018-12-27 15:57:55 +00:00			`\|`
			`LL \| fn some_fun<'b, S: Bar<'b, ()>>(_item: S) {}`
			\| ^ help: consider taking a reference instead: `&S`
Fix 'impossible case reached' ICE 2018-10-01 20:33:20 +00:00
			`error: this argument is passed by value, but not consumed in the function body`
rustup improper_ctypes: `extern "C"` fns 2019-11-06 17:38:10 +00:00			`--> $DIR/needless_pass_by_value.rs:149:20`
Update *.stderr files 2018-12-27 15:57:55 +00:00			`\|`
			`LL \| fn more_fun(_item: impl Club<'static, i32>) {}`
			\| ^^^^^^^^^^^^^^^^^^^^^^^ help: consider taking a reference instead: `&impl Club<'static, i32>`
Fix 'impossible case reached' ICE 2018-10-01 20:33:20 +00:00
			`error: aborting due to 22 previous errors`
Update changed ui tests 2018-01-16 16:06:27 +00:00