2018-09-15 07:21:58 +00:00
|
|
|
use crate::rustc::lint::{LateContext, LateLintPass, LintArray, LintPass};
|
|
|
|
use crate::rustc::{declare_tool_lint, lint_array};
|
|
|
|
use crate::rustc::ty::{self, Ty};
|
|
|
|
use crate::rustc::ty::subst::Subst;
|
|
|
|
use crate::rustc::hir::*;
|
2018-05-30 08:15:50 +00:00
|
|
|
use crate::utils::span_lint;
|
2015-09-29 11:11:19 +00:00
|
|
|
|
2016-08-06 07:55:04 +00:00
|
|
|
/// **What it does:** Detects giving a mutable reference to a function that only
|
|
|
|
/// requires an immutable reference.
|
2015-12-11 00:22:27 +00:00
|
|
|
///
|
2016-08-06 07:55:04 +00:00
|
|
|
/// **Why is this bad?** The immutable reference rules out all other references
|
|
|
|
/// to the value. Also the code misleads about the intent of the call site.
|
2015-12-11 00:22:27 +00:00
|
|
|
///
|
2016-08-06 07:55:04 +00:00
|
|
|
/// **Known problems:** None.
|
2015-12-11 00:22:27 +00:00
|
|
|
///
|
2016-08-06 07:55:04 +00:00
|
|
|
/// **Example:**
|
2016-07-15 22:25:44 +00:00
|
|
|
/// ```rust
|
|
|
|
/// my_vec.push(&mut value)
|
|
|
|
/// ```
|
2018-03-28 13:24:26 +00:00
|
|
|
declare_clippy_lint! {
|
2015-09-29 11:11:19 +00:00
|
|
|
pub UNNECESSARY_MUT_PASSED,
|
2018-03-28 13:24:26 +00:00
|
|
|
style,
|
2016-08-06 08:18:36 +00:00
|
|
|
"an argument passed as a mutable reference although the callee only demands an \
|
2015-09-29 11:11:19 +00:00
|
|
|
immutable reference"
|
|
|
|
}
|
|
|
|
|
|
|
|
|
2017-08-09 07:30:56 +00:00
|
|
|
#[derive(Copy, Clone)]
|
2015-09-29 11:11:19 +00:00
|
|
|
pub struct UnnecessaryMutPassed;
|
|
|
|
|
|
|
|
impl LintPass for UnnecessaryMutPassed {
|
|
|
|
fn get_lints(&self) -> LintArray {
|
|
|
|
lint_array!(UNNECESSARY_MUT_PASSED)
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2016-12-07 12:13:40 +00:00
|
|
|
impl<'a, 'tcx> LateLintPass<'a, 'tcx> for UnnecessaryMutPassed {
|
|
|
|
fn check_expr(&mut self, cx: &LateContext<'a, 'tcx>, e: &'tcx Expr) {
|
2015-09-29 16:43:38 +00:00
|
|
|
match e.node {
|
2018-07-12 07:30:57 +00:00
|
|
|
ExprKind::Call(ref fn_expr, ref arguments) => if let ExprKind::Path(ref path) = fn_expr.node {
|
2017-09-05 09:33:04 +00:00
|
|
|
check_arguments(
|
|
|
|
cx,
|
|
|
|
arguments,
|
|
|
|
cx.tables.expr_ty(fn_expr),
|
|
|
|
&print::to_string(print::NO_ANN, |s| s.print_qpath(path, false)),
|
|
|
|
);
|
2016-12-20 17:21:30 +00:00
|
|
|
},
|
2018-07-12 07:30:57 +00:00
|
|
|
ExprKind::MethodCall(ref path, _, ref arguments) => {
|
2017-08-15 09:10:49 +00:00
|
|
|
let def_id = cx.tables.type_dependent_defs()[e.hir_id].def_id();
|
|
|
|
let substs = cx.tables.node_substs(e.hir_id);
|
2017-06-04 21:28:01 +00:00
|
|
|
let method_type = cx.tcx.type_of(def_id).subst(cx.tcx, substs);
|
2018-06-28 13:46:58 +00:00
|
|
|
check_arguments(cx, arguments, method_type, &path.ident.as_str())
|
2016-12-20 17:21:30 +00:00
|
|
|
},
|
2016-04-14 18:14:03 +00:00
|
|
|
_ => (),
|
2015-09-29 11:11:19 +00:00
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
2015-09-30 11:08:29 +00:00
|
|
|
|
2017-06-29 13:38:25 +00:00
|
|
|
fn check_arguments<'a, 'tcx>(cx: &LateContext<'a, 'tcx>, arguments: &[Expr], type_definition: Ty<'tcx>, name: &str) {
|
2016-03-10 17:13:49 +00:00
|
|
|
match type_definition.sty {
|
2018-08-22 21:34:52 +00:00
|
|
|
ty::FnDef(..) | ty::FnPtr(_) => {
|
2017-06-29 13:38:25 +00:00
|
|
|
let parameters = type_definition.fn_sig(cx.tcx).skip_binder().inputs();
|
2016-03-10 17:13:49 +00:00
|
|
|
for (argument, parameter) in arguments.iter().zip(parameters.iter()) {
|
|
|
|
match parameter.sty {
|
2018-08-22 21:34:52 +00:00
|
|
|
ty::Ref(
|
2017-09-05 09:33:04 +00:00
|
|
|
_,
|
2018-05-11 06:37:48 +00:00
|
|
|
_,
|
2018-05-11 07:50:29 +00:00
|
|
|
MutImmutable,
|
2017-09-05 09:33:04 +00:00
|
|
|
) |
|
2018-08-22 21:34:52 +00:00
|
|
|
ty::RawPtr(ty::TypeAndMut {
|
2017-09-05 09:33:04 +00:00
|
|
|
mutbl: MutImmutable,
|
|
|
|
..
|
2018-07-12 07:30:57 +00:00
|
|
|
}) => if let ExprKind::AddrOf(MutMutable, _) = argument.node {
|
2017-09-05 09:33:04 +00:00
|
|
|
span_lint(
|
|
|
|
cx,
|
|
|
|
UNNECESSARY_MUT_PASSED,
|
|
|
|
argument.span,
|
|
|
|
&format!("The function/method `{}` doesn't need a mutable reference", name),
|
|
|
|
);
|
2016-12-20 17:21:30 +00:00
|
|
|
},
|
2016-04-14 18:14:03 +00:00
|
|
|
_ => (),
|
2015-11-17 04:39:42 +00:00
|
|
|
}
|
2015-09-30 11:08:29 +00:00
|
|
|
}
|
2016-12-20 17:21:30 +00:00
|
|
|
},
|
2016-03-10 17:13:49 +00:00
|
|
|
_ => (),
|
2015-09-30 11:08:29 +00:00
|
|
|
}
|
|
|
|
}
|