2016-01-24 09:16:56 +00:00
|
|
|
//! lint when items are used after statements
|
|
|
|
|
2018-07-19 07:24:19 +00:00
|
|
|
use matches::matches;
|
2018-09-15 07:21:58 +00:00
|
|
|
use crate::rustc::lint::{EarlyContext, EarlyLintPass, LintArray, LintPass};
|
|
|
|
use crate::rustc::{declare_tool_lint, lint_array};
|
|
|
|
use crate::syntax::ast::*;
|
2018-05-30 08:15:50 +00:00
|
|
|
use crate::utils::{in_macro, span_lint};
|
2016-01-24 09:16:56 +00:00
|
|
|
|
2016-08-06 07:55:04 +00:00
|
|
|
/// **What it does:** Checks for items declared after some statement in a block.
|
2016-01-24 09:16:56 +00:00
|
|
|
///
|
2016-08-06 07:55:04 +00:00
|
|
|
/// **Why is this bad?** Items live for the entire scope they are declared
|
|
|
|
/// in. But statements are processed in order. This might cause confusion as
|
|
|
|
/// it's hard to figure out which item is meant in a statement.
|
2016-01-24 09:16:56 +00:00
|
|
|
///
|
2016-08-06 07:55:04 +00:00
|
|
|
/// **Known problems:** None.
|
2016-01-24 09:16:56 +00:00
|
|
|
///
|
|
|
|
/// **Example:**
|
|
|
|
/// ```rust
|
|
|
|
/// fn foo() {
|
|
|
|
/// println!("cake");
|
|
|
|
/// }
|
2016-07-15 22:25:44 +00:00
|
|
|
///
|
2016-01-24 09:16:56 +00:00
|
|
|
/// fn main() {
|
|
|
|
/// foo(); // prints "foo"
|
|
|
|
/// fn foo() {
|
|
|
|
/// println!("foo");
|
|
|
|
/// }
|
|
|
|
/// foo(); // prints "foo"
|
|
|
|
/// }
|
2016-01-29 21:42:19 +00:00
|
|
|
/// ```
|
2018-03-28 13:24:26 +00:00
|
|
|
declare_clippy_lint! {
|
2016-02-05 23:13:29 +00:00
|
|
|
pub ITEMS_AFTER_STATEMENTS,
|
2018-03-28 13:24:26 +00:00
|
|
|
pedantic,
|
2016-08-06 08:18:36 +00:00
|
|
|
"blocks where an item comes after a statement"
|
2016-02-05 23:13:29 +00:00
|
|
|
}
|
2016-01-24 09:16:56 +00:00
|
|
|
|
2016-03-19 14:06:56 +00:00
|
|
|
pub struct ItemsAfterStatements;
|
2016-01-24 09:16:56 +00:00
|
|
|
|
2016-03-19 14:06:56 +00:00
|
|
|
impl LintPass for ItemsAfterStatements {
|
2016-01-24 09:16:56 +00:00
|
|
|
fn get_lints(&self) -> LintArray {
|
|
|
|
lint_array!(ITEMS_AFTER_STATEMENTS)
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2016-03-19 14:06:56 +00:00
|
|
|
impl EarlyLintPass for ItemsAfterStatements {
|
2018-07-23 11:01:12 +00:00
|
|
|
fn check_block(&mut self, cx: &EarlyContext<'_>, item: &Block) {
|
2017-03-31 22:14:04 +00:00
|
|
|
if in_macro(item.span) {
|
2016-01-24 09:16:56 +00:00
|
|
|
return;
|
|
|
|
}
|
2016-06-28 13:54:23 +00:00
|
|
|
|
2016-01-24 09:16:56 +00:00
|
|
|
// skip initial items
|
2017-09-05 09:33:04 +00:00
|
|
|
let stmts = item.stmts
|
|
|
|
.iter()
|
|
|
|
.map(|stmt| &stmt.node)
|
|
|
|
.skip_while(|s| matches!(**s, StmtKind::Item(..)));
|
2016-06-28 13:54:23 +00:00
|
|
|
|
2016-01-24 09:16:56 +00:00
|
|
|
// lint on all further items
|
|
|
|
for stmt in stmts {
|
2016-06-28 13:54:23 +00:00
|
|
|
if let StmtKind::Item(ref it) = *stmt {
|
2017-03-31 22:14:04 +00:00
|
|
|
if in_macro(it.span) {
|
2016-06-28 13:54:23 +00:00
|
|
|
return;
|
2016-01-24 09:16:56 +00:00
|
|
|
}
|
2017-03-13 10:09:56 +00:00
|
|
|
if let ItemKind::MacroDef(..) = it.node {
|
|
|
|
// do not lint `macro_rules`, but continue processing further statements
|
|
|
|
continue;
|
|
|
|
}
|
2017-08-09 07:30:56 +00:00
|
|
|
span_lint(
|
|
|
|
cx,
|
|
|
|
ITEMS_AFTER_STATEMENTS,
|
|
|
|
it.span,
|
|
|
|
"adding items after statements is confusing, since items exist from the \
|
2017-09-05 09:33:04 +00:00
|
|
|
start of the scope",
|
2017-08-09 07:30:56 +00:00
|
|
|
);
|
2016-01-24 09:16:56 +00:00
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|