2018-09-15 07:21:58 +00:00
|
|
|
use crate::syntax::ast::*;
|
2018-09-14 10:38:57 +00:00
|
|
|
use crate::rustc::lint::{EarlyContext, EarlyLintPass, LintArray, LintPass};
|
2018-09-15 07:21:58 +00:00
|
|
|
use crate::rustc::{declare_tool_lint, lint_array};
|
2018-09-22 15:20:34 +00:00
|
|
|
use crate::utils::{in_macro, span_lint};
|
|
|
|
|
2016-12-28 18:54:23 +00:00
|
|
|
|
|
|
|
/// **What it does:** Checks for unnecessary double parentheses.
|
|
|
|
///
|
|
|
|
/// **Why is this bad?** This makes code harder to read and might indicate a
|
|
|
|
/// mistake.
|
|
|
|
///
|
|
|
|
/// **Known problems:** None.
|
|
|
|
///
|
|
|
|
/// **Example:**
|
|
|
|
/// ```rust
|
|
|
|
/// ((0))
|
|
|
|
/// foo((0))
|
|
|
|
/// ((1, 2))
|
|
|
|
/// ```
|
2018-03-28 13:24:26 +00:00
|
|
|
declare_clippy_lint! {
|
|
|
|
pub DOUBLE_PARENS,
|
|
|
|
complexity,
|
2016-12-28 18:54:23 +00:00
|
|
|
"Warn on unnecessary double parentheses"
|
|
|
|
}
|
|
|
|
|
|
|
|
#[derive(Copy, Clone)]
|
|
|
|
pub struct DoubleParens;
|
|
|
|
|
|
|
|
impl LintPass for DoubleParens {
|
|
|
|
fn get_lints(&self) -> LintArray {
|
|
|
|
lint_array!(DOUBLE_PARENS)
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
impl EarlyLintPass for DoubleParens {
|
2018-07-23 11:01:12 +00:00
|
|
|
fn check_expr(&mut self, cx: &EarlyContext<'_>, expr: &Expr) {
|
2018-09-22 15:20:34 +00:00
|
|
|
if in_macro(expr.span) {
|
|
|
|
return;
|
|
|
|
}
|
|
|
|
|
2016-12-28 20:03:49 +00:00
|
|
|
match expr.node {
|
2017-09-05 09:33:04 +00:00
|
|
|
ExprKind::Paren(ref in_paren) => match in_paren.node {
|
|
|
|
ExprKind::Paren(_) | ExprKind::Tup(_) => {
|
2018-09-14 10:38:57 +00:00
|
|
|
span_lint(cx, DOUBLE_PARENS, expr.span, "Consider removing unnecessary double parentheses");
|
2017-09-05 09:33:04 +00:00
|
|
|
},
|
|
|
|
_ => {},
|
2016-12-28 20:03:49 +00:00
|
|
|
},
|
2017-09-05 09:33:04 +00:00
|
|
|
ExprKind::Call(_, ref params) => if params.len() == 1 {
|
|
|
|
let param = ¶ms[0];
|
|
|
|
if let ExprKind::Paren(_) = param.node {
|
2018-09-14 10:38:57 +00:00
|
|
|
span_lint(cx, DOUBLE_PARENS, param.span, "Consider removing unnecessary double parentheses");
|
2016-12-28 20:03:49 +00:00
|
|
|
}
|
|
|
|
},
|
2017-09-05 09:33:04 +00:00
|
|
|
ExprKind::MethodCall(_, ref params) => if params.len() == 2 {
|
|
|
|
let param = ¶ms[1];
|
|
|
|
if let ExprKind::Paren(_) = param.node {
|
2018-09-14 10:38:57 +00:00
|
|
|
span_lint(cx, DOUBLE_PARENS, param.span, "Consider removing unnecessary double parentheses");
|
2016-12-28 20:03:49 +00:00
|
|
|
}
|
|
|
|
},
|
|
|
|
_ => {},
|
|
|
|
}
|
2016-12-28 18:54:23 +00:00
|
|
|
}
|
|
|
|
}
|