rust-clippy/clippy_lints/src/unsafe_removed_from_name.rs

93 lines
2.8 KiB
Rust
Raw Normal View History

2018-10-06 16:18:06 +00:00
// Copyright 2014-2018 The Rust Project Developers. See the COPYRIGHT
// file at the top-level directory of this distribution.
//
// Licensed under the Apache License, Version 2.0 <LICENSE-APACHE or
// http://www.apache.org/licenses/LICENSE-2.0> or the MIT license
// <LICENSE-MIT or http://opensource.org/licenses/MIT>, at your
// option. This file may not be copied, modified, or distributed
// except according to those terms.
use crate::rustc::lint::{EarlyContext, EarlyLintPass, LintArray, LintPass};
use crate::rustc::{declare_tool_lint, lint_array};
use crate::syntax::ast::*;
use crate::syntax::source_map::Span;
use crate::syntax::symbol::LocalInternedString;
2018-05-30 08:15:50 +00:00
use crate::utils::span_lint;
/// **What it does:** Checks for imports that remove "unsafe" from an item's
/// name.
///
/// **Why is this bad?** Renaming makes it less clear which traits and
/// structures are unsafe.
///
/// **Known problems:** None.
///
/// **Example:**
/// ```rust,ignore
/// use std::cell::{UnsafeCell as TotallySafeCell};
///
/// extern crate crossbeam;
/// use crossbeam::{spawn_unsafe as spawn};
/// ```
2018-03-28 13:24:26 +00:00
declare_clippy_lint! {
pub UNSAFE_REMOVED_FROM_NAME,
2018-03-28 13:24:26 +00:00
style,
"`unsafe` removed from API names on import"
}
pub struct UnsafeNameRemoval;
impl LintPass for UnsafeNameRemoval {
fn get_lints(&self) -> LintArray {
lint_array!(UNSAFE_REMOVED_FROM_NAME)
}
}
impl EarlyLintPass for UnsafeNameRemoval {
2018-07-23 11:01:12 +00:00
fn check_item(&mut self, cx: &EarlyContext<'_>, item: &Item) {
if let ItemKind::Use(ref use_tree) = item.node {
check_use_tree(use_tree, cx, item.span);
}
}
}
2018-07-23 11:01:12 +00:00
fn check_use_tree(use_tree: &UseTree, cx: &EarlyContext<'_>, span: Span) {
match use_tree.kind {
2018-06-18 07:55:59 +00:00
UseTreeKind::Simple(Some(new_name), ..) => {
let old_name = use_tree
.prefix
.segments
.last()
.expect("use paths cannot be empty")
.ident;
unsafe_to_safe_check(old_name, new_name, cx, span);
2018-11-27 20:14:15 +00:00
},
UseTreeKind::Simple(None, ..) | UseTreeKind::Glob => {},
UseTreeKind::Nested(ref nested_use_tree) => {
for &(ref use_tree, _) in nested_use_tree {
check_use_tree(use_tree, cx, span);
}
2018-11-27 20:14:15 +00:00
},
}
}
2018-07-23 11:01:12 +00:00
fn unsafe_to_safe_check(old_name: Ident, new_name: Ident, cx: &EarlyContext<'_>, span: Span) {
let old_str = old_name.name.as_str();
let new_str = new_name.name.as_str();
if contains_unsafe(&old_str) && !contains_unsafe(&new_str) {
2017-08-09 07:30:56 +00:00
span_lint(
cx,
UNSAFE_REMOVED_FROM_NAME,
span,
2018-11-27 20:14:15 +00:00
&format!(
"removed \"unsafe\" from the name of `{}` in use as `{}`",
old_str, new_str
),
2017-08-09 07:30:56 +00:00
);
}
}
fn contains_unsafe(name: &LocalInternedString) -> bool {
name.contains("Unsafe") || name.contains("unsafe")
}