2018-10-06 16:18:06 +00:00
|
|
|
// Copyright 2014-2018 The Rust Project Developers. See the COPYRIGHT
|
|
|
|
// file at the top-level directory of this distribution.
|
|
|
|
//
|
|
|
|
// Licensed under the Apache License, Version 2.0 <LICENSE-APACHE or
|
|
|
|
// http://www.apache.org/licenses/LICENSE-2.0> or the MIT license
|
|
|
|
// <LICENSE-MIT or http://opensource.org/licenses/MIT>, at your
|
|
|
|
// option. This file may not be copied, modified, or distributed
|
|
|
|
// except according to those terms.
|
|
|
|
|
2018-09-15 07:21:58 +00:00
|
|
|
use crate::rustc::lint::{EarlyContext, EarlyLintPass, LintArray, LintPass};
|
|
|
|
use crate::rustc::{declare_tool_lint, lint_array};
|
2018-11-20 13:06:29 +00:00
|
|
|
use crate::rustc_errors::Applicability;
|
2018-09-15 07:21:58 +00:00
|
|
|
use crate::syntax::ast::*;
|
2018-11-27 20:14:15 +00:00
|
|
|
use crate::utils::span_lint_and_sugg;
|
2018-02-10 20:13:17 +00:00
|
|
|
|
2018-02-11 09:50:19 +00:00
|
|
|
/// **What it does:** Checks for fields in struct literals where shorthands
|
|
|
|
/// could be used.
|
2018-05-29 09:58:58 +00:00
|
|
|
///
|
2018-02-10 20:13:17 +00:00
|
|
|
/// **Why is this bad?** If the field and variable names are the same,
|
|
|
|
/// the field name is redundant.
|
2018-05-29 09:58:58 +00:00
|
|
|
///
|
2018-02-10 20:13:17 +00:00
|
|
|
/// **Known problems:** None.
|
2018-05-29 09:58:58 +00:00
|
|
|
///
|
2018-02-10 20:13:17 +00:00
|
|
|
/// **Example:**
|
|
|
|
/// ```rust
|
|
|
|
/// let bar: u8 = 123;
|
2018-05-29 09:58:58 +00:00
|
|
|
///
|
2018-02-10 20:13:17 +00:00
|
|
|
/// struct Foo {
|
|
|
|
/// bar: u8,
|
|
|
|
/// }
|
2018-05-29 09:58:58 +00:00
|
|
|
///
|
2018-02-10 20:13:17 +00:00
|
|
|
/// let foo = Foo{ bar: bar }
|
|
|
|
/// ```
|
2018-08-11 22:16:03 +00:00
|
|
|
/// the last line can be simplified to
|
|
|
|
/// ```rust
|
|
|
|
/// let foo = Foo{ bar }
|
|
|
|
/// ```
|
2018-03-28 13:24:26 +00:00
|
|
|
declare_clippy_lint! {
|
2018-02-10 20:13:17 +00:00
|
|
|
pub REDUNDANT_FIELD_NAMES,
|
2018-03-28 13:24:26 +00:00
|
|
|
style,
|
2018-02-11 09:50:19 +00:00
|
|
|
"checks for fields in struct literals where shorthands could be used"
|
2018-02-10 20:13:17 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
pub struct RedundantFieldNames;
|
|
|
|
|
|
|
|
impl LintPass for RedundantFieldNames {
|
|
|
|
fn get_lints(&self) -> LintArray {
|
|
|
|
lint_array!(REDUNDANT_FIELD_NAMES)
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2018-08-06 06:20:50 +00:00
|
|
|
impl EarlyLintPass for RedundantFieldNames {
|
|
|
|
fn check_expr(&mut self, cx: &EarlyContext<'_>, expr: &Expr) {
|
2018-07-12 07:30:57 +00:00
|
|
|
if let ExprKind::Struct(_, ref fields, _) = expr.node {
|
2018-02-10 20:13:17 +00:00
|
|
|
for field in fields {
|
2018-08-06 06:20:50 +00:00
|
|
|
if field.is_shorthand {
|
|
|
|
continue;
|
|
|
|
}
|
|
|
|
if let ExprKind::Path(None, path) = &field.expr.node {
|
2018-12-11 14:33:23 +00:00
|
|
|
if path.segments.len() == 1
|
|
|
|
&& path.segments[0].ident == field.ident
|
|
|
|
&& path.segments[0].args.is_none()
|
|
|
|
{
|
2018-11-20 13:06:29 +00:00
|
|
|
span_lint_and_sugg(
|
2018-08-06 06:20:50 +00:00
|
|
|
cx,
|
|
|
|
REDUNDANT_FIELD_NAMES,
|
|
|
|
field.span,
|
|
|
|
"redundant field names in struct initialization",
|
|
|
|
"replace it with",
|
2018-11-20 13:06:29 +00:00
|
|
|
field.ident.to_string(),
|
2018-11-27 14:13:57 +00:00
|
|
|
Applicability::MachineApplicable,
|
2018-08-06 06:20:50 +00:00
|
|
|
);
|
|
|
|
}
|
2018-02-10 20:13:17 +00:00
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|