2016-10-02 20:48:52 +00:00
|
|
|
use rustc::lint::*;
|
|
|
|
use rustc::hir::*;
|
2016-10-02 21:38:31 +00:00
|
|
|
use utils::{paths, method_chain_args, span_help_and_lint, match_type, snippet};
|
2016-10-02 20:48:52 +00:00
|
|
|
|
|
|
|
/// **What it does:*** Checks for unnecessary `ok()` in if let.
|
|
|
|
///
|
2017-08-09 07:30:56 +00:00
|
|
|
/// **Why is this bad?** Calling `ok()` in if let is unnecessary, instead match
|
|
|
|
/// on `Ok(pat)`
|
2016-10-02 20:48:52 +00:00
|
|
|
///
|
|
|
|
/// **Known problems:** None.
|
|
|
|
///
|
|
|
|
/// **Example:**
|
2016-10-31 22:55:22 +00:00
|
|
|
/// ```rust
|
2016-10-02 20:48:52 +00:00
|
|
|
/// for result in iter {
|
|
|
|
/// if let Some(bench) = try!(result).parse().ok() {
|
|
|
|
/// vec.push(bench)
|
|
|
|
/// }
|
|
|
|
/// }
|
2016-12-20 17:21:30 +00:00
|
|
|
/// ```
|
2016-10-31 22:55:22 +00:00
|
|
|
/// Could be written:
|
|
|
|
///
|
|
|
|
/// ```rust
|
|
|
|
/// for result in iter {
|
|
|
|
/// if let Ok(bench) = try!(result).parse() {
|
|
|
|
/// vec.push(bench)
|
|
|
|
/// }
|
|
|
|
/// }
|
2016-10-02 20:48:52 +00:00
|
|
|
/// ```
|
|
|
|
declare_lint! {
|
|
|
|
pub IF_LET_SOME_RESULT,
|
|
|
|
Warn,
|
2016-10-02 21:15:24 +00:00
|
|
|
"usage of `ok()` in `if let Some(pat)` statements is unnecessary, match on `Ok(pat)` instead"
|
2016-10-02 20:48:52 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
#[derive(Copy, Clone)]
|
2016-10-06 15:50:11 +00:00
|
|
|
pub struct Pass;
|
2016-10-02 20:48:52 +00:00
|
|
|
|
2016-10-06 15:50:11 +00:00
|
|
|
impl LintPass for Pass {
|
2016-10-02 20:48:52 +00:00
|
|
|
fn get_lints(&self) -> LintArray {
|
|
|
|
lint_array!(IF_LET_SOME_RESULT)
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2016-12-07 12:13:40 +00:00
|
|
|
impl<'a, 'tcx> LateLintPass<'a, 'tcx> for Pass {
|
|
|
|
fn check_expr(&mut self, cx: &LateContext<'a, 'tcx>, expr: &'tcx Expr) {
|
2016-10-02 20:48:52 +00:00
|
|
|
if_let_chain! {[ //begin checking variables
|
|
|
|
let ExprMatch(ref op, ref body, ref source) = expr.node, //test if expr is a match
|
2016-10-02 20:53:10 +00:00
|
|
|
let MatchSource::IfLetDesugar { .. } = *source, //test if it is an If Let
|
2016-10-02 20:48:52 +00:00
|
|
|
let ExprMethodCall(_, _, ref result_types) = op.node, //check is expr.ok() has type Result<T,E>.ok()
|
2016-12-01 21:31:56 +00:00
|
|
|
let PatKind::TupleStruct(QPath::Resolved(_, ref x), ref y, _) = body[0].pats[0].node, //get operation
|
2016-10-29 16:56:12 +00:00
|
|
|
method_chain_args(op, &["ok"]).is_some() //test to see if using ok() methoduse std::marker::Sized;
|
2016-10-02 20:48:52 +00:00
|
|
|
|
|
|
|
], {
|
2017-01-13 16:04:56 +00:00
|
|
|
let is_result_type = match_type(cx, cx.tables.expr_ty(&result_types[0]), &paths::RESULT);
|
2016-10-02 21:38:31 +00:00
|
|
|
let some_expr_string = snippet(cx, y[0].span, "");
|
2017-01-04 04:40:42 +00:00
|
|
|
if print::to_string(print::NO_ANN, |s| s.print_path(x, false)) == "Some" && is_result_type {
|
2016-10-02 20:48:52 +00:00
|
|
|
span_help_and_lint(cx, IF_LET_SOME_RESULT, expr.span,
|
|
|
|
"Matching on `Some` with `ok()` is redundant",
|
2016-10-29 16:56:12 +00:00
|
|
|
&format!("Consider matching on `Ok({})` and removing the call to `ok` instead", some_expr_string));
|
2016-10-02 20:48:52 +00:00
|
|
|
}
|
|
|
|
}}
|
|
|
|
}
|
|
|
|
}
|