rust-clippy/tests/ui/block_in_if_condition.rs

105 lines
1.8 KiB
Rust
Raw Normal View History

2018-07-28 15:34:52 +00:00
#![warn(clippy::block_in_if_condition_expr)]
#![warn(clippy::block_in_if_condition_stmt)]
#![allow(unused, clippy::let_and_return)]
#![warn(clippy::nonminimal_bool)]
2015-11-20 05:22:52 +00:00
macro_rules! blocky {
2018-12-09 22:26:16 +00:00
() => {{
true
}};
}
2016-01-31 22:25:10 +00:00
macro_rules! blocky_too {
() => {{
let r = true;
r
2018-12-09 22:26:16 +00:00
}};
2016-01-31 22:25:10 +00:00
}
fn macro_if() {
2018-12-09 22:26:16 +00:00
if blocky!() {}
2016-12-21 11:30:41 +00:00
2018-12-09 22:26:16 +00:00
if blocky_too!() {}
}
2016-01-31 22:25:10 +00:00
2015-11-20 05:22:52 +00:00
fn condition_has_block() -> i32 {
2017-02-08 13:58:07 +00:00
if {
2015-11-20 05:22:52 +00:00
let x = 3;
x == 3
} {
6
} else {
10
}
}
fn condition_has_block_with_single_expression() -> i32 {
2017-02-08 13:58:07 +00:00
if { true } {
2015-11-20 05:22:52 +00:00
6
} else {
10
}
}
2018-12-09 22:26:16 +00:00
fn predicate<F: FnOnce(T) -> bool, T>(pfn: F, val: T) -> bool {
2015-11-20 05:22:52 +00:00
pfn(val)
}
fn pred_test() {
let v = 3;
let sky = "blue";
// this is a sneaky case, where the block isn't directly in the condition, but is actually
// inside a closure that the condition is using. same principle applies. add some extra
// expressions to make sure linter isn't confused by them.
2018-12-09 22:26:16 +00:00
if v == 3
&& sky == "blue"
&& predicate(
|x| {
let target = 3;
x == target
},
v,
)
{}
if predicate(
|x| {
let target = 3;
x == target
},
v,
) {}
2015-11-20 05:22:52 +00:00
}
fn condition_is_normal() -> i32 {
let x = 3;
2017-02-08 13:58:07 +00:00
if true && x == 3 {
2015-11-20 05:22:52 +00:00
6
} else {
10
}
}
fn closure_without_block() {
2018-12-09 22:26:16 +00:00
if predicate(|x| x == 3, 6) {}
2015-11-20 05:22:52 +00:00
}
fn condition_is_unsafe_block() {
let a: i32 = 1;
// this should not warn because the condition is an unsafe block
if unsafe { 1u32 == std::mem::transmute(a) } {
println!("1u32 == a");
}
}
2018-12-09 22:26:16 +00:00
fn main() {}
2018-12-06 10:07:10 +00:00
fn macro_in_closure() {
let option = Some(true);
if option.unwrap_or_else(|| unimplemented!()) {
unimplemented!()
}
}