rust-clippy/tests/ui/entry_unfixable.rs

74 lines
1.6 KiB
Rust
Raw Normal View History

2018-07-28 15:34:52 +00:00
#![allow(unused, clippy::needless_pass_by_value)]
#![warn(clippy::map_entry)]
2015-12-21 23:35:56 +00:00
use std::collections::{BTreeMap, HashMap};
2015-12-21 23:35:56 +00:00
use std::hash::Hash;
fn foo() {}
2015-12-21 23:35:56 +00:00
fn insert_if_absent2<K: Eq + Hash, V>(m: &mut HashMap<K, V>, k: K, v: V) {
2018-12-09 22:26:16 +00:00
if !m.contains_key(&k) {
m.insert(k, v)
} else {
None
};
}
fn insert_if_present2<K: Eq + Hash, V>(m: &mut HashMap<K, V>, k: K, v: V) {
2018-12-09 22:26:16 +00:00
if m.contains_key(&k) {
None
} else {
m.insert(k, v)
};
}
fn insert_if_absent3<K: Eq + Hash, V>(m: &mut HashMap<K, V>, k: K, v: V) {
2018-12-09 22:26:16 +00:00
if !m.contains_key(&k) {
foo();
m.insert(k, v)
} else {
None
};
}
fn insert_if_present3<K: Eq + Hash, V>(m: &mut HashMap<K, V>, k: K, v: V) {
2018-12-09 22:26:16 +00:00
if m.contains_key(&k) {
None
} else {
foo();
m.insert(k, v)
};
2015-12-21 23:35:56 +00:00
}
fn insert_in_btreemap<K: Ord, V>(m: &mut BTreeMap<K, V>, k: K, v: V) {
2018-12-09 22:26:16 +00:00
if !m.contains_key(&k) {
foo();
m.insert(k, v)
} else {
None
};
}
// should not trigger
fn insert_other_if_absent<K: Eq + Hash, V>(m: &mut HashMap<K, V>, k: K, o: K, v: V) {
if !m.contains_key(&k) {
m.insert(o, v);
}
}
2019-09-03 00:41:37 +00:00
// should not trigger, because the one uses different HashMap from another one
2019-09-04 15:24:45 +00:00
fn insert_from_different_map<K: Eq + Hash, V>(m: HashMap<K, V>, n: &mut HashMap<K, V>, k: K, v: V) {
if !m.contains_key(&k) {
n.insert(k, v);
}
}
// should not trigger, because the one uses different HashMap from another one
fn insert_from_different_map2<K: Eq + Hash, V>(m: &mut HashMap<K, V>, n: &mut HashMap<K, V>, k: K, v: V) {
2019-09-03 00:41:37 +00:00
if !m.contains_key(&k) {
n.insert(k, v);
}
}
2018-12-09 22:26:16 +00:00
fn main() {}