rust-clippy/clippy_lints/src/vec.rs

107 lines
3.4 KiB
Rust
Raw Normal View History

use crate::consts::constant;
use crate::utils::{higher, is_copy, snippet_with_applicability, span_lint_and_sugg};
use if_chain::if_chain;
use rustc::ty::{self, Ty};
use rustc_errors::Applicability;
2020-02-21 08:39:38 +00:00
use rustc_hir::{BorrowKind, Expr, ExprKind};
2020-01-12 06:08:41 +00:00
use rustc_lint::{LateContext, LateLintPass};
2020-01-11 11:37:08 +00:00
use rustc_session::{declare_lint_pass, declare_tool_lint};
use rustc_span::source_map::Span;
2018-03-28 13:24:26 +00:00
declare_clippy_lint! {
/// **What it does:** Checks for usage of `&vec![..]` when using `&[..]` would
/// be possible.
///
/// **Why is this bad?** This is less efficient.
///
/// **Known problems:** None.
///
/// **Example:**
/// ```rust,ignore
/// foo(&vec![1, 2])
/// ```
pub USELESS_VEC,
2018-03-28 13:24:26 +00:00
perf,
"useless `vec!`"
}
2019-04-08 20:43:55 +00:00
declare_lint_pass!(UselessVec => [USELESS_VEC]);
2019-04-08 20:43:55 +00:00
impl<'a, 'tcx> LateLintPass<'a, 'tcx> for UselessVec {
2019-12-27 07:12:26 +00:00
fn check_expr(&mut self, cx: &LateContext<'a, 'tcx>, expr: &'tcx Expr<'_>) {
2016-03-03 19:09:31 +00:00
// search for `&vec![_]` expressions where the adjusted type is `&[_]`
if_chain! {
if let ty::Ref(_, ty, _) = cx.tables.expr_ty_adjusted(expr).kind;
if let ty::Slice(..) = ty.kind;
2019-11-27 22:30:10 +00:00
if let ExprKind::AddrOf(BorrowKind::Ref, _, ref addressee) = expr.kind;
if let Some(vec_args) = higher::vec_macro(cx, addressee);
then {
check_vec_macro(cx, &vec_args, expr.span);
}
}
// search for `for _ in vec![…]`
if_chain! {
if let Some((_, arg, _)) = higher::for_loop(expr);
if let Some(vec_args) = higher::vec_macro(cx, arg);
if is_copy(cx, vec_type(cx.tables.expr_ty_adjusted(arg)));
then {
// report the error around the `vec!` not inside `<std macros>:`
let span = arg.span
2019-03-26 09:55:03 +00:00
.ctxt()
.outer_expn_data()
.call_site
.ctxt()
.outer_expn_data()
.call_site;
check_vec_macro(cx, &vec_args, span);
}
}
}
}
2017-09-13 13:34:04 +00:00
fn check_vec_macro<'a, 'tcx>(cx: &LateContext<'a, 'tcx>, vec_args: &higher::VecArgs<'tcx>, span: Span) {
let mut applicability = Applicability::MachineApplicable;
let snippet = match *vec_args {
higher::VecArgs::Repeat(elem, len) => {
2018-05-13 11:16:31 +00:00
if constant(cx, cx.tables, len).is_some() {
format!(
"&[{}; {}]",
snippet_with_applicability(cx, elem.span, "elem", &mut applicability),
snippet_with_applicability(cx, len.span, "len", &mut applicability)
)
} else {
return;
}
2016-12-20 17:21:30 +00:00
},
2018-11-27 20:14:15 +00:00
higher::VecArgs::Vec(args) => {
if let Some(last) = args.iter().last() {
let span = args[0].span.to(last.span);
2018-11-27 20:14:15 +00:00
format!("&[{}]", snippet_with_applicability(cx, span, "..", &mut applicability))
} else {
"&[]".into()
}
2016-12-20 17:21:30 +00:00
},
};
2017-08-09 07:30:56 +00:00
span_lint_and_sugg(
cx,
USELESS_VEC,
span,
"useless use of `vec!`",
"you can use a slice directly",
snippet,
applicability,
2017-08-09 07:30:56 +00:00
);
}
2019-01-31 01:15:29 +00:00
/// Returns the item type of the vector (i.e., the `T` in `Vec<T>`).
2018-07-23 11:01:12 +00:00
fn vec_type(ty: Ty<'_>) -> Ty<'_> {
if let ty::Adt(_, substs) = ty.kind {
substs.type_at(0)
} else {
panic!("The type of `vec!` is a not a struct?");
}
}