rust-clippy/tests/ui/question_mark.fixed

161 lines
2.7 KiB
Rust
Raw Normal View History

2020-03-04 08:21:07 +00:00
// run-rustfix
#![allow(unreachable_code)]
2020-11-17 16:01:22 +00:00
#![allow(clippy::unnecessary_wraps)]
2020-03-04 08:21:07 +00:00
fn some_func(a: Option<u32>) -> Option<u32> {
a?;
a
}
fn some_other_func(a: Option<u32>) -> Option<u32> {
if a.is_none() {
return None;
} else {
return Some(0);
}
unreachable!()
}
pub enum SeemsOption<T> {
Some(T),
None,
}
impl<T> SeemsOption<T> {
pub fn is_none(&self) -> bool {
match *self {
SeemsOption::None => true,
SeemsOption::Some(_) => false,
}
}
}
fn returns_something_similar_to_option(a: SeemsOption<u32>) -> SeemsOption<u32> {
if a.is_none() {
return SeemsOption::None;
}
a
}
pub struct CopyStruct {
pub opt: Option<u32>,
}
impl CopyStruct {
#[rustfmt::skip]
pub fn func(&self) -> Option<u32> {
(self.opt)?;
self.opt?;
let _ = Some(self.opt?);
let _ = self.opt?;
self.opt
}
}
#[derive(Clone)]
pub struct MoveStruct {
pub opt: Option<Vec<u32>>,
}
impl MoveStruct {
pub fn ref_func(&self) -> Option<Vec<u32>> {
self.opt.as_ref()?;
self.opt.clone()
}
pub fn mov_func_reuse(self) -> Option<Vec<u32>> {
self.opt.as_ref()?;
self.opt
}
pub fn mov_func_no_use(self) -> Option<Vec<u32>> {
self.opt.as_ref()?;
Some(Vec::new())
}
pub fn if_let_ref_func(self) -> Option<Vec<u32>> {
let v: &Vec<_> = self.opt.as_ref()?;
Some(v.clone())
}
pub fn if_let_mov_func(self) -> Option<Vec<u32>> {
let v = self.opt?;
Some(v)
}
}
fn func() -> Option<i32> {
fn f() -> Option<String> {
Some(String::new())
}
f()?;
Some(0)
}
fn func_returning_result() -> Result<i32, i32> {
Ok(1)
}
fn result_func(x: Result<i32, i32>) -> Result<i32, i32> {
let _ = x?;
x?;
// No warning
let y = if let Ok(x) = x {
x
} else {
return Err(0);
};
// issue #7859
// no warning
let _ = if let Ok(x) = func_returning_result() {
x
} else {
return Err(0);
};
// no warning
if func_returning_result().is_err() {
return func_returning_result();
}
Ok(y)
}
2020-03-04 08:21:07 +00:00
fn main() {
some_func(Some(42));
some_func(None);
some_other_func(Some(42));
let copy_struct = CopyStruct { opt: Some(54) };
copy_struct.func();
let move_struct = MoveStruct {
opt: Some(vec![42, 1337]),
};
move_struct.ref_func();
move_struct.clone().mov_func_reuse();
move_struct.mov_func_no_use();
let so = SeemsOption::Some(45);
returns_something_similar_to_option(so);
func();
let _ = result_func(Ok(42));
2020-03-04 08:21:07 +00:00
}