rust-clippy/clippy_lints/src/consts.rs

458 lines
18 KiB
Rust
Raw Normal View History

2015-08-26 23:10:01 +00:00
#![allow(cast_possible_truncation)]
#![allow(float_cmp)]
2015-08-26 23:10:01 +00:00
use rustc::lint::LateContext;
use rustc::hir::def::Def;
use rustc::hir::*;
2018-03-13 10:38:11 +00:00
use rustc::ty::{self, Ty, TyCtxt, Instance};
2017-09-05 09:33:04 +00:00
use rustc::ty::subst::{Subst, Substs};
2016-03-16 11:38:26 +00:00
use std::cmp::Ordering::{self, Equal};
use std::cmp::PartialOrd;
use std::hash::{Hash, Hasher};
use std::mem;
use std::rc::Rc;
2018-03-13 10:38:11 +00:00
use syntax::ast::{FloatTy, LitKind};
use syntax::ptr::P;
2018-03-13 10:38:11 +00:00
use rustc::middle::const_val::ConstVal;
2018-05-30 08:15:50 +00:00
use crate::utils::{sext, unsext, clip};
#[derive(Debug, Copy, Clone)]
2015-08-13 07:25:44 +00:00
pub enum FloatWidth {
2016-02-15 16:00:06 +00:00
F32,
F64,
Any,
2015-08-13 07:25:44 +00:00
}
impl From<FloatTy> for FloatWidth {
2017-08-21 11:32:12 +00:00
fn from(ty: FloatTy) -> Self {
2015-08-13 07:25:44 +00:00
match ty {
2016-02-15 16:00:06 +00:00
FloatTy::F32 => FloatWidth::F32,
FloatTy::F64 => FloatWidth::F64,
2015-08-13 07:25:44 +00:00
}
}
}
2016-03-19 16:48:29 +00:00
/// A `LitKind`-like enum to fold constant `Expr`s into.
#[derive(Debug, Clone)]
pub enum Constant {
2015-08-13 07:25:44 +00:00
/// a String "abc"
2018-03-13 10:38:11 +00:00
Str(String),
2015-08-13 07:25:44 +00:00
/// a Binary String b"abc"
2016-02-01 11:51:33 +00:00
Binary(Rc<Vec<u8>>),
2015-08-13 07:25:44 +00:00
/// a single char 'a'
2016-02-01 11:51:33 +00:00
Char(char),
2018-03-13 10:38:11 +00:00
/// an integer's bit representation
Int(u128),
/// an f32
F32(f32),
/// an f64
F64(f64),
2015-08-13 07:25:44 +00:00
/// true or false
2016-02-01 11:51:33 +00:00
Bool(bool),
2015-08-13 07:25:44 +00:00
/// an array of constants
2016-02-01 11:51:33 +00:00
Vec(Vec<Constant>),
2015-08-13 07:25:44 +00:00
/// also an array, but with only one constant, repeated N times
2017-09-13 13:34:04 +00:00
Repeat(Box<Constant>, u64),
2015-08-13 07:25:44 +00:00
/// a tuple of constants
2016-02-01 11:51:33 +00:00
Tuple(Vec<Constant>),
2015-08-12 11:49:28 +00:00
}
impl PartialEq for Constant {
2017-08-21 11:32:12 +00:00
fn eq(&self, other: &Self) -> bool {
match (self, other) {
2018-03-13 10:38:11 +00:00
(&Constant::Str(ref ls), &Constant::Str(ref rs)) => ls == rs,
2016-02-01 11:51:33 +00:00
(&Constant::Binary(ref l), &Constant::Binary(ref r)) => l == r,
(&Constant::Char(l), &Constant::Char(r)) => l == r,
2018-03-13 10:38:11 +00:00
(&Constant::Int(l), &Constant::Int(r)) => l == r,
(&Constant::F64(l), &Constant::F64(r)) => {
// we want `Fw32 == FwAny` and `FwAny == Fw64`, by transitivity we must have
// `Fw32 == Fw64` so dont compare them
// mem::transmute is required to catch non-matching 0.0, -0.0, and NaNs
unsafe { mem::transmute::<f64, u64>(l) == mem::transmute::<f64, u64>(r) }
2016-12-20 17:21:30 +00:00
},
2018-03-13 10:38:11 +00:00
(&Constant::F32(l), &Constant::F32(r)) => {
// we want `Fw32 == FwAny` and `FwAny == Fw64`, by transitivity we must have
// `Fw32 == Fw64` so dont compare them
2018-03-13 10:38:11 +00:00
// mem::transmute is required to catch non-matching 0.0, -0.0, and NaNs
unsafe { mem::transmute::<f64, u64>(f64::from(l)) == mem::transmute::<f64, u64>(f64::from(r)) }
2016-12-20 17:21:30 +00:00
},
2016-02-01 11:51:33 +00:00
(&Constant::Bool(l), &Constant::Bool(r)) => l == r,
(&Constant::Vec(ref l), &Constant::Vec(ref r)) | (&Constant::Tuple(ref l), &Constant::Tuple(ref r)) => l == r,
2016-02-01 11:51:33 +00:00
(&Constant::Repeat(ref lv, ref ls), &Constant::Repeat(ref rv, ref rs)) => ls == rs && lv == rv,
2017-09-05 09:33:04 +00:00
_ => false, // TODO: Are there inter-type equalities?
}
}
}
impl Hash for Constant {
2016-02-24 16:38:57 +00:00
fn hash<H>(&self, state: &mut H)
2017-08-09 07:30:56 +00:00
where
H: Hasher,
2016-02-24 16:38:57 +00:00
{
match *self {
2018-03-13 10:38:11 +00:00
Constant::Str(ref s) => {
s.hash(state);
2016-12-20 17:21:30 +00:00
},
Constant::Binary(ref b) => {
b.hash(state);
2016-12-20 17:21:30 +00:00
},
Constant::Char(c) => {
c.hash(state);
2016-12-20 17:21:30 +00:00
},
2016-03-16 11:38:26 +00:00
Constant::Int(i) => {
2018-03-13 10:38:11 +00:00
i.hash(state);
2016-12-20 17:21:30 +00:00
},
2018-03-13 10:38:11 +00:00
Constant::F32(f) => {
unsafe { mem::transmute::<f64, u64>(f64::from(f)) }.hash(state);
2018-03-13 10:38:11 +00:00
},
Constant::F64(f) => {
unsafe { mem::transmute::<f64, u64>(f) }.hash(state);
2016-12-20 17:21:30 +00:00
},
Constant::Bool(b) => {
b.hash(state);
2016-12-20 17:21:30 +00:00
},
2017-09-05 09:33:04 +00:00
Constant::Vec(ref v) | Constant::Tuple(ref v) => {
v.hash(state);
2016-12-20 17:21:30 +00:00
},
Constant::Repeat(ref c, l) => {
c.hash(state);
l.hash(state);
2016-12-20 17:21:30 +00:00
},
}
}
}
2018-06-19 05:37:09 +00:00
impl Constant {
pub fn partial_cmp(tcx: TyCtxt, cmp_type: &ty::TypeVariants, left: &Self, right: &Self) -> Option<Ordering> {
match (left, right) {
2018-03-13 10:38:11 +00:00
(&Constant::Str(ref ls), &Constant::Str(ref rs)) => Some(ls.cmp(rs)),
2016-02-01 11:51:33 +00:00
(&Constant::Char(ref l), &Constant::Char(ref r)) => Some(l.cmp(r)),
2018-06-19 05:37:09 +00:00
(&Constant::Int(l), &Constant::Int(r)) => {
if let ty::TyInt(int_ty) = *cmp_type {
Some(sext(tcx, l, int_ty).cmp(&sext(tcx, r, int_ty)))
} else {
Some(l.cmp(&r))
}
},
2018-03-13 10:38:11 +00:00
(&Constant::F64(l), &Constant::F64(r)) => l.partial_cmp(&r),
(&Constant::F32(l), &Constant::F32(r)) => l.partial_cmp(&r),
2016-02-01 11:51:33 +00:00
(&Constant::Bool(ref l), &Constant::Bool(ref r)) => Some(l.cmp(r)),
2018-06-19 05:37:09 +00:00
(&Constant::Tuple(ref l), &Constant::Tuple(ref r)) | (&Constant::Vec(ref l), &Constant::Vec(ref r)) => l
.iter()
.zip(r.iter())
.map(|(li, ri)| Constant::partial_cmp(tcx, cmp_type, li, ri))
.find(|r| r.map_or(true, |o| o != Ordering::Equal))
.unwrap_or_else(|| Some(l.len().cmp(&r.len()))),
(&Constant::Repeat(ref lv, ref ls), &Constant::Repeat(ref rv, ref rs)) => {
match Constant::partial_cmp(tcx, cmp_type, lv, rv) {
Some(Equal) => Some(ls.cmp(rs)),
x => x,
}
2016-12-20 17:21:30 +00:00
},
2017-09-05 09:33:04 +00:00
_ => None, // TODO: Are there any useful inter-type orderings?
2016-01-04 04:26:12 +00:00
}
}
}
/// parse a `LitKind` to a `Constant`
pub fn lit_to_constant<'tcx>(lit: &LitKind, ty: Ty<'tcx>) -> Constant {
2017-03-01 17:46:18 +00:00
use syntax::ast::*;
2015-08-18 12:18:36 +00:00
match *lit {
2018-03-13 10:38:11 +00:00
LitKind::Str(ref is, _) => Constant::Str(is.to_string()),
LitKind::Byte(b) => Constant::Int(u128::from(b)),
LitKind::ByteStr(ref s) => Constant::Binary(Rc::clone(s)),
2016-02-12 17:35:44 +00:00
LitKind::Char(c) => Constant::Char(c),
2018-03-13 10:38:11 +00:00
LitKind::Int(n, _) => Constant::Int(n),
LitKind::Float(ref is, _) |
LitKind::FloatUnsuffixed(ref is) => match ty.sty {
ty::TyFloat(FloatTy::F32) => Constant::F32(is.as_str().parse().unwrap()),
ty::TyFloat(FloatTy::F64) => Constant::F64(is.as_str().parse().unwrap()),
2017-09-05 09:33:04 +00:00
_ => bug!(),
2017-03-05 09:27:20 +00:00
},
2016-02-12 17:35:44 +00:00
LitKind::Bool(b) => Constant::Bool(b),
2015-08-12 11:49:28 +00:00
}
}
2018-05-13 11:16:31 +00:00
pub fn constant<'c, 'cc>(lcx: &LateContext<'c, 'cc>, tables: &'c ty::TypeckTables<'cc>, e: &Expr) -> Option<(Constant, bool)> {
2016-01-04 04:26:12 +00:00
let mut cx = ConstEvalLateContext {
2017-03-01 17:46:18 +00:00
tcx: lcx.tcx,
2018-05-13 11:16:31 +00:00
tables,
2017-07-31 10:37:38 +00:00
param_env: lcx.param_env,
2016-01-04 04:26:12 +00:00
needed_resolution: false,
substs: lcx.tcx.intern_substs(&[]),
2016-01-04 04:26:12 +00:00
};
cx.expr(e).map(|cst| (cst, cx.needed_resolution))
2015-08-13 07:25:44 +00:00
}
2018-05-13 11:16:31 +00:00
pub fn constant_simple<'c, 'cc>(lcx: &LateContext<'c, 'cc>, tables: &'c ty::TypeckTables<'cc>, e: &Expr) -> Option<Constant> {
constant(lcx, tables, e).and_then(|(cst, res)| if res { None } else { Some(cst) })
}
/// Creates a `ConstEvalLateContext` from the given `LateContext` and `TypeckTables`
2018-05-13 11:16:31 +00:00
pub fn constant_context<'c, 'cc>(lcx: &LateContext<'c, 'cc>, tables: &'c ty::TypeckTables<'cc>) -> ConstEvalLateContext<'c, 'cc> {
ConstEvalLateContext {
tcx: lcx.tcx,
tables,
param_env: lcx.param_env,
needed_resolution: false,
substs: lcx.tcx.intern_substs(&[]),
}
}
pub struct ConstEvalLateContext<'a, 'tcx: 'a> {
2017-03-01 17:46:18 +00:00
tcx: TyCtxt<'a, 'tcx, 'tcx>,
tables: &'a ty::TypeckTables<'tcx>,
2017-07-31 10:37:38 +00:00
param_env: ty::ParamEnv<'tcx>,
2016-01-04 04:26:12 +00:00
needed_resolution: bool,
substs: &'tcx Substs<'tcx>,
}
impl<'c, 'cc> ConstEvalLateContext<'c, 'cc> {
/// simple constant folding: Insert an expression, get a constant or none.
pub fn expr(&mut self, e: &Expr) -> Option<Constant> {
2015-08-17 17:55:59 +00:00
match e.node {
2017-08-15 09:10:49 +00:00
ExprPath(ref qpath) => self.fetch_path(qpath, e.hir_id),
2018-05-17 09:21:15 +00:00
ExprBlock(ref block, _) => self.block(block),
2016-01-04 04:26:12 +00:00
ExprIf(ref cond, ref then, ref otherwise) => self.ifthenelse(cond, then, otherwise),
2018-03-13 10:38:11 +00:00
ExprLit(ref lit) => Some(lit_to_constant(&lit.node, self.tables.expr_ty(e))),
ExprArray(ref vec) => self.multi(vec).map(Constant::Vec),
2016-02-01 11:51:33 +00:00
ExprTup(ref tup) => self.multi(tup).map(Constant::Tuple),
2017-03-03 13:46:33 +00:00
ExprRepeat(ref value, _) => {
let n = match self.tables.expr_ty(e).sty {
2018-05-13 08:44:57 +00:00
ty::TyArray(_, n) => n.assert_usize(self.tcx).expect("array length"),
2017-03-03 13:46:33 +00:00
_ => span_bug!(e.span, "typeck error"),
};
2018-03-13 10:38:11 +00:00
self.expr(value).map(|v| Constant::Repeat(Box::new(v), n as u64))
2016-12-20 17:21:30 +00:00
},
2017-09-05 09:33:04 +00:00
ExprUnary(op, ref operand) => self.expr(operand).and_then(|o| match op {
2018-03-13 10:38:11 +00:00
UnNot => self.constant_not(&o, self.tables.expr_ty(e)),
UnNeg => self.constant_negate(&o, self.tables.expr_ty(e)),
2017-09-05 09:33:04 +00:00
UnDeref => Some(o),
}),
2016-01-04 04:26:12 +00:00
ExprBinary(op, ref left, ref right) => self.binop(op, left, right),
// TODO: add other expressions
_ => None,
}
}
2018-03-13 10:38:11 +00:00
fn constant_not(&self, o: &Constant, ty: ty::Ty) -> Option<Constant> {
use self::Constant::*;
match *o {
Bool(b) => Some(Bool(!b)),
Int(value) => {
let mut value = !value;
match ty.sty {
ty::TyInt(ity) => Some(Int(unsext(self.tcx, value as i128, ity))),
ty::TyUint(ity) => Some(Int(clip(self.tcx, value, ity))),
_ => None,
}
},
_ => None,
}
}
fn constant_negate(&self, o: &Constant, ty: ty::Ty) -> Option<Constant> {
2018-03-13 10:38:11 +00:00
use self::Constant::*;
match *o {
2018-03-13 10:38:11 +00:00
Int(value) => {
let ity = match ty.sty {
ty::TyInt(ity) => ity,
_ => return None,
};
// sign extend
let value = sext(self.tcx, value, ity);
let value = value.checked_neg()?;
// clear unused bits
Some(Int(unsext(self.tcx, value, ity)))
},
F32(f) => Some(F32(-f)),
F64(f) => Some(F64(-f)),
_ => None,
}
}
2015-08-18 10:26:01 +00:00
/// create `Some(Vec![..])` of all constants, unless there is any
/// non-constant part
fn multi(&mut self, vec: &[Expr]) -> Option<Vec<Constant>> {
2016-01-04 04:26:12 +00:00
vec.iter()
2016-12-20 17:21:30 +00:00
.map(|elem| self.expr(elem))
.collect::<Option<_>>()
}
/// lookup a possibly constant expression from a ExprPath
2017-08-15 09:10:49 +00:00
fn fetch_path(&mut self, qpath: &QPath, id: HirId) -> Option<Constant> {
2017-03-01 17:46:18 +00:00
let def = self.tables.qpath_def(qpath, id);
match def {
2017-09-05 09:33:04 +00:00
Def::Const(def_id) | Def::AssociatedConst(def_id) => {
let substs = self.tables.node_substs(id);
let substs = if self.substs.is_empty() {
substs
} else {
substs.subst(self.tcx, self.substs)
};
2018-03-13 10:38:11 +00:00
let instance = Instance::resolve(self.tcx, self.param_env, def_id, substs)?;
let gid = GlobalId {
instance,
promoted: None,
};
use rustc::mir::interpret::GlobalId;
let result = self.tcx.const_eval(self.param_env.and(gid)).ok()?;
let ret = miri_to_const(self.tcx, result);
if ret.is_some() {
self.needed_resolution = true;
2017-03-01 17:46:18 +00:00
}
2018-03-13 10:38:11 +00:00
return ret;
2017-03-01 17:46:18 +00:00
},
_ => {},
}
None
}
/// A block can only yield a constant if it only has one constant expression
fn block(&mut self, block: &Block) -> Option<Constant> {
if block.stmts.is_empty() {
2016-08-01 14:59:14 +00:00
block.expr.as_ref().and_then(|b| self.expr(b))
2016-01-04 04:26:12 +00:00
} else {
None
}
}
fn ifthenelse(&mut self, cond: &Expr, then: &P<Expr>, otherwise: &Option<P<Expr>>) -> Option<Constant> {
2016-02-01 11:51:33 +00:00
if let Some(Constant::Bool(b)) = self.expr(cond) {
if b {
self.expr(&**then)
} else {
otherwise.as_ref().and_then(|expr| self.expr(expr))
}
2016-01-04 04:26:12 +00:00
} else {
None
}
}
fn binop(&mut self, op: BinOp, left: &Expr, right: &Expr) -> Option<Constant> {
2018-03-13 10:38:11 +00:00
let l = self.expr(left)?;
2016-03-16 11:38:26 +00:00
let r = self.expr(right);
2018-03-13 10:38:11 +00:00
match (l, r) {
(Constant::Int(l), Some(Constant::Int(r))) => {
match self.tables.expr_ty(left).sty {
ty::TyInt(ity) => {
let l = sext(self.tcx, l, ity);
let r = sext(self.tcx, r, ity);
let zext = |n: i128| Constant::Int(unsext(self.tcx, n, ity));
match op.node {
BiAdd => l.checked_add(r).map(zext),
BiSub => l.checked_sub(r).map(zext),
BiMul => l.checked_mul(r).map(zext),
BiDiv if r != 0 => l.checked_div(r).map(zext),
BiRem if r != 0 => l.checked_rem(r).map(zext),
BiShr => l.checked_shr(r as u128 as u32).map(zext),
BiShl => l.checked_shl(r as u128 as u32).map(zext),
BiBitXor => Some(zext(l ^ r)),
BiBitOr => Some(zext(l | r)),
BiBitAnd => Some(zext(l & r)),
BiEq => Some(Constant::Bool(l == r)),
BiNe => Some(Constant::Bool(l != r)),
BiLt => Some(Constant::Bool(l < r)),
BiLe => Some(Constant::Bool(l <= r)),
BiGe => Some(Constant::Bool(l >= r)),
BiGt => Some(Constant::Bool(l > r)),
_ => None,
}
}
ty::TyUint(_) => {
match op.node {
BiAdd => l.checked_add(r).map(Constant::Int),
BiSub => l.checked_sub(r).map(Constant::Int),
BiMul => l.checked_mul(r).map(Constant::Int),
BiDiv => l.checked_div(r).map(Constant::Int),
BiRem => l.checked_rem(r).map(Constant::Int),
BiShr => l.checked_shr(r as u32).map(Constant::Int),
BiShl => l.checked_shl(r as u32).map(Constant::Int),
BiBitXor => Some(Constant::Int(l ^ r)),
BiBitOr => Some(Constant::Int(l | r)),
BiBitAnd => Some(Constant::Int(l & r)),
BiEq => Some(Constant::Bool(l == r)),
BiNe => Some(Constant::Bool(l != r)),
BiLt => Some(Constant::Bool(l < r)),
BiLe => Some(Constant::Bool(l <= r)),
BiGe => Some(Constant::Bool(l >= r)),
BiGt => Some(Constant::Bool(l > r)),
_ => None,
}
},
_ => None,
}
},
(Constant::F32(l), Some(Constant::F32(r))) => match op.node {
BiAdd => Some(Constant::F32(l + r)),
BiSub => Some(Constant::F32(l - r)),
BiMul => Some(Constant::F32(l * r)),
BiDiv => Some(Constant::F32(l / r)),
BiRem => Some(Constant::F32(l % r)),
2018-03-13 10:38:11 +00:00
BiEq => Some(Constant::Bool(l == r)),
BiNe => Some(Constant::Bool(l != r)),
BiLt => Some(Constant::Bool(l < r)),
BiLe => Some(Constant::Bool(l <= r)),
BiGe => Some(Constant::Bool(l >= r)),
BiGt => Some(Constant::Bool(l > r)),
_ => None,
},
(Constant::F64(l), Some(Constant::F64(r))) => match op.node {
BiAdd => Some(Constant::F64(l + r)),
BiSub => Some(Constant::F64(l - r)),
BiMul => Some(Constant::F64(l * r)),
BiDiv => Some(Constant::F64(l / r)),
BiRem => Some(Constant::F64(l % r)),
2018-03-13 10:38:11 +00:00
BiEq => Some(Constant::Bool(l == r)),
BiNe => Some(Constant::Bool(l != r)),
BiLt => Some(Constant::Bool(l < r)),
BiLe => Some(Constant::Bool(l <= r)),
BiGe => Some(Constant::Bool(l >= r)),
BiGt => Some(Constant::Bool(l > r)),
_ => None,
},
(l, r) => match (op.node, l, r) {
(BiAnd, Constant::Bool(false), _) => Some(Constant::Bool(false)),
(BiOr, Constant::Bool(true), _) => Some(Constant::Bool(true)),
(BiAnd, Constant::Bool(true), Some(r)) | (BiOr, Constant::Bool(false), Some(r)) => Some(r),
(BiBitXor, Constant::Bool(l), Some(Constant::Bool(r))) => Some(Constant::Bool(l ^ r)),
(BiBitAnd, Constant::Bool(l), Some(Constant::Bool(r))) => Some(Constant::Bool(l & r)),
(BiBitOr, Constant::Bool(l), Some(Constant::Bool(r))) => Some(Constant::Bool(l | r)),
_ => None,
},
}
}
}
pub fn miri_to_const<'a, 'tcx>(tcx: TyCtxt<'a, 'tcx, 'tcx>, result: &ty::Const<'tcx>) -> Option<Constant> {
2018-05-26 08:23:34 +00:00
use rustc::mir::interpret::{Scalar, ConstValue};
2018-03-13 10:38:11 +00:00
match result.val {
2018-05-26 08:23:34 +00:00
ConstVal::Value(ConstValue::Scalar(Scalar::Bits{ bits: b, ..})) => match result.ty.sty {
2018-03-13 10:38:11 +00:00
ty::TyBool => Some(Constant::Bool(b == 1)),
ty::TyUint(_) | ty::TyInt(_) => Some(Constant::Int(b)),
ty::TyFloat(FloatTy::F32) => Some(Constant::F32(f32::from_bits(b as u32))),
ty::TyFloat(FloatTy::F64) => Some(Constant::F64(f64::from_bits(b as u64))),
// FIXME: implement other conversion
_ => None,
},
2018-05-26 08:23:34 +00:00
ConstVal::Value(ConstValue::ScalarPair(Scalar::Ptr(ptr), Scalar::Bits { bits: n, .. })) => match result.ty.sty {
2018-05-11 06:37:48 +00:00
ty::TyRef(_, tam, _) => match tam.sty {
2018-03-13 10:38:11 +00:00
ty::TyStr => {
let alloc = tcx
.alloc_map
.lock()
.unwrap_memory(ptr.alloc_id);
let offset = ptr.offset.bytes() as usize;
2018-03-13 10:38:11 +00:00
let n = n as usize;
String::from_utf8(alloc.bytes[offset..(offset + n)].to_owned()).ok().map(Constant::Str)
},
_ => None,
},
2016-01-04 04:26:12 +00:00
_ => None,
}
2018-03-13 10:38:11 +00:00
// FIXME: implement other conversions
_ => None,
}
2016-02-12 17:35:44 +00:00
}