rust-clippy/tests/ui/unnecessary_clone.stderr

85 lines
2.7 KiB
Text
Raw Normal View History

2017-10-10 04:07:12 +00:00
error: using `clone` on a `Copy` type
2018-10-06 16:18:06 +00:00
--> $DIR/unnecessary_clone.rs:28:5
2017-10-10 04:07:12 +00:00
|
2018-10-06 16:18:06 +00:00
28 | 42.clone();
2017-10-10 04:07:12 +00:00
| ^^^^^^^^^^ help: try removing the `clone` call: `42`
|
= note: `-D clippy::clone-on-copy` implied by `-D warnings`
2017-10-10 04:07:12 +00:00
error: using `clone` on a `Copy` type
2018-10-06 16:18:06 +00:00
--> $DIR/unnecessary_clone.rs:32:5
2017-10-10 04:07:12 +00:00
|
2018-10-06 16:18:06 +00:00
32 | (&42).clone();
2017-10-10 04:07:12 +00:00
| ^^^^^^^^^^^^^ help: try dereferencing it: `*(&42)`
error: using '.clone()' on a ref-counted pointer
2018-10-06 16:18:06 +00:00
--> $DIR/unnecessary_clone.rs:42:5
2017-10-10 04:07:12 +00:00
|
2018-10-06 16:18:06 +00:00
42 | rc.clone();
2018-01-15 04:19:55 +00:00
| ^^^^^^^^^^ help: try this: `Rc::<bool>::clone(&rc)`
2017-10-10 04:07:12 +00:00
|
= note: `-D clippy::clone-on-ref-ptr` implied by `-D warnings`
2017-10-10 04:07:12 +00:00
error: using '.clone()' on a ref-counted pointer
2018-10-06 16:18:06 +00:00
--> $DIR/unnecessary_clone.rs:45:5
2017-10-10 04:07:12 +00:00
|
2018-10-06 16:18:06 +00:00
45 | arc.clone();
2018-01-15 04:19:55 +00:00
| ^^^^^^^^^^^ help: try this: `Arc::<bool>::clone(&arc)`
2017-10-10 04:07:12 +00:00
error: using '.clone()' on a ref-counted pointer
2018-10-06 16:18:06 +00:00
--> $DIR/unnecessary_clone.rs:48:5
2017-10-10 04:07:12 +00:00
|
2018-10-06 16:18:06 +00:00
48 | rcweak.clone();
2018-01-15 04:19:55 +00:00
| ^^^^^^^^^^^^^^ help: try this: `Weak::<bool>::clone(&rcweak)`
2017-10-10 04:07:12 +00:00
error: using '.clone()' on a ref-counted pointer
2018-10-06 16:18:06 +00:00
--> $DIR/unnecessary_clone.rs:51:5
2017-10-10 04:07:12 +00:00
|
2018-10-06 16:18:06 +00:00
51 | arc_weak.clone();
2018-01-15 04:19:55 +00:00
| ^^^^^^^^^^^^^^^^ help: try this: `Weak::<bool>::clone(&arc_weak)`
2018-01-15 04:10:36 +00:00
error: using '.clone()' on a ref-counted pointer
2018-10-06 16:18:06 +00:00
--> $DIR/unnecessary_clone.rs:55:29
2018-01-15 04:10:36 +00:00
|
2018-10-06 16:18:06 +00:00
55 | let _: Arc<SomeTrait> = x.clone();
2018-01-15 04:19:55 +00:00
| ^^^^^^^^^ help: try this: `Arc::<SomeImpl>::clone(&x)`
2017-10-10 04:07:12 +00:00
error: using `clone` on a `Copy` type
2018-10-06 16:18:06 +00:00
--> $DIR/unnecessary_clone.rs:59:5
2017-10-10 04:07:12 +00:00
|
2018-10-06 16:18:06 +00:00
59 | t.clone();
2017-10-10 04:07:12 +00:00
| ^^^^^^^^^ help: try removing the `clone` call: `t`
error: using `clone` on a `Copy` type
2018-10-06 16:18:06 +00:00
--> $DIR/unnecessary_clone.rs:61:5
2017-10-10 04:07:12 +00:00
|
2018-10-06 16:18:06 +00:00
61 | Some(t).clone();
2017-10-10 04:07:12 +00:00
| ^^^^^^^^^^^^^^^ help: try removing the `clone` call: `Some(t)`
error: using `clone` on a double-reference; this will copy the reference instead of cloning the inner type
2018-10-06 16:18:06 +00:00
--> $DIR/unnecessary_clone.rs:67:22
2017-10-10 04:07:12 +00:00
|
2018-10-06 16:18:06 +00:00
67 | let z: &Vec<_> = y.clone();
2017-11-30 09:54:55 +00:00
| ^^^^^^^^^
2017-10-10 04:07:12 +00:00
|
= note: #[deny(clippy::clone_double_ref)] on by default
2017-11-30 09:54:55 +00:00
help: try dereferencing it
|
2018-10-06 16:18:06 +00:00
67 | let z: &Vec<_> = &(*y).clone();
2017-11-30 09:54:55 +00:00
| ^^^^^^^^^^^^^
help: or try being explicit about what type to clone
|
2018-10-06 16:18:06 +00:00
67 | let z: &Vec<_> = &std::vec::Vec<i32>::clone(y);
2017-11-30 09:54:55 +00:00
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
2017-10-10 04:07:12 +00:00
error: called `cloned().collect()` on a slice to create a `Vec`. Calling `to_vec()` is both faster and more readable
2018-10-06 16:18:06 +00:00
--> $DIR/unnecessary_clone.rs:74:27
2017-10-10 04:07:12 +00:00
|
2018-10-06 16:18:06 +00:00
74 | let v2 : Vec<isize> = v.iter().cloned().collect();
2017-10-10 04:07:12 +00:00
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= note: `-D clippy::iter-cloned-collect` implied by `-D warnings`
2017-10-10 04:07:12 +00:00
2018-01-16 16:06:27 +00:00
error: aborting due to 11 previous errors