2
0
Fork 0
mirror of https://github.com/rust-lang/rust-clippy synced 2024-12-29 22:43:41 +00:00
rust-clippy/tests/ui/format.rs

71 lines
2 KiB
Rust
Raw Normal View History

2019-02-24 05:30:08 +00:00
// run-rustfix
#![allow(clippy::print_literal, clippy::redundant_clone)]
2018-07-28 15:34:52 +00:00
#![warn(clippy::useless_format)]
struct Foo(pub String);
macro_rules! foo {
2019-03-10 17:19:47 +00:00
($($t:tt)*) => (Foo(format!($($t)*)))
}
fn main() {
2017-02-08 13:58:07 +00:00
format!("foo");
format!("{{}}");
format!("{{}} abc {{}}");
format!(
r##"foo {{}}
" bar"##
);
2017-02-08 13:58:07 +00:00
format!("{}", "foo");
2019-01-31 01:15:29 +00:00
format!("{:?}", "foo"); // Don't warn about `Debug`.
format!("{:8}", "foo");
format!("{:width$}", "foo", width = 8);
2019-01-31 01:15:29 +00:00
format!("{:+}", "foo"); // Warn when the format makes no difference.
format!("{:<}", "foo"); // Warn when the format makes no difference.
format!("foo {}", "bar");
format!("{} bar", "foo");
let arg: String = "".to_owned();
2017-02-08 13:58:07 +00:00
format!("{}", arg);
2019-01-31 01:15:29 +00:00
format!("{:?}", arg); // Don't warn about debug.
format!("{:8}", arg);
format!("{:width$}", arg, width = 8);
2019-01-31 01:15:29 +00:00
format!("{:+}", arg); // Warn when the format makes no difference.
format!("{:<}", arg); // Warn when the format makes no difference.
format!("foo {}", arg);
format!("{} bar", arg);
2019-01-31 01:15:29 +00:00
// We dont want to warn for non-string args; see issue #697.
format!("{}", 42);
format!("{:?}", 42);
format!("{:+}", 42);
format!("foo {}", 42);
2016-02-20 20:15:05 +00:00
format!("{} bar", 42);
2019-01-31 01:15:29 +00:00
// We only want to warn about `format!` itself.
println!("foo");
println!("{}", "foo");
println!("foo {}", "foo");
println!("{}", 42);
println!("foo {}", 42);
2019-01-31 01:15:29 +00:00
// A `format!` inside a macro should not trigger a warning.
foo!("should not warn");
2019-01-31 01:15:29 +00:00
// Precision on string means slicing without panicking on size.
2019-03-10 17:19:47 +00:00
format!("{:.1}", "foo"); // Could be `"foo"[..1]`
format!("{:.10}", "foo"); // Could not be `"foo"[..10]`
format!("{:.prec$}", "foo", prec = 1);
format!("{:.prec$}", "foo", prec = 10);
format!("{}", 42.to_string());
let x = std::path::PathBuf::from("/bar/foo/qux");
format!("{}", x.display().to_string());
2019-08-23 08:46:23 +00:00
// False positive
let a = "foo".to_string();
let _ = Some(format!("{}", a + "bar"));
}