2018-10-06 16:18:06 +00:00
|
|
|
// Copyright 2014-2018 The Rust Project Developers. See the COPYRIGHT
|
|
|
|
// file at the top-level directory of this distribution.
|
|
|
|
//
|
|
|
|
// Licensed under the Apache License, Version 2.0 <LICENSE-APACHE or
|
|
|
|
// http://www.apache.org/licenses/LICENSE-2.0> or the MIT license
|
|
|
|
// <LICENSE-MIT or http://opensource.org/licenses/MIT>, at your
|
|
|
|
// option. This file may not be copied, modified, or distributed
|
|
|
|
// except according to those terms.
|
|
|
|
|
2018-05-30 08:15:50 +00:00
|
|
|
use crate::utils::{is_allowed, snippet, span_help_and_lint};
|
2018-12-29 15:04:45 +00:00
|
|
|
use rustc::hir::*;
|
|
|
|
use rustc::lint::{LateContext, LateLintPass, LintArray, LintPass};
|
|
|
|
use rustc::{declare_tool_lint, lint_array};
|
|
|
|
use syntax::ast::{LitKind, NodeId};
|
|
|
|
use syntax::source_map::Span;
|
2018-11-27 20:14:15 +00:00
|
|
|
use unicode_normalization::UnicodeNormalization;
|
2015-06-11 09:35:00 +00:00
|
|
|
|
2016-08-06 07:55:04 +00:00
|
|
|
/// **What it does:** Checks for the Unicode zero-width space in the code.
|
2015-12-11 00:22:27 +00:00
|
|
|
///
|
2016-08-06 07:55:04 +00:00
|
|
|
/// **Why is this bad?** Having an invisible character in the code makes for all
|
|
|
|
/// sorts of April fools, but otherwise is very much frowned upon.
|
2015-12-11 00:22:27 +00:00
|
|
|
///
|
2016-08-06 07:55:04 +00:00
|
|
|
/// **Known problems:** None.
|
2015-12-11 00:22:27 +00:00
|
|
|
///
|
2017-08-09 07:30:56 +00:00
|
|
|
/// **Example:** You don't see it, but there may be a zero-width space
|
|
|
|
/// somewhere in this text.
|
2018-03-28 13:24:26 +00:00
|
|
|
declare_clippy_lint! {
|
2016-08-06 08:18:36 +00:00
|
|
|
pub ZERO_WIDTH_SPACE,
|
2018-03-28 13:24:26 +00:00
|
|
|
correctness,
|
2016-02-05 23:13:29 +00:00
|
|
|
"using a zero-width space in a string literal, which is confusing"
|
|
|
|
}
|
|
|
|
|
2016-08-06 07:55:04 +00:00
|
|
|
/// **What it does:** Checks for non-ASCII characters in string literals.
|
2015-12-11 00:22:27 +00:00
|
|
|
///
|
2016-08-06 07:55:04 +00:00
|
|
|
/// **Why is this bad?** Yeah, we know, the 90's called and wanted their charset
|
|
|
|
/// back. Even so, there still are editors and other programs out there that
|
|
|
|
/// don't work well with Unicode. So if the code is meant to be used
|
|
|
|
/// internationally, on multiple operating systems, or has other portability
|
|
|
|
/// requirements, activating this lint could be useful.
|
2015-12-11 00:22:27 +00:00
|
|
|
///
|
2016-08-06 07:55:04 +00:00
|
|
|
/// **Known problems:** None.
|
2015-12-11 00:22:27 +00:00
|
|
|
///
|
2016-07-15 22:25:44 +00:00
|
|
|
/// **Example:**
|
|
|
|
/// ```rust
|
|
|
|
/// let x = "Hä?"
|
|
|
|
/// ```
|
2018-03-28 13:24:26 +00:00
|
|
|
declare_clippy_lint! {
|
2018-11-27 20:49:09 +00:00
|
|
|
pub NON_ASCII_LITERAL,
|
|
|
|
pedantic,
|
|
|
|
"using any literal non-ASCII chars in a string literal instead of using the `\\u` escape"
|
2016-02-05 23:13:29 +00:00
|
|
|
}
|
|
|
|
|
2016-08-06 07:55:04 +00:00
|
|
|
/// **What it does:** Checks for string literals that contain Unicode in a form
|
|
|
|
/// that is not equal to its
|
|
|
|
/// [NFC-recomposition](http://www.unicode.org/reports/tr15/#Norm_Forms).
|
2015-12-11 00:22:27 +00:00
|
|
|
///
|
2016-08-06 07:55:04 +00:00
|
|
|
/// **Why is this bad?** If such a string is compared to another, the results
|
|
|
|
/// may be surprising.
|
2015-12-11 00:22:27 +00:00
|
|
|
///
|
2016-08-06 07:55:04 +00:00
|
|
|
/// **Known problems** None.
|
2015-12-11 00:22:27 +00:00
|
|
|
///
|
2016-08-06 07:55:04 +00:00
|
|
|
/// **Example:** You may not see it, but “à” and “à” aren't the same string. The
|
|
|
|
/// former when escaped is actually `"a\u{300}"` while the latter is `"\u{e0}"`.
|
2018-03-28 13:24:26 +00:00
|
|
|
declare_clippy_lint! {
|
2018-11-27 20:49:09 +00:00
|
|
|
pub UNICODE_NOT_NFC,
|
|
|
|
pedantic,
|
|
|
|
"using a unicode literal not in NFC normal form (see [unicode tr15](http://www.unicode.org/reports/tr15/) for further information)"
|
2016-02-05 23:13:29 +00:00
|
|
|
}
|
2015-09-04 07:08:07 +00:00
|
|
|
|
2015-06-11 09:35:00 +00:00
|
|
|
#[derive(Copy, Clone)]
|
|
|
|
pub struct Unicode;
|
|
|
|
|
|
|
|
impl LintPass for Unicode {
|
2015-08-11 18:22:20 +00:00
|
|
|
fn get_lints(&self) -> LintArray {
|
2015-09-04 07:08:07 +00:00
|
|
|
lint_array!(ZERO_WIDTH_SPACE, NON_ASCII_LITERAL, UNICODE_NOT_NFC)
|
2015-06-11 09:35:00 +00:00
|
|
|
}
|
2015-09-19 02:53:04 +00:00
|
|
|
}
|
2015-08-11 18:22:20 +00:00
|
|
|
|
2016-12-07 12:13:40 +00:00
|
|
|
impl<'a, 'tcx> LateLintPass<'a, 'tcx> for Unicode {
|
|
|
|
fn check_expr(&mut self, cx: &LateContext<'a, 'tcx>, expr: &'tcx Expr) {
|
2018-07-12 07:30:57 +00:00
|
|
|
if let ExprKind::Lit(ref lit) = expr.node {
|
2016-02-12 17:35:44 +00:00
|
|
|
if let LitKind::Str(_, _) = lit.node {
|
2017-08-11 12:11:46 +00:00
|
|
|
check_str(cx, lit.span, expr.id)
|
2015-08-11 18:22:20 +00:00
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
2015-06-11 09:35:00 +00:00
|
|
|
}
|
|
|
|
|
2016-01-04 04:26:12 +00:00
|
|
|
fn escape<T: Iterator<Item = char>>(s: T) -> String {
|
2015-09-04 07:08:07 +00:00
|
|
|
let mut result = String::new();
|
|
|
|
for c in s {
|
2015-08-12 18:36:10 +00:00
|
|
|
if c as u32 > 0x7F {
|
2016-01-04 04:26:12 +00:00
|
|
|
for d in c.escape_unicode() {
|
|
|
|
result.push(d)
|
|
|
|
}
|
2015-09-04 07:08:07 +00:00
|
|
|
} else {
|
|
|
|
result.push(c);
|
2015-08-11 18:22:20 +00:00
|
|
|
}
|
|
|
|
}
|
2015-09-04 07:08:07 +00:00
|
|
|
result
|
2015-06-11 09:35:00 +00:00
|
|
|
}
|
|
|
|
|
2018-07-23 11:01:12 +00:00
|
|
|
fn check_str(cx: &LateContext<'_, '_>, span: Span, id: NodeId) {
|
2015-09-04 12:24:49 +00:00
|
|
|
let string = snippet(cx, span, "");
|
2015-09-04 07:08:07 +00:00
|
|
|
if string.contains('\u{200B}') {
|
2017-08-09 07:30:56 +00:00
|
|
|
span_help_and_lint(
|
|
|
|
cx,
|
|
|
|
ZERO_WIDTH_SPACE,
|
|
|
|
span,
|
|
|
|
"zero-width space detected",
|
|
|
|
&format!(
|
|
|
|
"Consider replacing the string with:\n\"{}\"",
|
|
|
|
string.replace("\u{200B}", "\\u{200B}")
|
|
|
|
),
|
|
|
|
);
|
2015-09-04 07:08:07 +00:00
|
|
|
}
|
|
|
|
if string.chars().any(|c| c as u32 > 0x7F) {
|
2017-08-09 07:30:56 +00:00
|
|
|
span_help_and_lint(
|
|
|
|
cx,
|
|
|
|
NON_ASCII_LITERAL,
|
|
|
|
span,
|
|
|
|
"literal non-ASCII character detected",
|
|
|
|
&format!(
|
|
|
|
"Consider replacing the string with:\n\"{}\"",
|
2017-08-11 12:11:46 +00:00
|
|
|
if is_allowed(cx, UNICODE_NOT_NFC, id) {
|
2017-08-09 07:30:56 +00:00
|
|
|
escape(string.chars())
|
|
|
|
} else {
|
|
|
|
escape(string.nfc())
|
|
|
|
}
|
|
|
|
),
|
|
|
|
);
|
2015-09-04 07:08:07 +00:00
|
|
|
}
|
2017-08-11 12:11:46 +00:00
|
|
|
if is_allowed(cx, NON_ASCII_LITERAL, id) && string.chars().zip(string.nfc()).any(|(a, b)| a != b) {
|
2017-08-09 07:30:56 +00:00
|
|
|
span_help_and_lint(
|
|
|
|
cx,
|
|
|
|
UNICODE_NOT_NFC,
|
|
|
|
span,
|
|
|
|
"non-nfc unicode sequence detected",
|
2018-11-27 20:14:15 +00:00
|
|
|
&format!(
|
|
|
|
"Consider replacing the string with:\n\"{}\"",
|
|
|
|
string.nfc().collect::<String>()
|
|
|
|
),
|
2017-08-09 07:30:56 +00:00
|
|
|
);
|
2015-09-04 07:08:07 +00:00
|
|
|
}
|
2015-06-11 09:35:00 +00:00
|
|
|
}
|