2
0
Fork 0
mirror of https://github.com/rust-lang/rust-clippy synced 2024-12-20 18:13:36 +00:00
rust-clippy/tests/ui/bool_comparison.rs

168 lines
2.9 KiB
Rust
Raw Normal View History

2023-06-10 11:43:30 +00:00
#![allow(clippy::needless_if)]
#![warn(clippy::bool_comparison)]
#![allow(clippy::non_canonical_partial_ord_impl)]
fn main() {
let x = true;
2018-12-09 22:26:16 +00:00
if x == true {
"yes"
} else {
"no"
};
if x == false {
"yes"
} else {
"no"
};
if true == x {
"yes"
} else {
"no"
};
if false == x {
"yes"
} else {
"no"
};
if x != true {
"yes"
} else {
"no"
};
if x != false {
"yes"
} else {
"no"
};
if true != x {
"yes"
} else {
"no"
};
if false != x {
"yes"
} else {
"no"
};
if x < true {
"yes"
} else {
"no"
};
if false < x {
"yes"
} else {
"no"
};
if x > false {
"yes"
} else {
"no"
};
if true > x {
"yes"
} else {
"no"
};
let y = true;
if x < y {
"yes"
} else {
"no"
};
if x > y {
"yes"
} else {
"no"
};
}
#[allow(dead_code)]
fn issue3703() {
struct Foo;
impl PartialEq<bool> for Foo {
fn eq(&self, _: &bool) -> bool {
true
}
}
impl PartialEq<Foo> for bool {
fn eq(&self, _: &Foo) -> bool {
true
}
}
impl PartialOrd<bool> for Foo {
fn partial_cmp(&self, _: &bool) -> Option<std::cmp::Ordering> {
None
}
}
impl PartialOrd<Foo> for bool {
fn partial_cmp(&self, _: &Foo) -> Option<std::cmp::Ordering> {
None
}
}
if Foo == true {}
if true == Foo {}
if Foo != true {}
if true != Foo {}
if Foo == false {}
if false == Foo {}
if Foo != false {}
if false != Foo {}
if Foo < false {}
if false < Foo {}
}
2020-03-23 19:29:12 +00:00
2020-03-23 20:21:18 +00:00
#[allow(dead_code)]
2020-03-23 19:29:12 +00:00
fn issue4983() {
let a = true;
let b = false;
if a == !b {};
if !a == b {};
if a == b {};
if !a == !b {};
2020-03-23 20:00:02 +00:00
if b == !a {};
if !b == a {};
if b == a {};
if !b == !a {};
2020-03-23 19:29:12 +00:00
}
macro_rules! m {
($func:ident) => {
$func()
};
}
fn func() -> bool {
true
}
#[allow(dead_code)]
fn issue3973() {
// ok, don't lint on `cfg` invocation
if false == cfg!(feature = "debugging") {}
if cfg!(feature = "debugging") == false {}
if true == cfg!(feature = "debugging") {}
if cfg!(feature = "debugging") == true {}
// lint, could be simplified
if false == m!(func) {}
if m!(func) == false {}
if true == m!(func) {}
if m!(func) == true {}
// no lint with a variable
let is_debug = false;
if is_debug == cfg!(feature = "debugging") {}
if cfg!(feature = "debugging") == is_debug {}
if is_debug == m!(func) {}
if m!(func) == is_debug {}
let is_debug = true;
if is_debug == cfg!(feature = "debugging") {}
if cfg!(feature = "debugging") == is_debug {}
if is_debug == m!(func) {}
if m!(func) == is_debug {}
}