rust-clippy/tests/ui/useless_conversion_try.rs

51 lines
2 KiB
Rust
Raw Normal View History

#![deny(clippy::useless_conversion)]
#![allow(clippy::needless_if, clippy::unnecessary_fallible_conversions)]
fn test_generic<T: Copy>(val: T) -> T {
let _ = T::try_from(val).unwrap();
//~^ ERROR: useless conversion to the same type: `T`
val.try_into().unwrap()
//~^ ERROR: useless conversion to the same type: `T`
}
fn test_generic2<T: Copy + Into<i32> + Into<U>, U: From<T>>(val: T) {
// ok
let _: i32 = val.try_into().unwrap();
let _: U = val.try_into().unwrap();
let _ = U::try_from(val).unwrap();
}
fn main() {
test_generic(10i32);
test_generic2::<i32, i32>(10i32);
let _: String = "foo".try_into().unwrap();
let _: String = TryFrom::try_from("foo").unwrap();
let _ = String::try_from("foo").unwrap();
#[allow(clippy::useless_conversion)]
{
let _ = String::try_from("foo").unwrap();
let _: String = "foo".try_into().unwrap();
}
let _: String = "foo".to_string().try_into().unwrap();
//~^ ERROR: useless conversion to the same type: `std::string::String`
let _: String = TryFrom::try_from("foo".to_string()).unwrap();
//~^ ERROR: useless conversion to the same type: `std::string::String`
let _ = String::try_from("foo".to_string()).unwrap();
//~^ ERROR: useless conversion to the same type: `std::string::String`
let _ = String::try_from(format!("A: {:04}", 123)).unwrap();
//~^ ERROR: useless conversion to the same type: `std::string::String`
let _: String = format!("Hello {}", "world").try_into().unwrap();
//~^ ERROR: useless conversion to the same type: `std::string::String`
let _: String = String::new().try_into().unwrap();
//~^ ERROR: useless conversion to the same type: `std::string::String`
2020-05-26 16:40:42 +00:00
let _: String = match String::from("_").try_into() {
//~^ ERROR: useless conversion to the same type: `std::string::String`
2020-05-26 16:40:42 +00:00
Ok(a) => a,
Err(_) => String::new(),
2020-05-26 16:40:42 +00:00
};
// FIXME this is a false negative
#[allow(clippy::cmp_owned)]
if String::from("a") == TryInto::<String>::try_into(String::from("a")).unwrap() {}
}