rust-clippy/tests/ui/inconsistent_struct_constructor.fixed

75 lines
1.4 KiB
Rust
Raw Normal View History

//@run-rustfix
//@aux-build:proc_macros.rs
#![warn(clippy::inconsistent_struct_constructor)]
#![allow(clippy::redundant_field_names)]
#![allow(clippy::unnecessary_operation)]
#![allow(clippy::no_effect)]
#![allow(dead_code)]
extern crate proc_macros;
#[derive(Default)]
struct Foo {
x: i32,
y: i32,
z: i32,
}
mod without_base {
use super::Foo;
#[proc_macros::inline_macros]
fn test() {
let x = 1;
let y = 1;
let z = 1;
// Should lint.
Foo { x, y, z };
2021-04-20 04:33:39 +00:00
// Should NOT lint.
// issue #7069.
inline!({
let x = 1;
let y = 1;
let z = 1;
Foo { y, x, z }
});
2021-04-20 04:33:39 +00:00
2022-07-13 14:48:32 +00:00
// Should NOT lint because the order is the same as in the definition.
Foo { x, y, z };
// Should NOT lint because z is not a shorthand init.
Foo { y, x, z: z };
}
}
mod with_base {
use super::Foo;
fn test() {
let x = 1;
let z = 1;
// Should lint.
Foo { x, z, ..Default::default() };
// Should NOT lint because the order is consistent with the definition.
Foo {
x,
z,
..Default::default()
};
// Should NOT lint because z is not a shorthand init.
Foo {
z: z,
x,
..Default::default()
};
}
}
fn main() {}