rust-clippy/clippy_lints/src/consts.rs

370 lines
14 KiB
Rust
Raw Normal View History

2015-08-26 23:10:01 +00:00
#![allow(cast_possible_truncation)]
use rustc::lint::LateContext;
use rustc::hir::def::Def;
use rustc_const_eval::lookup_const_by_id;
2017-03-01 17:46:18 +00:00
use rustc_const_math::ConstInt;
use rustc::hir::*;
2017-09-05 09:33:04 +00:00
use rustc::ty::{self, Ty, TyCtxt};
use rustc::ty::subst::{Subst, Substs};
2016-03-16 11:38:26 +00:00
use std::cmp::Ordering::{self, Equal};
use std::cmp::PartialOrd;
use std::hash::{Hash, Hasher};
use std::mem;
use std::rc::Rc;
2017-08-15 09:10:49 +00:00
use syntax::ast::{FloatTy, LitKind, StrStyle};
use syntax::ptr::P;
2017-09-13 13:34:04 +00:00
use utils::const_to_u64;
#[derive(Debug, Copy, Clone)]
2015-08-13 07:25:44 +00:00
pub enum FloatWidth {
2016-02-15 16:00:06 +00:00
F32,
F64,
Any,
2015-08-13 07:25:44 +00:00
}
impl From<FloatTy> for FloatWidth {
2017-08-21 11:32:12 +00:00
fn from(ty: FloatTy) -> Self {
2015-08-13 07:25:44 +00:00
match ty {
2016-02-15 16:00:06 +00:00
FloatTy::F32 => FloatWidth::F32,
FloatTy::F64 => FloatWidth::F64,
2015-08-13 07:25:44 +00:00
}
}
}
2016-03-19 16:48:29 +00:00
/// A `LitKind`-like enum to fold constant `Expr`s into.
#[derive(Debug, Clone)]
pub enum Constant {
2015-08-13 07:25:44 +00:00
/// a String "abc"
2016-02-01 11:51:33 +00:00
Str(String, StrStyle),
2015-08-13 07:25:44 +00:00
/// a Binary String b"abc"
2016-02-01 11:51:33 +00:00
Binary(Rc<Vec<u8>>),
2015-08-13 07:25:44 +00:00
/// a single char 'a'
2016-02-01 11:51:33 +00:00
Char(char),
2016-02-12 17:35:44 +00:00
/// an integer, third argument is whether the value is negated
2016-03-16 11:38:26 +00:00
Int(ConstInt),
2015-08-13 07:25:44 +00:00
/// a float with given type
2016-02-01 11:51:33 +00:00
Float(String, FloatWidth),
2015-08-13 07:25:44 +00:00
/// true or false
2016-02-01 11:51:33 +00:00
Bool(bool),
2015-08-13 07:25:44 +00:00
/// an array of constants
2016-02-01 11:51:33 +00:00
Vec(Vec<Constant>),
2015-08-13 07:25:44 +00:00
/// also an array, but with only one constant, repeated N times
2017-09-13 13:34:04 +00:00
Repeat(Box<Constant>, u64),
2015-08-13 07:25:44 +00:00
/// a tuple of constants
2016-02-01 11:51:33 +00:00
Tuple(Vec<Constant>),
2015-08-12 11:49:28 +00:00
}
impl PartialEq for Constant {
2017-08-21 11:32:12 +00:00
fn eq(&self, other: &Self) -> bool {
match (self, other) {
(&Constant::Str(ref ls, ref l_sty), &Constant::Str(ref rs, ref r_sty)) => ls == rs && l_sty == r_sty,
2016-02-01 11:51:33 +00:00
(&Constant::Binary(ref l), &Constant::Binary(ref r)) => l == r,
(&Constant::Char(l), &Constant::Char(r)) => l == r,
2016-04-14 18:14:03 +00:00
(&Constant::Int(l), &Constant::Int(r)) => {
l.is_negative() == r.is_negative() && l.to_u128_unchecked() == r.to_u128_unchecked()
2016-12-20 17:21:30 +00:00
},
(&Constant::Float(ref ls, _), &Constant::Float(ref rs, _)) => {
// we want `Fw32 == FwAny` and `FwAny == Fw64`, by transitivity we must have
// `Fw32 == Fw64` so dont compare them
match (ls.parse::<f64>(), rs.parse::<f64>()) {
// mem::transmute is required to catch non-matching 0.0, -0.0, and NaNs
2016-12-20 17:21:30 +00:00
(Ok(l), Ok(r)) => unsafe { mem::transmute::<f64, u64>(l) == mem::transmute::<f64, u64>(r) },
_ => false,
2016-01-04 04:26:12 +00:00
}
2016-12-20 17:21:30 +00:00
},
2016-02-01 11:51:33 +00:00
(&Constant::Bool(l), &Constant::Bool(r)) => l == r,
(&Constant::Vec(ref l), &Constant::Vec(ref r)) => l == r,
(&Constant::Repeat(ref lv, ref ls), &Constant::Repeat(ref rv, ref rs)) => ls == rs && lv == rv,
(&Constant::Tuple(ref l), &Constant::Tuple(ref r)) => l == r,
2017-09-05 09:33:04 +00:00
_ => false, // TODO: Are there inter-type equalities?
}
}
}
impl Hash for Constant {
2016-02-24 16:38:57 +00:00
fn hash<H>(&self, state: &mut H)
2017-08-09 07:30:56 +00:00
where
H: Hasher,
2016-02-24 16:38:57 +00:00
{
match *self {
Constant::Str(ref s, ref k) => {
s.hash(state);
k.hash(state);
2016-12-20 17:21:30 +00:00
},
Constant::Binary(ref b) => {
b.hash(state);
2016-12-20 17:21:30 +00:00
},
Constant::Char(c) => {
c.hash(state);
2016-12-20 17:21:30 +00:00
},
2016-03-16 11:38:26 +00:00
Constant::Int(i) => {
i.to_u128_unchecked().hash(state);
2016-03-16 15:28:31 +00:00
i.is_negative().hash(state);
2016-12-20 17:21:30 +00:00
},
Constant::Float(ref f, _) => {
// dont use the width here because of PartialEq implementation
if let Ok(f) = f.parse::<f64>() {
unsafe { mem::transmute::<f64, u64>(f) }.hash(state);
}
2016-12-20 17:21:30 +00:00
},
Constant::Bool(b) => {
b.hash(state);
2016-12-20 17:21:30 +00:00
},
2017-09-05 09:33:04 +00:00
Constant::Vec(ref v) | Constant::Tuple(ref v) => {
v.hash(state);
2016-12-20 17:21:30 +00:00
},
Constant::Repeat(ref c, l) => {
c.hash(state);
l.hash(state);
2016-12-20 17:21:30 +00:00
},
}
}
}
impl PartialOrd for Constant {
2017-08-21 11:32:12 +00:00
fn partial_cmp(&self, other: &Self) -> Option<Ordering> {
match (self, other) {
2017-09-05 09:33:04 +00:00
(&Constant::Str(ref ls, ref l_sty), &Constant::Str(ref rs, ref r_sty)) => if l_sty == r_sty {
Some(ls.cmp(rs))
} else {
None
2016-12-20 17:21:30 +00:00
},
2016-02-01 11:51:33 +00:00
(&Constant::Char(ref l), &Constant::Char(ref r)) => Some(l.cmp(r)),
2016-03-16 11:38:26 +00:00
(&Constant::Int(l), &Constant::Int(r)) => Some(l.cmp(&r)),
(&Constant::Float(ref ls, _), &Constant::Float(ref rs, _)) => {
match (ls.parse::<f64>(), rs.parse::<f64>()) {
2016-12-20 17:21:30 +00:00
(Ok(ref l), Ok(ref r)) => {
match (l.partial_cmp(r), l.is_sign_positive() == r.is_sign_positive()) {
// Check for comparison of -0.0 and 0.0
(Some(Ordering::Equal), false) => None,
(x, _) => x,
}
},
_ => None,
2016-01-04 04:26:12 +00:00
}
2016-12-20 17:21:30 +00:00
},
2016-02-01 11:51:33 +00:00
(&Constant::Bool(ref l), &Constant::Bool(ref r)) => Some(l.cmp(r)),
2017-09-05 09:33:04 +00:00
(&Constant::Tuple(ref l), &Constant::Tuple(ref r)) | (&Constant::Vec(ref l), &Constant::Vec(ref r)) => {
l.partial_cmp(r)
},
(&Constant::Repeat(ref lv, ref ls), &Constant::Repeat(ref rv, ref rs)) => match lv.partial_cmp(rv) {
Some(Equal) => Some(ls.cmp(rs)),
x => x,
2016-12-20 17:21:30 +00:00
},
2017-09-05 09:33:04 +00:00
_ => None, // TODO: Are there any useful inter-type orderings?
2016-01-04 04:26:12 +00:00
}
}
}
/// parse a `LitKind` to a `Constant`
2016-03-16 11:38:26 +00:00
#[allow(cast_possible_wrap)]
pub fn lit_to_constant<'a, 'tcx>(lit: &LitKind, tcx: TyCtxt<'a, 'tcx, 'tcx>, mut ty: Ty<'tcx>) -> Constant {
2017-03-01 17:46:18 +00:00
use syntax::ast::*;
use syntax::ast::LitIntType::*;
use rustc::ty::util::IntTypeExt;
if let ty::TyAdt(adt, _) = ty.sty {
if adt.is_enum() {
ty = adt.repr.discr_type().to_ty(tcx)
}
}
2015-08-18 12:18:36 +00:00
match *lit {
2016-02-12 17:35:44 +00:00
LitKind::Str(ref is, style) => Constant::Str(is.to_string(), style),
2016-03-16 11:38:26 +00:00
LitKind::Byte(b) => Constant::Int(ConstInt::U8(b)),
LitKind::ByteStr(ref s) => Constant::Binary(Rc::clone(s)),
2016-02-12 17:35:44 +00:00
LitKind::Char(c) => Constant::Char(c),
2017-09-05 09:33:04 +00:00
LitKind::Int(n, hint) => match (&ty.sty, hint) {
(&ty::TyInt(ity), _) | (_, Signed(ity)) => {
2017-09-13 13:34:04 +00:00
Constant::Int(ConstInt::new_signed_truncating(n as i128, ity, tcx.sess.target.isize_ty))
2017-09-05 09:33:04 +00:00
},
(&ty::TyUint(uty), _) | (_, Unsigned(uty)) => {
2017-09-13 13:34:04 +00:00
Constant::Int(ConstInt::new_unsigned_truncating(n as u128, uty, tcx.sess.target.usize_ty))
2017-09-05 09:33:04 +00:00
},
_ => bug!(),
2017-03-05 09:27:20 +00:00
},
2016-02-12 17:35:44 +00:00
LitKind::Float(ref is, ty) => Constant::Float(is.to_string(), ty.into()),
2016-02-15 16:00:06 +00:00
LitKind::FloatUnsuffixed(ref is) => Constant::Float(is.to_string(), FloatWidth::Any),
2016-02-12 17:35:44 +00:00
LitKind::Bool(b) => Constant::Bool(b),
2015-08-12 11:49:28 +00:00
}
}
fn constant_not(o: &Constant) -> Option<Constant> {
2016-02-03 14:39:22 +00:00
use self::Constant::*;
match *o {
2016-02-03 14:39:22 +00:00
Bool(b) => Some(Bool(!b)),
2016-03-16 11:38:26 +00:00
Int(value) => (!value).ok().map(Int),
2016-02-03 14:39:22 +00:00
_ => None,
}
2015-08-17 14:45:50 +00:00
}
2015-08-13 07:25:44 +00:00
fn constant_negate(o: Constant) -> Option<Constant> {
2016-02-03 14:39:22 +00:00
use self::Constant::*;
match o {
2016-03-16 11:38:26 +00:00
Int(value) => (-value).ok().map(Int),
2017-02-18 08:00:36 +00:00
Float(is, ty) => Some(Float(neg_float_str(&is), ty)),
2016-02-03 14:39:22 +00:00
_ => None,
}
2015-08-13 07:25:44 +00:00
}
2017-02-18 08:00:36 +00:00
fn neg_float_str(s: &str) -> String {
if s.starts_with('-') {
s[1..].to_owned()
2015-08-12 11:49:28 +00:00
} else {
format!("-{}", s)
2015-08-12 11:49:28 +00:00
}
}
2015-08-13 07:25:44 +00:00
pub fn constant(lcx: &LateContext, e: &Expr) -> Option<(Constant, bool)> {
2016-01-04 04:26:12 +00:00
let mut cx = ConstEvalLateContext {
2017-03-01 17:46:18 +00:00
tcx: lcx.tcx,
tables: lcx.tables,
2017-07-31 10:37:38 +00:00
param_env: lcx.param_env,
2016-01-04 04:26:12 +00:00
needed_resolution: false,
substs: lcx.tcx.intern_substs(&[]),
2016-01-04 04:26:12 +00:00
};
cx.expr(e).map(|cst| (cst, cx.needed_resolution))
2015-08-13 07:25:44 +00:00
}
2017-03-01 17:46:18 +00:00
pub fn constant_simple(lcx: &LateContext, e: &Expr) -> Option<Constant> {
constant(lcx, e).and_then(|(cst, res)| if res { None } else { Some(cst) })
}
2017-03-01 17:46:18 +00:00
struct ConstEvalLateContext<'a, 'tcx: 'a> {
tcx: TyCtxt<'a, 'tcx, 'tcx>,
tables: &'a ty::TypeckTables<'tcx>,
2017-07-31 10:37:38 +00:00
param_env: ty::ParamEnv<'tcx>,
2016-01-04 04:26:12 +00:00
needed_resolution: bool,
substs: &'tcx Substs<'tcx>,
}
impl<'c, 'cc> ConstEvalLateContext<'c, 'cc> {
/// simple constant folding: Insert an expression, get a constant or none.
fn expr(&mut self, e: &Expr) -> Option<Constant> {
2015-08-17 17:55:59 +00:00
match e.node {
2017-08-15 09:10:49 +00:00
ExprPath(ref qpath) => self.fetch_path(qpath, e.hir_id),
2015-08-17 17:55:59 +00:00
ExprBlock(ref block) => self.block(block),
2016-01-04 04:26:12 +00:00
ExprIf(ref cond, ref then, ref otherwise) => self.ifthenelse(cond, then, otherwise),
2017-03-01 17:46:18 +00:00
ExprLit(ref lit) => Some(lit_to_constant(&lit.node, self.tcx, self.tables.expr_ty(e))),
ExprArray(ref vec) => self.multi(vec).map(Constant::Vec),
2016-02-01 11:51:33 +00:00
ExprTup(ref tup) => self.multi(tup).map(Constant::Tuple),
2017-03-03 13:46:33 +00:00
ExprRepeat(ref value, _) => {
let n = match self.tables.expr_ty(e).sty {
2017-09-13 13:34:04 +00:00
ty::TyArray(_, n) => const_to_u64(n),
2017-03-03 13:46:33 +00:00
_ => span_bug!(e.span, "typeck error"),
};
self.expr(value).map(|v| Constant::Repeat(Box::new(v), n))
2016-12-20 17:21:30 +00:00
},
2017-09-05 09:33:04 +00:00
ExprUnary(op, ref operand) => self.expr(operand).and_then(|o| match op {
UnNot => constant_not(&o),
UnNeg => constant_negate(o),
UnDeref => Some(o),
}),
2016-01-04 04:26:12 +00:00
ExprBinary(op, ref left, ref right) => self.binop(op, left, right),
// TODO: add other expressions
_ => None,
}
}
2015-08-18 10:26:01 +00:00
/// create `Some(Vec![..])` of all constants, unless there is any
/// non-constant part
fn multi(&mut self, vec: &[Expr]) -> Option<Vec<Constant>> {
2016-01-04 04:26:12 +00:00
vec.iter()
2016-12-20 17:21:30 +00:00
.map(|elem| self.expr(elem))
.collect::<Option<_>>()
}
/// lookup a possibly constant expression from a ExprPath
2017-08-15 09:10:49 +00:00
fn fetch_path(&mut self, qpath: &QPath, id: HirId) -> Option<Constant> {
2017-03-01 17:46:18 +00:00
let def = self.tables.qpath_def(qpath, id);
match def {
2017-09-05 09:33:04 +00:00
Def::Const(def_id) | Def::AssociatedConst(def_id) => {
let substs = self.tables.node_substs(id);
let substs = if self.substs.is_empty() {
substs
} else {
substs.subst(self.tcx, self.substs)
};
2017-07-31 10:37:38 +00:00
let param_env = self.param_env.and((def_id, substs));
if let Some((def_id, substs)) = lookup_const_by_id(self.tcx, param_env) {
2017-08-21 11:32:12 +00:00
let mut cx = Self {
2017-03-01 17:46:18 +00:00
tcx: self.tcx,
tables: self.tcx.typeck_tables_of(def_id),
2017-03-01 17:46:18 +00:00
needed_resolution: false,
2017-05-03 12:13:50 +00:00
substs: substs,
2017-07-31 10:37:38 +00:00
param_env: param_env.param_env,
2017-03-01 17:46:18 +00:00
};
2017-04-24 11:35:14 +00:00
let body = if let Some(id) = self.tcx.hir.as_local_node_id(def_id) {
2017-04-27 12:00:35 +00:00
self.tcx.mir_const_qualif(def_id);
2017-04-24 11:35:14 +00:00
self.tcx.hir.body(self.tcx.hir.body_owned_by(id))
} else {
self.tcx.extern_const_body(def_id)
2017-04-24 11:35:14 +00:00
};
let ret = cx.expr(&body.value);
2017-03-01 17:46:18 +00:00
if ret.is_some() {
self.needed_resolution = true;
}
2017-03-01 17:46:18 +00:00
return ret;
}
},
_ => {},
}
None
}
/// A block can only yield a constant if it only has one constant expression
fn block(&mut self, block: &Block) -> Option<Constant> {
if block.stmts.is_empty() {
2016-08-01 14:59:14 +00:00
block.expr.as_ref().and_then(|b| self.expr(b))
2016-01-04 04:26:12 +00:00
} else {
None
}
}
fn ifthenelse(&mut self, cond: &Expr, then: &P<Expr>, otherwise: &Option<P<Expr>>) -> Option<Constant> {
2016-02-01 11:51:33 +00:00
if let Some(Constant::Bool(b)) = self.expr(cond) {
if b {
self.expr(&**then)
} else {
otherwise.as_ref().and_then(|expr| self.expr(expr))
}
2016-01-04 04:26:12 +00:00
} else {
None
}
}
fn binop(&mut self, op: BinOp, left: &Expr, right: &Expr) -> Option<Constant> {
2016-04-14 18:14:03 +00:00
let l = if let Some(l) = self.expr(left) {
l
} else {
return None;
};
2016-03-16 11:38:26 +00:00
let r = self.expr(right);
match (op.node, l, r) {
(BiAdd, Constant::Int(l), Some(Constant::Int(r))) => (l + r).ok().map(Constant::Int),
(BiSub, Constant::Int(l), Some(Constant::Int(r))) => (l - r).ok().map(Constant::Int),
(BiMul, Constant::Int(l), Some(Constant::Int(r))) => (l * r).ok().map(Constant::Int),
(BiDiv, Constant::Int(l), Some(Constant::Int(r))) => (l / r).ok().map(Constant::Int),
(BiRem, Constant::Int(l), Some(Constant::Int(r))) => (l % r).ok().map(Constant::Int),
(BiAnd, Constant::Bool(false), _) => Some(Constant::Bool(false)),
(BiOr, Constant::Bool(true), _) => Some(Constant::Bool(true)),
2017-09-05 09:33:04 +00:00
(BiAnd, Constant::Bool(true), Some(r)) | (BiOr, Constant::Bool(false), Some(r)) => Some(r),
2016-03-16 11:38:26 +00:00
(BiBitXor, Constant::Bool(l), Some(Constant::Bool(r))) => Some(Constant::Bool(l ^ r)),
(BiBitXor, Constant::Int(l), Some(Constant::Int(r))) => (l ^ r).ok().map(Constant::Int),
(BiBitAnd, Constant::Bool(l), Some(Constant::Bool(r))) => Some(Constant::Bool(l & r)),
(BiBitAnd, Constant::Int(l), Some(Constant::Int(r))) => (l & r).ok().map(Constant::Int),
(BiBitOr, Constant::Bool(l), Some(Constant::Bool(r))) => Some(Constant::Bool(l | r)),
(BiBitOr, Constant::Int(l), Some(Constant::Int(r))) => (l | r).ok().map(Constant::Int),
(BiShl, Constant::Int(l), Some(Constant::Int(r))) => (l << r).ok().map(Constant::Int),
(BiShr, Constant::Int(l), Some(Constant::Int(r))) => (l >> r).ok().map(Constant::Int),
(BiEq, Constant::Int(l), Some(Constant::Int(r))) => Some(Constant::Bool(l == r)),
(BiNe, Constant::Int(l), Some(Constant::Int(r))) => Some(Constant::Bool(l != r)),
(BiLt, Constant::Int(l), Some(Constant::Int(r))) => Some(Constant::Bool(l < r)),
(BiLe, Constant::Int(l), Some(Constant::Int(r))) => Some(Constant::Bool(l <= r)),
(BiGe, Constant::Int(l), Some(Constant::Int(r))) => Some(Constant::Bool(l >= r)),
(BiGt, Constant::Int(l), Some(Constant::Int(r))) => Some(Constant::Bool(l > r)),
2016-01-04 04:26:12 +00:00
_ => None,
}
}
2016-02-12 17:35:44 +00:00
}