rust-clippy/tests/ui/clear_with_drain.fixed

110 lines
2.4 KiB
Rust
Raw Normal View History

2023-03-21 21:46:59 +00:00
// run-rustfix
#![allow(unused)]
#![warn(clippy::clear_with_drain)]
use std::collections::BinaryHeap;
use std::collections::HashMap;
use std::collections::HashSet;
use std::collections::VecDeque;
2023-03-21 21:46:59 +00:00
fn range() {
2023-03-23 21:29:30 +00:00
let mut v = vec![1, 2, 3];
let iter = v.drain(0..v.len()); // Yay
let mut v = vec![1, 2, 3];
let n = v.drain(0..v.len()).count(); // Yay
2023-03-26 16:59:20 +00:00
let mut v = vec![1, 2, 3];
let iter = v.drain(usize::MIN..v.len()); // Yay
let n = iter.count();
2023-03-26 16:59:20 +00:00
let mut v = vec![1, 2, 3];
v.clear(); // Nay
2023-03-23 21:29:30 +00:00
let mut v = vec![1, 2, 3];
2023-03-21 21:46:59 +00:00
v.clear(); // Nay
}
fn range_from() {
2023-03-23 21:29:30 +00:00
let mut v = vec![1, 2, 3];
let iter = v.drain(0..); // Yay
let mut v = vec![1, 2, 3];
let mut iter = v.drain(0..); // Yay
let next = iter.next();
2023-03-23 21:29:30 +00:00
let mut v = vec![1, 2, 3];
2023-03-26 16:59:20 +00:00
let next = v.drain(usize::MIN..).next(); // Yay
let mut v = vec![1, 2, 3];
v.clear(); // Nay
let mut v = vec![1, 2, 3];
2023-03-21 21:46:59 +00:00
v.clear(); // Nay
}
fn range_full() {
2023-03-23 21:29:30 +00:00
let mut v = vec![1, 2, 3];
let iter = v.drain(..); // Yay
let mut v = vec![1, 2, 3];
// Yay
for x in v.drain(..) {
let y = format!("x = {x}");
}
let mut v = vec![1, 2, 3];
2023-03-21 21:46:59 +00:00
v.clear(); // Nay
}
fn range_to() {
2023-03-23 21:29:30 +00:00
let mut v = vec![1, 2, 3];
let iter = v.drain(..v.len()); // Yay
let mut v = vec![1, 2, 3];
let iter = v.drain(..v.len()); // Yay
for x in iter {
2023-03-23 21:29:30 +00:00
let y = format!("x = {x}");
}
let mut v = vec![1, 2, 3];
2023-03-21 21:46:59 +00:00
v.clear(); // Nay
}
fn partial_drains() {
let mut v = vec![1, 2, 3];
v.drain(1..); // Yay
2023-03-23 21:29:30 +00:00
let mut v = vec![1, 2, 3];
v.drain(1..).max(); // Yay
2023-03-21 21:46:59 +00:00
let mut v = vec![1, 2, 3];
v.drain(..v.len() - 1); // Yay
2023-03-23 21:29:30 +00:00
let mut v = vec![1, 2, 3];
v.drain(..v.len() - 1).min(); // Yay
2023-03-21 21:46:59 +00:00
let mut v = vec![1, 2, 3];
v.drain(1..v.len() - 1); // Yay
2023-03-23 21:29:30 +00:00
let mut v = vec![1, 2, 3];
let w: Vec<i8> = v.drain(1..v.len() - 1).collect(); // Yay
2023-03-21 21:46:59 +00:00
}
fn main() {
let mut deque: VecDeque<_> = [1, 2, 3].into();
deque.clear();
let mut set = HashSet::from([1, 2, 3]);
set.clear();
let mut a = HashMap::new();
a.insert(1, "a");
a.insert(2, "b");
a.clear();
let mut heap = BinaryHeap::from([1, 3]);
heap.clear();
// Not firing for now because `String` is not reckognized by `is_type_diagnostic_item`
let mut s = String::from("α is alpha, β is beta");
s.drain(..);
}