rust-clippy/clippy_lints/src/ok_if_let.rs

76 lines
2.8 KiB
Rust
Raw Normal View History

2018-10-06 16:18:06 +00:00
// Copyright 2014-2018 The Rust Project Developers. See the COPYRIGHT
// file at the top-level directory of this distribution.
//
// Licensed under the Apache License, Version 2.0 <LICENSE-APACHE or
// http://www.apache.org/licenses/LICENSE-2.0> or the MIT license
// <LICENSE-MIT or http://opensource.org/licenses/MIT>, at your
// option. This file may not be copied, modified, or distributed
// except according to those terms.
2018-05-30 08:15:50 +00:00
use crate::utils::{match_type, method_chain_args, paths, snippet, span_help_and_lint};
2018-11-27 20:14:15 +00:00
use if_chain::if_chain;
use rustc::hir::*;
use rustc::lint::{LateContext, LateLintPass, LintArray, LintPass};
use rustc::{declare_tool_lint, lint_array};
2016-10-02 20:48:52 +00:00
/// **What it does:*** Checks for unnecessary `ok()` in if let.
///
2017-08-09 07:30:56 +00:00
/// **Why is this bad?** Calling `ok()` in if let is unnecessary, instead match
/// on `Ok(pat)`
2016-10-02 20:48:52 +00:00
///
/// **Known problems:** None.
///
/// **Example:**
2016-10-31 22:55:22 +00:00
/// ```rust
2016-10-02 20:48:52 +00:00
/// for result in iter {
/// if let Some(bench) = try!(result).parse().ok() {
/// vec.push(bench)
/// }
/// }
2016-12-20 17:21:30 +00:00
/// ```
2016-10-31 22:55:22 +00:00
/// Could be written:
///
/// ```rust
/// for result in iter {
/// if let Ok(bench) = try!(result).parse() {
/// vec.push(bench)
/// }
/// }
2016-10-02 20:48:52 +00:00
/// ```
2018-03-28 13:24:26 +00:00
declare_clippy_lint! {
2016-10-02 20:48:52 +00:00
pub IF_LET_SOME_RESULT,
2018-03-28 13:24:26 +00:00
style,
2016-10-02 21:15:24 +00:00
"usage of `ok()` in `if let Some(pat)` statements is unnecessary, match on `Ok(pat)` instead"
2016-10-02 20:48:52 +00:00
}
#[derive(Copy, Clone)]
2016-10-06 15:50:11 +00:00
pub struct Pass;
2016-10-02 20:48:52 +00:00
2016-10-06 15:50:11 +00:00
impl LintPass for Pass {
2016-10-02 20:48:52 +00:00
fn get_lints(&self) -> LintArray {
lint_array!(IF_LET_SOME_RESULT)
}
}
impl<'a, 'tcx> LateLintPass<'a, 'tcx> for Pass {
fn check_expr(&mut self, cx: &LateContext<'a, 'tcx>, expr: &'tcx Expr) {
if_chain! { //begin checking variables
2018-07-12 07:30:57 +00:00
if let ExprKind::Match(ref op, ref body, ref source) = expr.node; //test if expr is a match
if let MatchSource::IfLetDesugar { .. } = *source; //test if it is an If Let
2018-07-12 07:30:57 +00:00
if let ExprKind::MethodCall(_, _, ref result_types) = op.node; //check is expr.ok() has type Result<T,E>.ok()
if let PatKind::TupleStruct(QPath::Resolved(_, ref x), ref y, _) = body[0].pats[0].node; //get operation
if method_chain_args(op, &["ok"]).is_some(); //test to see if using ok() methoduse std::marker::Sized;
2017-11-04 19:55:56 +00:00
then {
let is_result_type = match_type(cx, cx.tables.expr_ty(&result_types[0]), &paths::RESULT);
let some_expr_string = snippet(cx, y[0].span, "");
if print::to_string(print::NO_ANN, |s| s.print_path(x, false)) == "Some" && is_result_type {
span_help_and_lint(cx, IF_LET_SOME_RESULT, expr.span,
"Matching on `Some` with `ok()` is redundant",
&format!("Consider matching on `Ok({})` and removing the call to `ok` instead", some_expr_string));
}
2016-10-02 20:48:52 +00:00
}
}
2016-10-02 20:48:52 +00:00
}
}