2019-01-13 10:44:45 +00:00
|
|
|
// run-rustfix
|
2020-04-06 22:46:40 +00:00
|
|
|
#![allow(clippy::assertions_on_constants)]
|
2019-01-13 10:44:45 +00:00
|
|
|
|
|
|
|
#[rustfmt::skip]
|
|
|
|
#[warn(clippy::collapsible_if)]
|
|
|
|
fn main() {
|
|
|
|
let x = "hello";
|
|
|
|
let y = "world";
|
|
|
|
if x == "hello" && y == "world" {
|
2020-02-04 15:13:06 +00:00
|
|
|
println!("Hello world!");
|
|
|
|
}
|
2019-01-13 10:44:45 +00:00
|
|
|
|
|
|
|
if (x == "hello" || x == "world") && (y == "world" || y == "hello") {
|
2020-02-04 15:13:06 +00:00
|
|
|
println!("Hello world!");
|
|
|
|
}
|
2019-01-13 10:44:45 +00:00
|
|
|
|
|
|
|
if x == "hello" && x == "world" && (y == "world" || y == "hello") {
|
2020-02-04 15:13:06 +00:00
|
|
|
println!("Hello world!");
|
|
|
|
}
|
2019-01-13 10:44:45 +00:00
|
|
|
|
|
|
|
if (x == "hello" || x == "world") && y == "world" && y == "hello" {
|
2020-02-04 15:13:06 +00:00
|
|
|
println!("Hello world!");
|
|
|
|
}
|
2019-01-13 10:44:45 +00:00
|
|
|
|
|
|
|
if x == "hello" && x == "world" && y == "world" && y == "hello" {
|
2020-02-04 15:13:06 +00:00
|
|
|
println!("Hello world!");
|
|
|
|
}
|
2019-01-13 10:44:45 +00:00
|
|
|
|
|
|
|
if 42 == 1337 && 'a' != 'A' {
|
2020-02-04 15:13:06 +00:00
|
|
|
println!("world!")
|
|
|
|
}
|
2019-01-13 10:44:45 +00:00
|
|
|
|
|
|
|
// Works because any if with an else statement cannot be collapsed.
|
|
|
|
if x == "hello" {
|
|
|
|
if y == "world" {
|
|
|
|
println!("Hello world!");
|
|
|
|
}
|
|
|
|
} else {
|
|
|
|
println!("Not Hello world");
|
|
|
|
}
|
|
|
|
|
|
|
|
if x == "hello" {
|
|
|
|
if y == "world" {
|
|
|
|
println!("Hello world!");
|
|
|
|
} else {
|
|
|
|
println!("Hello something else");
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
if x == "hello" {
|
|
|
|
print!("Hello ");
|
|
|
|
if y == "world" {
|
|
|
|
println!("world!")
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
if true {
|
|
|
|
} else {
|
|
|
|
assert!(true); // assert! is just an `if`
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
|
|
// The following tests check for the fix of https://github.com/rust-lang/rust-clippy/issues/798
|
|
|
|
if x == "hello" {// Not collapsible
|
|
|
|
if y == "world" {
|
|
|
|
println!("Hello world!");
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
if x == "hello" { // Not collapsible
|
|
|
|
if y == "world" {
|
|
|
|
println!("Hello world!");
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
if x == "hello" {
|
|
|
|
// Not collapsible
|
|
|
|
if y == "world" {
|
|
|
|
println!("Hello world!");
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
if x == "hello" && y == "world" { // Collapsible
|
2020-02-04 15:13:06 +00:00
|
|
|
println!("Hello world!");
|
|
|
|
}
|
2019-01-13 10:44:45 +00:00
|
|
|
|
|
|
|
if x == "hello" {
|
|
|
|
print!("Hello ");
|
|
|
|
} else {
|
|
|
|
// Not collapsible
|
|
|
|
if y == "world" {
|
|
|
|
println!("world!")
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
if x == "hello" {
|
|
|
|
print!("Hello ");
|
|
|
|
} else {
|
|
|
|
// Not collapsible
|
|
|
|
if let Some(42) = Some(42) {
|
|
|
|
println!("world!")
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
if x == "hello" {
|
|
|
|
/* Not collapsible */
|
|
|
|
if y == "world" {
|
|
|
|
println!("Hello world!");
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
if x == "hello" { /* Not collapsible */
|
|
|
|
if y == "world" {
|
|
|
|
println!("Hello world!");
|
|
|
|
}
|
|
|
|
}
|
2019-05-21 06:17:47 +00:00
|
|
|
|
|
|
|
// Test behavior wrt. `let_chains`.
|
|
|
|
// None of the cases below should be collapsed.
|
|
|
|
fn truth() -> bool { true }
|
|
|
|
|
|
|
|
// Prefix:
|
|
|
|
if let 0 = 1 {
|
|
|
|
if truth() {}
|
|
|
|
}
|
|
|
|
|
|
|
|
// Suffix:
|
|
|
|
if truth() {
|
|
|
|
if let 0 = 1 {}
|
|
|
|
}
|
|
|
|
|
|
|
|
// Midfix:
|
|
|
|
if truth() {
|
|
|
|
if let 0 = 1 {
|
|
|
|
if truth() {}
|
|
|
|
}
|
|
|
|
}
|
2019-01-13 10:44:45 +00:00
|
|
|
}
|