2021-03-25 18:29:11 +00:00
|
|
|
use clippy_utils::diagnostics::span_lint_and_sugg;
|
|
|
|
use clippy_utils::sugg::Sugg;
|
2021-09-08 14:31:47 +00:00
|
|
|
use clippy_utils::{
|
2021-12-17 12:40:22 +00:00
|
|
|
can_move_expr_to_closure, eager_or_lazy, higher, in_constant, is_else_clause, is_lang_ctor, peel_blocks,
|
|
|
|
peel_hir_expr_while, CaptureKind,
|
2021-09-08 14:31:47 +00:00
|
|
|
};
|
2020-07-14 12:59:59 +00:00
|
|
|
use if_chain::if_chain;
|
|
|
|
use rustc_errors::Applicability;
|
2022-08-31 13:24:45 +00:00
|
|
|
use rustc_hir::LangItem::{OptionNone, OptionSome, ResultErr, ResultOk};
|
|
|
|
use rustc_hir::{
|
|
|
|
def::Res, Arm, BindingAnnotation, Expr, ExprKind, MatchSource, Mutability, Pat, PatKind, Path, QPath, UnOp,
|
|
|
|
};
|
2020-07-14 12:59:59 +00:00
|
|
|
use rustc_lint::{LateContext, LateLintPass};
|
|
|
|
use rustc_session::{declare_lint_pass, declare_tool_lint};
|
|
|
|
|
|
|
|
declare_clippy_lint! {
|
2021-07-29 10:16:06 +00:00
|
|
|
/// ### What it does
|
2022-08-31 13:24:45 +00:00
|
|
|
/// Lints usage of `if let Some(v) = ... { y } else { x }` and
|
|
|
|
/// `match .. { Some(v) => y, None/_ => x }` which are more
|
2020-09-24 12:49:22 +00:00
|
|
|
/// idiomatically done with `Option::map_or` (if the else bit is a pure
|
|
|
|
/// expression) or `Option::map_or_else` (if the else bit is an impure
|
2020-10-23 20:16:59 +00:00
|
|
|
/// expression).
|
2020-07-14 12:59:59 +00:00
|
|
|
///
|
2021-07-29 10:16:06 +00:00
|
|
|
/// ### Why is this bad?
|
2021-11-04 12:52:36 +00:00
|
|
|
/// Using the dedicated functions of the `Option` type is clearer and
|
2020-10-23 20:16:59 +00:00
|
|
|
/// more concise than an `if let` expression.
|
2020-07-14 12:59:59 +00:00
|
|
|
///
|
2021-07-29 10:16:06 +00:00
|
|
|
/// ### Known problems
|
2020-09-24 12:49:22 +00:00
|
|
|
/// This lint uses a deliberately conservative metric for checking
|
2020-07-14 12:59:59 +00:00
|
|
|
/// if the inside of either body contains breaks or continues which will
|
|
|
|
/// cause it to not suggest a fix if either block contains a loop with
|
|
|
|
/// continues or breaks contained within the loop.
|
|
|
|
///
|
2021-07-29 10:16:06 +00:00
|
|
|
/// ### Example
|
2020-07-14 12:59:59 +00:00
|
|
|
/// ```rust
|
|
|
|
/// # let optional: Option<u32> = Some(0);
|
|
|
|
/// # fn do_complicated_function() -> u32 { 5 };
|
|
|
|
/// let _ = if let Some(foo) = optional {
|
|
|
|
/// foo
|
|
|
|
/// } else {
|
|
|
|
/// 5
|
|
|
|
/// };
|
2022-08-31 13:24:45 +00:00
|
|
|
/// let _ = match optional {
|
|
|
|
/// Some(val) => val + 1,
|
|
|
|
/// None => 5
|
|
|
|
/// };
|
2020-07-14 12:59:59 +00:00
|
|
|
/// let _ = if let Some(foo) = optional {
|
|
|
|
/// foo
|
|
|
|
/// } else {
|
|
|
|
/// let y = do_complicated_function();
|
|
|
|
/// y*y
|
|
|
|
/// };
|
|
|
|
/// ```
|
|
|
|
///
|
|
|
|
/// should be
|
|
|
|
///
|
|
|
|
/// ```rust
|
|
|
|
/// # let optional: Option<u32> = Some(0);
|
|
|
|
/// # fn do_complicated_function() -> u32 { 5 };
|
|
|
|
/// let _ = optional.map_or(5, |foo| foo);
|
2022-08-31 13:24:45 +00:00
|
|
|
/// let _ = optional.map_or(5, |val| val + 1);
|
2020-07-14 12:59:59 +00:00
|
|
|
/// let _ = optional.map_or_else(||{
|
|
|
|
/// let y = do_complicated_function();
|
|
|
|
/// y*y
|
|
|
|
/// }, |foo| foo);
|
|
|
|
/// ```
|
2022-08-31 13:24:45 +00:00
|
|
|
// FIXME: Before moving this lint out of nursery, the lint name needs to be updated. It now also
|
|
|
|
// covers matches and `Result`.
|
2021-12-06 11:33:31 +00:00
|
|
|
#[clippy::version = "1.47.0"]
|
2020-07-14 12:59:59 +00:00
|
|
|
pub OPTION_IF_LET_ELSE,
|
2021-09-08 14:31:47 +00:00
|
|
|
nursery,
|
2020-07-14 12:59:59 +00:00
|
|
|
"reimplementation of Option::map_or"
|
|
|
|
}
|
|
|
|
|
|
|
|
declare_lint_pass!(OptionIfLetElse => [OPTION_IF_LET_ELSE]);
|
|
|
|
|
2022-08-31 13:24:45 +00:00
|
|
|
/// A struct containing information about occurrences of construct that this lint detects
|
|
|
|
///
|
|
|
|
/// Such as:
|
|
|
|
///
|
|
|
|
/// ```ignore
|
|
|
|
/// if let Some(..) = {..} else {..}
|
|
|
|
/// ```
|
|
|
|
/// or
|
|
|
|
/// ```ignore
|
|
|
|
/// match x {
|
|
|
|
/// Some(..) => {..},
|
|
|
|
/// None/_ => {..}
|
|
|
|
/// }
|
|
|
|
/// ```
|
|
|
|
struct OptionOccurence {
|
2020-07-14 12:59:59 +00:00
|
|
|
option: String,
|
|
|
|
method_sugg: String,
|
|
|
|
some_expr: String,
|
|
|
|
none_expr: String,
|
|
|
|
}
|
|
|
|
|
|
|
|
fn format_option_in_sugg(cx: &LateContext<'_>, cond_expr: &Expr<'_>, as_ref: bool, as_mut: bool) -> String {
|
|
|
|
format!(
|
|
|
|
"{}{}",
|
2021-12-06 11:33:31 +00:00
|
|
|
Sugg::hir_with_macro_callsite(cx, cond_expr, "..").maybe_par(),
|
2020-07-14 12:59:59 +00:00
|
|
|
if as_mut {
|
|
|
|
".as_mut()"
|
|
|
|
} else if as_ref {
|
|
|
|
".as_ref()"
|
|
|
|
} else {
|
|
|
|
""
|
|
|
|
}
|
|
|
|
)
|
|
|
|
}
|
|
|
|
|
2022-08-31 13:24:45 +00:00
|
|
|
fn try_get_option_occurence<'tcx>(
|
|
|
|
cx: &LateContext<'tcx>,
|
|
|
|
pat: &Pat<'tcx>,
|
|
|
|
expr: &Expr<'_>,
|
|
|
|
if_then: &'tcx Expr<'_>,
|
|
|
|
if_else: &'tcx Expr<'_>,
|
|
|
|
) -> Option<OptionOccurence> {
|
|
|
|
let cond_expr = match expr.kind {
|
|
|
|
ExprKind::Unary(UnOp::Deref, inner_expr) | ExprKind::AddrOf(_, _, inner_expr) => inner_expr,
|
|
|
|
_ => expr,
|
|
|
|
};
|
|
|
|
let inner_pat = try_get_inner_pat(cx, pat)?;
|
2020-07-14 12:59:59 +00:00
|
|
|
if_chain! {
|
2022-08-31 13:24:45 +00:00
|
|
|
if let PatKind::Binding(bind_annotation, _, id, None) = inner_pat.kind;
|
2021-09-08 14:31:47 +00:00
|
|
|
if let Some(some_captures) = can_move_expr_to_closure(cx, if_then);
|
|
|
|
if let Some(none_captures) = can_move_expr_to_closure(cx, if_else);
|
|
|
|
if some_captures
|
|
|
|
.iter()
|
|
|
|
.filter_map(|(id, &c)| none_captures.get(id).map(|&c2| (c, c2)))
|
|
|
|
.all(|(x, y)| x.is_imm_ref() && y.is_imm_ref());
|
2020-07-14 12:59:59 +00:00
|
|
|
then {
|
2022-08-30 22:36:53 +00:00
|
|
|
let capture_mut = if bind_annotation == BindingAnnotation::MUT { "mut " } else { "" };
|
2021-12-17 12:40:22 +00:00
|
|
|
let some_body = peel_blocks(if_then);
|
|
|
|
let none_body = peel_blocks(if_else);
|
2021-12-06 11:33:31 +00:00
|
|
|
let method_sugg = if eager_or_lazy::switch_to_eager_eval(cx, none_body) { "map_or" } else { "map_or_else" };
|
2020-07-14 12:59:59 +00:00
|
|
|
let capture_name = id.name.to_ident_string();
|
2022-08-31 13:24:45 +00:00
|
|
|
let (as_ref, as_mut) = match &expr.kind {
|
2020-07-14 12:59:59 +00:00
|
|
|
ExprKind::AddrOf(_, Mutability::Not, _) => (true, false),
|
|
|
|
ExprKind::AddrOf(_, Mutability::Mut, _) => (false, true),
|
2022-08-30 22:36:53 +00:00
|
|
|
_ => (bind_annotation == BindingAnnotation::REF, bind_annotation == BindingAnnotation::REF_MUT),
|
2020-07-14 12:59:59 +00:00
|
|
|
};
|
2022-08-31 13:24:45 +00:00
|
|
|
|
2021-09-08 14:31:47 +00:00
|
|
|
// Check if captures the closure will need conflict with borrows made in the scrutinee.
|
|
|
|
// TODO: check all the references made in the scrutinee expression. This will require interacting
|
|
|
|
// with the borrow checker. Currently only `<local>[.<field>]*` is checked for.
|
|
|
|
if as_ref || as_mut {
|
|
|
|
let e = peel_hir_expr_while(cond_expr, |e| match e.kind {
|
|
|
|
ExprKind::Field(e, _) | ExprKind::AddrOf(_, _, e) => Some(e),
|
|
|
|
_ => None,
|
|
|
|
});
|
|
|
|
if let ExprKind::Path(QPath::Resolved(None, Path { res: Res::Local(local_id), .. })) = e.kind {
|
|
|
|
match some_captures.get(local_id)
|
2022-07-18 07:39:37 +00:00
|
|
|
.or_else(|| (method_sugg == "map_or_else").then_some(()).and_then(|_| none_captures.get(local_id)))
|
2021-09-08 14:31:47 +00:00
|
|
|
{
|
|
|
|
Some(CaptureKind::Value | CaptureKind::Ref(Mutability::Mut)) => return None,
|
|
|
|
Some(CaptureKind::Ref(Mutability::Not)) if as_mut => return None,
|
|
|
|
Some(CaptureKind::Ref(Mutability::Not)) | None => (),
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
2022-08-31 13:24:45 +00:00
|
|
|
|
|
|
|
return Some(OptionOccurence {
|
2020-07-14 12:59:59 +00:00
|
|
|
option: format_option_in_sugg(cx, cond_expr, as_ref, as_mut),
|
|
|
|
method_sugg: method_sugg.to_string(),
|
2022-09-23 17:42:59 +00:00
|
|
|
some_expr: format!("|{capture_mut}{capture_name}| {}", Sugg::hir_with_macro_callsite(cx, some_body, "..")),
|
2021-12-06 11:33:31 +00:00
|
|
|
none_expr: format!("{}{}", if method_sugg == "map_or" { "" } else { "|| " }, Sugg::hir_with_macro_callsite(cx, none_body, "..")),
|
2022-08-31 13:24:45 +00:00
|
|
|
});
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
None
|
|
|
|
}
|
|
|
|
|
|
|
|
fn try_get_inner_pat<'tcx>(cx: &LateContext<'tcx>, pat: &Pat<'tcx>) -> Option<&'tcx Pat<'tcx>> {
|
|
|
|
if let PatKind::TupleStruct(ref qpath, [inner_pat], ..) = pat.kind {
|
|
|
|
if is_lang_ctor(cx, qpath, OptionSome) || is_lang_ctor(cx, qpath, ResultOk) {
|
|
|
|
return Some(inner_pat);
|
|
|
|
}
|
|
|
|
}
|
|
|
|
None
|
|
|
|
}
|
|
|
|
|
|
|
|
/// If this expression is the option if let/else construct we're detecting, then
|
|
|
|
/// this function returns an `OptionOccurence` struct with details if
|
|
|
|
/// this construct is found, or None if this construct is not found.
|
|
|
|
fn detect_option_if_let_else<'tcx>(cx: &LateContext<'tcx>, expr: &Expr<'tcx>) -> Option<OptionOccurence> {
|
|
|
|
if let Some(higher::IfLet {
|
|
|
|
let_pat,
|
|
|
|
let_expr,
|
|
|
|
if_then,
|
|
|
|
if_else: Some(if_else),
|
|
|
|
}) = higher::IfLet::hir(cx, expr)
|
|
|
|
{
|
|
|
|
if !is_else_clause(cx.tcx, expr) {
|
|
|
|
return try_get_option_occurence(cx, let_pat, let_expr, if_then, if_else);
|
|
|
|
}
|
|
|
|
}
|
|
|
|
None
|
|
|
|
}
|
|
|
|
|
|
|
|
fn detect_option_match<'tcx>(cx: &LateContext<'tcx>, expr: &Expr<'tcx>) -> Option<OptionOccurence> {
|
|
|
|
if let ExprKind::Match(ex, arms, MatchSource::Normal) = expr.kind {
|
|
|
|
if let Some((let_pat, if_then, if_else)) = try_convert_match(cx, arms) {
|
|
|
|
return try_get_option_occurence(cx, let_pat, ex, if_then, if_else);
|
|
|
|
}
|
|
|
|
}
|
|
|
|
None
|
|
|
|
}
|
|
|
|
|
|
|
|
fn try_convert_match<'tcx>(
|
|
|
|
cx: &LateContext<'tcx>,
|
|
|
|
arms: &[Arm<'tcx>],
|
|
|
|
) -> Option<(&'tcx Pat<'tcx>, &'tcx Expr<'tcx>, &'tcx Expr<'tcx>)> {
|
|
|
|
if arms.len() == 2 {
|
|
|
|
return if is_none_or_err_arm(cx, &arms[1]) {
|
|
|
|
Some((arms[0].pat, arms[0].body, arms[1].body))
|
|
|
|
} else if is_none_or_err_arm(cx, &arms[0]) {
|
|
|
|
Some((arms[1].pat, arms[1].body, arms[0].body))
|
2020-07-14 12:59:59 +00:00
|
|
|
} else {
|
|
|
|
None
|
2022-08-31 13:24:45 +00:00
|
|
|
};
|
|
|
|
}
|
|
|
|
None
|
|
|
|
}
|
|
|
|
|
|
|
|
fn is_none_or_err_arm(cx: &LateContext<'_>, arm: &Arm<'_>) -> bool {
|
|
|
|
match arm.pat.kind {
|
|
|
|
PatKind::Path(ref qpath) => is_lang_ctor(cx, qpath, OptionNone),
|
|
|
|
PatKind::TupleStruct(ref qpath, [first_pat], _) => {
|
|
|
|
is_lang_ctor(cx, qpath, ResultErr) && matches!(first_pat.kind, PatKind::Wild)
|
|
|
|
},
|
|
|
|
PatKind::Wild => true,
|
|
|
|
_ => false,
|
2020-07-14 12:59:59 +00:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2020-09-24 12:49:22 +00:00
|
|
|
impl<'tcx> LateLintPass<'tcx> for OptionIfLetElse {
|
|
|
|
fn check_expr(&mut self, cx: &LateContext<'tcx>, expr: &Expr<'tcx>) {
|
2022-08-31 13:24:45 +00:00
|
|
|
// Don't lint macros and constants
|
|
|
|
if expr.span.from_expansion() || in_constant(cx, expr.hir_id) {
|
|
|
|
return;
|
|
|
|
}
|
|
|
|
|
|
|
|
let detection = detect_option_if_let_else(cx, expr).or_else(|| detect_option_match(cx, expr));
|
|
|
|
if let Some(det) = detection {
|
2020-07-14 12:59:59 +00:00
|
|
|
span_lint_and_sugg(
|
|
|
|
cx,
|
|
|
|
OPTION_IF_LET_ELSE,
|
|
|
|
expr.span,
|
2022-08-31 13:24:45 +00:00
|
|
|
format!("use Option::{} instead of an if let/else", det.method_sugg).as_str(),
|
2020-07-14 12:59:59 +00:00
|
|
|
"try",
|
|
|
|
format!(
|
2021-05-20 10:30:31 +00:00
|
|
|
"{}.{}({}, {})",
|
2022-08-31 13:24:45 +00:00
|
|
|
det.option, det.method_sugg, det.none_expr, det.some_expr
|
2020-07-14 12:59:59 +00:00
|
|
|
),
|
|
|
|
Applicability::MaybeIncorrect,
|
|
|
|
);
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|