2018-07-05 10:37:50 +00:00
# Clippy
2016-05-06 14:07:47 +00:00
2020-02-12 11:13:59 +00:00
[![Clippy Test ](https://github.com/rust-lang/rust-clippy/workflows/Clippy%20Test/badge.svg?branch=auto&event=push )](https://github.com/rust-lang/rust-clippy/actions?query=workflow%3A%22Clippy+Test%22+event%3Apush+branch%3Aauto)
2019-10-04 15:39:23 +00:00
[![License: MIT OR Apache-2.0 ](https://img.shields.io/crates/l/clippy.svg )](#license)
2014-11-19 07:50:46 +00:00
2017-10-14 19:47:38 +00:00
A collection of lints to catch common mistakes and improve your [Rust ](https://github.com/rust-lang/rust ) code.
2014-11-19 19:19:03 +00:00
2020-09-24 20:52:25 +00:00
[There are over 400 lints included in this crate! ](https://rust-lang.github.io/rust-clippy/master/index.html )
2017-09-01 18:29:36 +00:00
2018-07-05 10:37:50 +00:00
We have a bunch of lint categories to allow you to choose how much Clippy is supposed to ~~annoy~~ help you:
2018-03-29 11:04:52 +00:00
2019-02-22 07:56:49 +00:00
* `clippy::all` (everything that is on by default: all the categories below except for `nursery` , `pedantic` , and `cargo` )
2019-04-04 09:28:11 +00:00
* `clippy::correctness` (code that is just **outright wrong** or **very very useless** , causes hard errors by default)
2018-07-28 15:35:24 +00:00
* `clippy::style` (code that should be written in a more idiomatic way)
* `clippy::complexity` (code that does something simple but in a complex way)
* `clippy::perf` (code that can be written in a faster way)
2019-02-22 07:56:49 +00:00
* `clippy::pedantic` (lints which are rather strict, off by default)
* `clippy::nursery` (new lints that aren't quite ready yet, off by default)
* `clippy::cargo` (checks against the cargo manifest, off by default)
2018-03-29 11:04:52 +00:00
2018-11-22 03:40:09 +00:00
More to come, please [file an issue ](https://github.com/rust-lang/rust-clippy/issues ) if you have ideas!
2017-09-01 18:29:36 +00:00
2018-10-12 10:15:20 +00:00
Only the following of those categories are enabled by default:
* `clippy::style`
* `clippy::correctness`
* `clippy::complexity`
* `clippy::perf`
Other categories need to be enabled in order for their lints to be executed.
2020-01-21 15:39:58 +00:00
The [lint list ](https://rust-lang.github.io/rust-clippy/master/index.html ) also contains "restriction lints", which are
for things which are usually not considered "bad", but may be useful to turn on in specific cases. These should be used
very selectively, if at all.
2019-02-22 07:56:49 +00:00
2016-02-22 14:50:40 +00:00
Table of contents:
2016-03-10 20:42:24 +00:00
2016-05-06 14:07:47 +00:00
* [Usage instructions ](#usage )
* [Configuration ](#configuration )
2019-08-06 20:09:26 +00:00
* [Contributing ](#contributing )
2016-05-06 14:07:47 +00:00
* [License ](#license )
2016-09-15 15:19:30 +00:00
## Usage
2020-07-22 16:07:33 +00:00
Below are instructions on how to use Clippy as a subcommand, compiled from source
or in Travis CI.
2016-11-19 03:46:12 +00:00
2018-07-16 20:05:02 +00:00
### As a cargo subcommand (`cargo clippy`)
2016-09-15 15:19:30 +00:00
2018-07-16 20:05:02 +00:00
One way to use Clippy is by installing Clippy through rustup as a cargo
subcommand.
2018-04-02 09:13:02 +00:00
2018-07-16 20:05:02 +00:00
#### Step 1: Install rustup
2018-04-02 09:13:02 +00:00
2019-08-06 20:09:26 +00:00
You can install [rustup ](https://rustup.rs/ ) on supported platforms. This will help
2018-09-11 18:29:00 +00:00
us install Clippy and its dependencies.
2017-12-27 16:06:40 +00:00
2018-07-16 20:05:02 +00:00
If you already have rustup installed, update to ensure you have the latest
rustup and compiler:
2017-12-27 16:06:40 +00:00
```terminal
2018-07-16 20:05:02 +00:00
rustup update
2017-12-27 16:06:40 +00:00
```
2018-09-11 18:29:00 +00:00
#### Step 2: Install Clippy
2018-01-12 10:33:13 +00:00
2018-09-11 18:29:00 +00:00
Once you have rustup and the latest stable release (at least Rust 1.29) installed, run the following command:
2018-04-02 09:13:02 +00:00
```terminal
2018-12-06 16:11:50 +00:00
rustup component add clippy
2018-04-02 09:13:02 +00:00
```
2019-01-13 01:24:52 +00:00
If it says that it can't find the `clippy` component, please run `rustup self update` .
2018-04-02 09:13:02 +00:00
2019-01-13 00:42:36 +00:00
#### Step 3: Run Clippy
2018-07-16 20:05:02 +00:00
2019-01-13 00:42:36 +00:00
Now you can run Clippy by invoking the following command:
```terminal
cargo clippy
```
2018-09-22 21:35:11 +00:00
2019-08-07 19:07:35 +00:00
#### Automatically applying Clippy suggestions
2019-08-07 14:24:14 +00:00
2020-04-16 19:35:19 +00:00
Clippy can automatically apply some lint suggestions.
2019-08-07 14:24:14 +00:00
Note that this is still experimental and only supported on the nightly channel:
```terminal
2020-04-16 19:35:19 +00:00
cargo clippy --fix -Z unstable-options
2019-08-07 14:24:14 +00:00
```
2018-07-05 10:37:50 +00:00
### Running Clippy from the command line without installing it
2016-09-15 15:19:30 +00:00
2018-07-05 10:37:50 +00:00
To have cargo compile your crate with Clippy without Clippy installation
2016-09-15 15:19:30 +00:00
in your code, you can use:
```terminal
2018-12-29 05:59:33 +00:00
cargo run --bin cargo-clippy --manifest-path=path_to_clippys_Cargo.toml
2016-09-15 15:19:30 +00:00
```
2019-08-06 20:09:26 +00:00
*Note:* Be sure that Clippy was compiled with the same version of rustc that cargo invokes here!
2016-09-15 15:19:30 +00:00
2018-09-14 06:21:14 +00:00
### Travis CI
You can add Clippy to Travis CI in the same way you use it locally:
```yml
2018-09-25 13:40:17 +00:00
language: rust
rust:
- stable
- beta
before_script:
2018-12-06 16:11:50 +00:00
- rustup component add clippy
2018-09-25 13:40:17 +00:00
script:
- cargo clippy
# if you want the build job to fail when encountering warnings, use
- cargo clippy -- -D warnings
2019-03-03 08:48:42 +00:00
# in order to also check tests and non-default crate features, use
2018-09-25 13:40:17 +00:00
- cargo clippy --all-targets --all-features -- -D warnings
- cargo test
# etc.
2018-09-14 06:21:14 +00:00
```
2019-03-03 08:48:42 +00:00
If you are on nightly, It might happen that Clippy is not available for a certain nightly release.
2019-08-06 20:09:26 +00:00
In this case you can try to conditionally install Clippy from the Git repo.
2018-11-04 23:12:42 +00:00
```yaml
language: rust
rust:
- nightly
before_script:
2018-12-06 16:11:50 +00:00
- rustup component add clippy --toolchain=nightly || cargo install --git https://github.com/rust-lang/rust-clippy/ --force clippy
2019-08-06 20:09:26 +00:00
# etc.
2018-11-04 23:12:42 +00:00
```
2019-04-08 17:51:54 +00:00
Note that adding `-D warnings` will cause your build to fail if **any** warnings are found in your code.
That includes warnings found by rustc (e.g. `dead_code` , etc.). If you want to avoid this and only cause
2019-08-06 20:09:26 +00:00
an error for Clippy warnings, use `#![deny(clippy::all)]` in your code or `-D clippy::all` on the command
2019-04-11 02:17:17 +00:00
line. (You can swap `clippy::all` with the specific lint category you are targeting.)
2019-04-08 17:51:54 +00:00
2016-09-15 15:19:30 +00:00
## Configuration
2020-01-21 15:39:58 +00:00
Some lints can be configured in a TOML file named `clippy.toml` or `.clippy.toml` . It contains a basic `variable =
value` mapping eg.
2016-09-15 15:19:30 +00:00
```toml
blacklisted-names = ["toto", "tata", "titi"]
2019-02-23 01:19:50 +00:00
cognitive-complexity-threshold = 30
2016-09-15 15:19:30 +00:00
```
2020-01-21 15:39:58 +00:00
See the [list of lints ](https://rust-lang.github.io/rust-clippy/master/index.html ) for more information about which
lints can be configured and the meaning of the variables.
2016-09-15 15:19:30 +00:00
2018-01-07 11:50:42 +00:00
To deactivate the “for further information visit *lint-link* ” message you can
2017-09-01 08:29:49 +00:00
define the `CLIPPY_DISABLE_DOCS_LINKS` environment variable.
2016-09-15 15:19:30 +00:00
### Allowing/denying lints
2018-09-13 09:27:01 +00:00
You can add options to your code to `allow` /`warn`/`deny` Clippy lints:
2016-09-15 15:19:30 +00:00
2018-07-28 15:35:24 +00:00
* the whole set of `Warn` lints using the `clippy` lint group (`#![deny(clippy::all)]`)
2016-09-15 15:19:30 +00:00
2018-07-28 15:35:24 +00:00
* all lints using both the `clippy` and `clippy::pedantic` lint groups (`#![deny(clippy::all)]`,
`#![deny(clippy::pedantic)]` ). Note that `clippy::pedantic` contains some very aggressive
2016-09-15 15:19:30 +00:00
lints prone to false positives.
2019-08-06 20:09:26 +00:00
* only some lints (`#![deny(clippy::single_match, clippy::box_vec)]`, etc.)
2016-09-15 15:19:30 +00:00
2019-08-06 20:09:26 +00:00
* `allow` /`warn`/`deny` can be limited to a single function or module using `#[allow(...)]` , etc.
2016-09-15 15:19:30 +00:00
Note: `deny` produces errors instead of warnings.
2020-10-14 09:58:22 +00:00
If you do not want to include your lint levels in your code, you can globally enable/disable lints
by passing extra flags to Clippy during the run:
To disable `lint_name` , run
```terminal
cargo clippy -- -A clippy::lint_name
```
And to enable `lint_name` , run
```terminal
cargo clippy -- -W clippy::lint_name
```
This also works with lint groups. For example you
can run Clippy with warnings for all lints enabled:
```terminal
cargo clippy -- -W clippy::pedantic
```
2020-03-29 14:57:09 +00:00
If you care only about a single lint, you can allow all others and then explicitly reenable
2020-10-14 09:58:22 +00:00
the lint(s) you are interested in:
```terminal
cargo clippy -- -A clippy::all -W clippy::useless_format -W clippy::...
```
Note that if you've run clippy before, this may only take effect after you've modified a file or ran `cargo clean` .
2018-10-02 08:39:51 +00:00
2018-12-22 09:16:52 +00:00
## Contributing
If you want to contribute to Clippy, you can find more information in [CONTRIBUTING.md ](https://github.com/rust-lang/rust-clippy/blob/master/CONTRIBUTING.md ).
2018-12-21 07:11:06 +00:00
2016-05-06 14:07:47 +00:00
## License
2020-02-20 11:05:34 +00:00
Copyright 2014-2020 The Rust Project Developers
2018-10-07 02:29:01 +00:00
Licensed under the Apache License, Version 2.0 < LICENSE-APACHE or
2019-08-09 02:59:22 +00:00
[https://www.apache.org/licenses/LICENSE-2.0 ](https://www.apache.org/licenses/LICENSE-2.0 )> or the MIT license
< LICENSE-MIT or [https://opensource.org/licenses/MIT ](https://opensource.org/licenses/MIT )> , at your
2019-12-20 08:57:02 +00:00
option. Files in the project may not be
2018-10-07 02:29:01 +00:00
copied, modified, or distributed except according to those terms.