rust-clippy/tests/ui/needless_bool.rs

52 lines
1.3 KiB
Rust
Raw Normal View History

2018-07-28 15:34:52 +00:00
#![feature(tool_lints)]
2017-09-18 10:47:33 +00:00
2018-07-28 15:34:52 +00:00
#![warn(clippy::needless_bool)]
2017-09-18 10:47:33 +00:00
2018-07-28 15:34:52 +00:00
#[allow(clippy::if_same_then_else)]
fn main() {
let x = true;
2016-07-03 23:17:31 +00:00
let y = false;
2017-02-08 13:58:07 +00:00
if x { true } else { true };
if x { false } else { false };
2016-03-14 16:13:10 +00:00
if x { true } else { false };
if x { false } else { true };
2016-07-03 23:17:31 +00:00
if x && y { false } else { true };
if x { x } else { false }; // would also be questionable, but we don't catch this yet
bool_ret(x);
bool_ret2(x);
bool_ret3(x);
2016-07-03 23:17:31 +00:00
bool_ret5(x, x);
bool_ret4(x);
2016-07-03 23:17:31 +00:00
bool_ret6(x, x);
}
2018-07-28 15:34:52 +00:00
#[allow(clippy::if_same_then_else, clippy::needless_return)]
fn bool_ret(x: bool) -> bool {
if x { return true } else { return true };
}
2018-07-28 15:34:52 +00:00
#[allow(clippy::if_same_then_else, clippy::needless_return)]
fn bool_ret2(x: bool) -> bool {
if x { return false } else { return false };
}
2018-07-28 15:34:52 +00:00
#[allow(clippy::needless_return)]
fn bool_ret3(x: bool) -> bool {
2016-03-14 16:13:10 +00:00
if x { return true } else { return false };
2016-07-03 23:17:31 +00:00
}
2018-07-28 15:34:52 +00:00
#[allow(clippy::needless_return)]
2016-07-03 23:17:31 +00:00
fn bool_ret5(x: bool, y: bool) -> bool {
if x && y { return true } else { return false };
}
2018-07-28 15:34:52 +00:00
#[allow(clippy::needless_return)]
fn bool_ret4(x: bool) -> bool {
2016-03-14 16:13:10 +00:00
if x { return false } else { return true };
2016-07-03 23:17:31 +00:00
}
2018-07-28 15:34:52 +00:00
#[allow(clippy::needless_return)]
2016-07-03 23:17:31 +00:00
fn bool_ret6(x: bool, y: bool) -> bool {
if x && y { return false } else { return true };
}