rust-clippy/clippy_lints/src/integer_division.rs

60 lines
1.7 KiB
Rust
Raw Normal View History

use crate::utils::span_lint_and_help;
2019-06-11 16:53:12 +00:00
use if_chain::if_chain;
2020-01-06 16:39:50 +00:00
use rustc_hir as hir;
2020-01-12 06:08:41 +00:00
use rustc_lint::{LateContext, LateLintPass};
2020-01-11 11:37:08 +00:00
use rustc_session::{declare_lint_pass, declare_tool_lint};
2019-06-11 16:53:12 +00:00
declare_clippy_lint! {
/// **What it does:** Checks for division of integers
///
/// **Why is this bad?** When outside of some very specific algorithms,
/// integer division is very often a mistake because it discards the
/// remainder.
///
/// **Known problems:** None.
///
/// **Example:**
/// ```rust
/// // Bad
/// let x = 3 / 2;
/// println!("{}", x);
///
/// // Good
/// let x = 3f32 / 2f32;
/// println!("{}", x);
2019-06-11 16:53:12 +00:00
/// ```
pub INTEGER_DIVISION,
restriction,
2019-06-11 16:53:12 +00:00
"integer division may cause loss of precision"
}
declare_lint_pass!(IntegerDivision => [INTEGER_DIVISION]);
impl<'a, 'tcx> LateLintPass<'a, 'tcx> for IntegerDivision {
2019-12-27 07:12:26 +00:00
fn check_expr(&mut self, cx: &LateContext<'a, 'tcx>, expr: &'tcx hir::Expr<'_>) {
2019-06-11 16:53:12 +00:00
if is_integer_division(cx, expr) {
span_lint_and_help(
2019-06-11 16:53:12 +00:00
cx,
INTEGER_DIVISION,
expr.span,
"integer division",
None,
2019-06-11 16:53:12 +00:00
"division of integers may cause loss of precision. consider using floats.",
);
}
}
}
2019-12-27 07:12:26 +00:00
fn is_integer_division<'a, 'tcx>(cx: &LateContext<'a, 'tcx>, expr: &'tcx hir::Expr<'_>) -> bool {
2019-06-11 16:53:12 +00:00
if_chain! {
2019-09-27 15:16:06 +00:00
if let hir::ExprKind::Binary(binop, left, right) = &expr.kind;
2019-06-11 16:53:12 +00:00
if let hir::BinOpKind::Div = &binop.node;
then {
let (left_ty, right_ty) = (cx.tables.expr_ty(left), cx.tables.expr_ty(right));
return left_ty.is_integral() && right_ty.is_integral();
}
}
false
}