2017-02-07 20:05:30 +00:00
|
|
|
error: this if-then-else expression returns a bool literal
|
2023-06-10 11:43:30 +00:00
|
|
|
--> $DIR/fixable.rs:42:5
|
2017-02-07 20:05:30 +00:00
|
|
|
|
|
2018-12-27 15:57:55 +00:00
|
|
|
LL | / if x {
|
|
|
|
LL | | true
|
|
|
|
LL | | } else {
|
|
|
|
LL | | false
|
|
|
|
LL | | };
|
2018-12-10 05:27:19 +00:00
|
|
|
| |_____^ help: you can reduce it to: `x`
|
2019-08-05 20:05:05 +00:00
|
|
|
|
|
|
|
|
= note: `-D clippy::needless-bool` implied by `-D warnings`
|
2017-02-07 20:05:30 +00:00
|
|
|
|
|
|
|
error: this if-then-else expression returns a bool literal
|
2023-06-10 11:43:30 +00:00
|
|
|
--> $DIR/fixable.rs:47:5
|
2017-02-07 20:05:30 +00:00
|
|
|
|
|
2018-12-27 15:57:55 +00:00
|
|
|
LL | / if x {
|
|
|
|
LL | | false
|
|
|
|
LL | | } else {
|
|
|
|
LL | | true
|
|
|
|
LL | | };
|
2018-12-10 05:27:19 +00:00
|
|
|
| |_____^ help: you can reduce it to: `!x`
|
2017-02-07 20:05:30 +00:00
|
|
|
|
|
|
|
error: this if-then-else expression returns a bool literal
|
2023-06-10 11:43:30 +00:00
|
|
|
--> $DIR/fixable.rs:52:5
|
2017-02-07 20:05:30 +00:00
|
|
|
|
|
2018-12-27 15:57:55 +00:00
|
|
|
LL | / if x && y {
|
|
|
|
LL | | false
|
|
|
|
LL | | } else {
|
|
|
|
LL | | true
|
|
|
|
LL | | };
|
2018-12-10 05:27:19 +00:00
|
|
|
| |_____^ help: you can reduce it to: `!(x && y)`
|
2017-02-07 20:05:30 +00:00
|
|
|
|
2019-08-05 20:05:05 +00:00
|
|
|
error: this if-then-else expression returns a bool literal
|
2023-06-10 11:43:30 +00:00
|
|
|
--> $DIR/fixable.rs:60:5
|
2021-12-14 12:27:55 +00:00
|
|
|
|
|
|
|
|
LL | / if a == b {
|
|
|
|
LL | | false
|
|
|
|
LL | | } else {
|
|
|
|
LL | | true
|
|
|
|
LL | | };
|
|
|
|
| |_____^ help: you can reduce it to: `a != b`
|
|
|
|
|
|
|
|
error: this if-then-else expression returns a bool literal
|
2023-06-10 11:43:30 +00:00
|
|
|
--> $DIR/fixable.rs:65:5
|
2021-12-14 12:27:55 +00:00
|
|
|
|
|
|
|
|
LL | / if a != b {
|
|
|
|
LL | | false
|
|
|
|
LL | | } else {
|
|
|
|
LL | | true
|
|
|
|
LL | | };
|
|
|
|
| |_____^ help: you can reduce it to: `a == b`
|
|
|
|
|
|
|
|
error: this if-then-else expression returns a bool literal
|
2023-06-10 11:43:30 +00:00
|
|
|
--> $DIR/fixable.rs:70:5
|
2021-12-14 12:27:55 +00:00
|
|
|
|
|
|
|
|
LL | / if a < b {
|
|
|
|
LL | | false
|
|
|
|
LL | | } else {
|
|
|
|
LL | | true
|
|
|
|
LL | | };
|
|
|
|
| |_____^ help: you can reduce it to: `a >= b`
|
|
|
|
|
|
|
|
error: this if-then-else expression returns a bool literal
|
2023-06-10 11:43:30 +00:00
|
|
|
--> $DIR/fixable.rs:75:5
|
2021-12-14 12:27:55 +00:00
|
|
|
|
|
|
|
|
LL | / if a <= b {
|
|
|
|
LL | | false
|
|
|
|
LL | | } else {
|
|
|
|
LL | | true
|
|
|
|
LL | | };
|
|
|
|
| |_____^ help: you can reduce it to: `a > b`
|
|
|
|
|
|
|
|
error: this if-then-else expression returns a bool literal
|
2023-06-10 11:43:30 +00:00
|
|
|
--> $DIR/fixable.rs:80:5
|
2021-12-14 12:27:55 +00:00
|
|
|
|
|
|
|
|
LL | / if a > b {
|
|
|
|
LL | | false
|
|
|
|
LL | | } else {
|
|
|
|
LL | | true
|
|
|
|
LL | | };
|
|
|
|
| |_____^ help: you can reduce it to: `a <= b`
|
|
|
|
|
|
|
|
error: this if-then-else expression returns a bool literal
|
2023-06-10 11:43:30 +00:00
|
|
|
--> $DIR/fixable.rs:85:5
|
2021-12-14 12:27:55 +00:00
|
|
|
|
|
|
|
|
LL | / if a >= b {
|
|
|
|
LL | | false
|
|
|
|
LL | | } else {
|
|
|
|
LL | | true
|
|
|
|
LL | | };
|
|
|
|
| |_____^ help: you can reduce it to: `a < b`
|
|
|
|
|
|
|
|
error: this if-then-else expression returns a bool literal
|
2023-06-10 11:43:30 +00:00
|
|
|
--> $DIR/fixable.rs:113:5
|
2017-02-07 20:05:30 +00:00
|
|
|
|
|
2018-12-27 15:57:55 +00:00
|
|
|
LL | / if x {
|
|
|
|
LL | | return true;
|
|
|
|
LL | | } else {
|
|
|
|
LL | | return false;
|
|
|
|
LL | | };
|
2019-08-05 20:05:05 +00:00
|
|
|
| |_____^ help: you can reduce it to: `return x`
|
2017-02-07 20:05:30 +00:00
|
|
|
|
|
|
|
error: this if-then-else expression returns a bool literal
|
2023-06-10 11:43:30 +00:00
|
|
|
--> $DIR/fixable.rs:121:5
|
2018-12-27 15:57:55 +00:00
|
|
|
|
|
|
|
|
LL | / if x {
|
|
|
|
LL | | return false;
|
2019-08-05 20:05:05 +00:00
|
|
|
LL | | } else {
|
|
|
|
LL | | return true;
|
2018-12-27 15:57:55 +00:00
|
|
|
LL | | };
|
2019-08-05 20:05:05 +00:00
|
|
|
| |_____^ help: you can reduce it to: `return !x`
|
2017-02-07 20:05:30 +00:00
|
|
|
|
|
|
|
error: this if-then-else expression returns a bool literal
|
2023-06-10 11:43:30 +00:00
|
|
|
--> $DIR/fixable.rs:129:5
|
2018-12-27 15:57:55 +00:00
|
|
|
|
|
|
|
|
LL | / if x && y {
|
|
|
|
LL | | return true;
|
|
|
|
LL | | } else {
|
|
|
|
LL | | return false;
|
|
|
|
LL | | };
|
|
|
|
| |_____^ help: you can reduce it to: `return x && y`
|
2017-02-07 20:05:30 +00:00
|
|
|
|
|
|
|
error: this if-then-else expression returns a bool literal
|
2023-06-10 11:43:30 +00:00
|
|
|
--> $DIR/fixable.rs:137:5
|
2018-12-27 15:57:55 +00:00
|
|
|
|
|
|
|
|
LL | / if x && y {
|
|
|
|
LL | | return false;
|
|
|
|
LL | | } else {
|
|
|
|
LL | | return true;
|
|
|
|
LL | | };
|
|
|
|
| |_____^ help: you can reduce it to: `return !(x && y)`
|
2017-02-07 20:05:30 +00:00
|
|
|
|
2018-10-28 14:37:39 +00:00
|
|
|
error: equality checks against true are unnecessary
|
2023-06-10 11:43:30 +00:00
|
|
|
--> $DIR/fixable.rs:145:8
|
2018-12-27 15:57:55 +00:00
|
|
|
|
|
|
|
|
LL | if x == true {};
|
|
|
|
| ^^^^^^^^^ help: try simplifying it as shown: `x`
|
|
|
|
|
|
|
|
|
= note: `-D clippy::bool-comparison` implied by `-D warnings`
|
2018-10-28 14:37:39 +00:00
|
|
|
|
|
|
|
error: equality checks against false can be replaced by a negation
|
2023-06-10 11:43:30 +00:00
|
|
|
--> $DIR/fixable.rs:149:8
|
2018-12-27 15:57:55 +00:00
|
|
|
|
|
|
|
|
LL | if x == false {};
|
|
|
|
| ^^^^^^^^^^ help: try simplifying it as shown: `!x`
|
2018-10-28 14:37:39 +00:00
|
|
|
|
|
|
|
error: equality checks against true are unnecessary
|
2023-06-10 11:43:30 +00:00
|
|
|
--> $DIR/fixable.rs:159:8
|
2018-12-27 15:57:55 +00:00
|
|
|
|
|
|
|
|
LL | if x == true {};
|
|
|
|
| ^^^^^^^^^ help: try simplifying it as shown: `x`
|
2018-10-28 14:37:39 +00:00
|
|
|
|
|
|
|
error: equality checks against false can be replaced by a negation
|
2023-06-10 11:43:30 +00:00
|
|
|
--> $DIR/fixable.rs:160:8
|
2018-12-27 15:57:55 +00:00
|
|
|
|
|
|
|
|
LL | if x == false {};
|
|
|
|
| ^^^^^^^^^^ help: try simplifying it as shown: `!x`
|
2018-10-28 14:37:39 +00:00
|
|
|
|
2019-01-20 15:15:00 +00:00
|
|
|
error: this if-then-else expression returns a bool literal
|
2023-06-10 11:43:30 +00:00
|
|
|
--> $DIR/fixable.rs:169:12
|
2019-01-20 15:15:00 +00:00
|
|
|
|
|
|
|
|
LL | } else if returns_bool() {
|
|
|
|
| ____________^
|
|
|
|
LL | | false
|
|
|
|
LL | | } else {
|
|
|
|
LL | | true
|
|
|
|
LL | | };
|
2019-08-04 20:08:28 +00:00
|
|
|
| |_____^ help: you can reduce it to: `{ !returns_bool() }`
|
2019-01-20 15:15:00 +00:00
|
|
|
|
2021-12-02 21:47:57 +00:00
|
|
|
error: this if-then-else expression returns a bool literal
|
2023-06-10 11:43:30 +00:00
|
|
|
--> $DIR/fixable.rs:182:5
|
2021-12-02 21:47:57 +00:00
|
|
|
|
|
|
|
|
LL | / if unsafe { no(4) } & 1 != 0 {
|
|
|
|
LL | | true
|
|
|
|
LL | | } else {
|
|
|
|
LL | | false
|
|
|
|
LL | | };
|
|
|
|
| |_____^ help: you can reduce it to: `(unsafe { no(4) } & 1 != 0)`
|
|
|
|
|
|
|
|
error: this if-then-else expression returns a bool literal
|
2023-06-10 11:43:30 +00:00
|
|
|
--> $DIR/fixable.rs:187:30
|
2021-12-02 21:47:57 +00:00
|
|
|
|
|
|
|
|
LL | let _brackets_unneeded = if unsafe { no(4) } & 1 != 0 { true } else { false };
|
|
|
|
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can reduce it to: `unsafe { no(4) } & 1 != 0`
|
|
|
|
|
|
|
|
error: this if-then-else expression returns a bool literal
|
2023-06-10 11:43:30 +00:00
|
|
|
--> $DIR/fixable.rs:190:9
|
2021-12-02 21:47:57 +00:00
|
|
|
|
|
|
|
|
LL | if unsafe { no(4) } & 1 != 0 { true } else { false }
|
|
|
|
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can reduce it to: `(unsafe { no(4) } & 1 != 0)`
|
|
|
|
|
2021-12-14 12:27:55 +00:00
|
|
|
error: aborting due to 21 previous errors
|
2018-01-16 16:06:27 +00:00
|
|
|
|