rust-clippy/clippy_lints/src/dbg_macro.rs

65 lines
2 KiB
Rust
Raw Normal View History

use crate::utils::{snippet_opt, span_lint_and_help, span_lint_and_sugg};
use rustc_errors::Applicability;
2020-01-12 06:08:41 +00:00
use rustc_lint::{EarlyContext, EarlyLintPass};
2020-01-11 11:37:08 +00:00
use rustc_session::{declare_lint_pass, declare_tool_lint};
use rustc_span::source_map::Span;
use syntax::ast;
use syntax::tokenstream::TokenStream;
2019-01-30 17:39:38 +00:00
declare_clippy_lint! {
/// **What it does:** Checks for usage of dbg!() macro.
///
/// **Why is this bad?** `dbg!` macro is intended as a debugging tool. It
/// should not be in version control.
///
/// **Known problems:** None.
///
/// **Example:**
/// ```rust,ignore
/// // Bad
/// dbg!(true)
///
/// // Good
/// true
/// ```
2019-01-30 17:39:38 +00:00
pub DBG_MACRO,
2019-02-01 00:23:40 +00:00
restriction,
2019-01-30 17:39:38 +00:00
"`dbg!` macro is intended as a debugging tool"
}
2019-04-08 20:43:55 +00:00
declare_lint_pass!(DbgMacro => [DBG_MACRO]);
2019-01-30 17:39:38 +00:00
2019-04-08 20:43:55 +00:00
impl EarlyLintPass for DbgMacro {
2019-01-30 17:39:38 +00:00
fn check_mac(&mut self, cx: &EarlyContext<'_>, mac: &ast::Mac) {
if mac.path == sym!(dbg) {
2019-12-03 16:54:32 +00:00
if let Some(sugg) = tts_span(mac.args.inner_tokens()).and_then(|span| snippet_opt(cx, span)) {
2019-02-03 09:50:00 +00:00
span_lint_and_sugg(
cx,
DBG_MACRO,
2019-12-03 16:54:32 +00:00
mac.span(),
2019-02-03 09:50:00 +00:00
"`dbg!` macro is intended as a debugging tool",
"ensure to avoid having uses of it in version control",
sugg,
Applicability::MaybeIncorrect,
);
} else {
span_lint_and_help(
2019-02-03 09:50:00 +00:00
cx,
DBG_MACRO,
2019-12-03 16:54:32 +00:00
mac.span(),
2019-02-03 09:50:00 +00:00
"`dbg!` macro is intended as a debugging tool",
"ensure to avoid having uses of it in version control",
);
}
2019-01-30 17:39:38 +00:00
}
}
}
// Get span enclosing entire the token stream.
fn tts_span(tts: TokenStream) -> Option<Span> {
let mut cursor = tts.into_trees();
let first = cursor.next()?.span();
2019-09-04 14:19:59 +00:00
let span = cursor.last().map_or(first, |tree| first.to(tree.span()));
Some(span)
}