Mirrors/rust-clippy
2
0
Fork 0
mirror of https://github.com/rust-lang/rust-clippy synced 2024-11-24 05:33:27 +00:00
Code Issues Projects Releases Packages Wiki Activity
rust-clippy/tests/ui/needless_pass_by_value.stderr

75 lines
2.6 KiB
Text
Raw Normal View History

Rename lint to needless_take_by_value And fixes false-positives for generics and `match`
2017-02-20 03:50:31 +00:00
error: this argument is passed by value, but not consumed in the function body
--> $DIR/needless_pass_by_value.rs:9:23
|
9 | fn foo<T: Default>(v: Vec<T>, w: Vec<T>, mut x: Vec<T>, y: Vec<T>) -> Vec<T> {
| ^^^^^^
|
note: lint level defined here
--> $DIR/needless_pass_by_value.rs:4:9
|
4 | #![deny(needless_pass_by_value)]
| ^^^^^^^^^^^^^^^^^^^^^^
help: consider changing the type to `&[T]`
| fn foo<T: Default>(v: &[T], w: Vec<T>, mut x: Vec<T>, y: Vec<T>) -> Vec<T> {
error: this argument is passed by value, but not consumed in the function body
--> $DIR/needless_pass_by_value.rs:23:11
|
23 | fn bar(x: String, y: Wrapper) {
| ^^^^^^
|
help: consider changing the type to `&str`
| fn bar(x: &str, y: Wrapper) {
error: this argument is passed by value, but not consumed in the function body
--> $DIR/needless_pass_by_value.rs:23:22
|
23 | fn bar(x: String, y: Wrapper) {
| ^^^^^^^
|
help: consider taking a reference instead
| fn bar(x: String, y: &Wrapper) {
error: this argument is passed by value, but not consumed in the function body
Support non-moving usages at `match` This `match` is not moving the `String`: ```rust fn foo(x: Option<String>) -> i32 { match x { Some(_) => 1, None => 2, } } ``` With this change, it will be linted and suggested to add `*` to deref it. ```rust fn foo(x: &Option<String>) -> i32 { match *x { Some(_) => 1, None => 2, } } ```
2017-02-20 07:45:37 +00:00
--> $DIR/needless_pass_by_value.rs:29:63
Rename lint to needless_take_by_value And fixes false-positives for generics and `match`
2017-02-20 03:50:31 +00:00
|
Support non-moving usages at `match` This `match` is not moving the `String`: ```rust fn foo(x: Option<String>) -> i32 { match x { Some(_) => 1, None => 2, } } ``` With this change, it will be linted and suggested to add `*` to deref it. ```rust fn foo(x: &Option<String>) -> i32 { match *x { Some(_) => 1, None => 2, } } ```
2017-02-20 07:45:37 +00:00
29 | fn test_borrow_trait<T: std::borrow::Borrow<str>, U>(t: T, u: U) {
Rename lint to needless_take_by_value And fixes false-positives for generics and `match`
2017-02-20 03:50:31 +00:00
| ^
|
help: consider taking a reference instead
| fn test_borrow_trait<T: std::borrow::Borrow<str>, U>(t: T, u: &U) {
Support non-moving usages at `match` This `match` is not moving the `String`: ```rust fn foo(x: Option<String>) -> i32 { match x { Some(_) => 1, None => 2, } } ``` With this change, it will be linted and suggested to add `*` to deref it. ```rust fn foo(x: &Option<String>) -> i32 { match *x { Some(_) => 1, None => 2, } } ```
2017-02-20 07:45:37 +00:00
error: this argument is passed by value, but not consumed in the function body
--> $DIR/needless_pass_by_value.rs:40:18
|
40 | fn test_match(x: Option<Option<String>>, y: Option<Option<String>>) {
| ^^^^^^^^^^^^^^^^^^^^^^
|
help: consider taking a reference instead
| fn test_match(x: &Option<Option<String>>, y: Option<Option<String>>) {
| match *x {
error: this argument is passed by value, but not consumed in the function body
--> $DIR/needless_pass_by_value.rs:53:24
|
Fix suggestion for `let <pat>`
2017-02-20 09:18:31 +00:00
53 | fn test_destructure(x: Wrapper, y: Wrapper, z: Wrapper) {
Support non-moving usages at `match` This `match` is not moving the `String`: ```rust fn foo(x: Option<String>) -> i32 { match x { Some(_) => 1, None => 2, } } ``` With this change, it will be linted and suggested to add `*` to deref it. ```rust fn foo(x: &Option<String>) -> i32 { match *x { Some(_) => 1, None => 2, } } ```
2017-02-20 07:45:37 +00:00
| ^^^^^^^
|
help: consider taking a reference instead
Fix suggestion for `let <pat>`
2017-02-20 09:18:31 +00:00
| fn test_destructure(x: &Wrapper, y: Wrapper, z: Wrapper) {
Support non-moving usages at `match` This `match` is not moving the `String`: ```rust fn foo(x: Option<String>) -> i32 { match x { Some(_) => 1, None => 2, } } ``` With this change, it will be linted and suggested to add `*` to deref it. ```rust fn foo(x: &Option<String>) -> i32 { match *x { Some(_) => 1, None => 2, } } ```
2017-02-20 07:45:37 +00:00
Fix suggestion for `let <pat>`
2017-02-20 09:18:31 +00:00
error: this argument is passed by value, but not consumed in the function body
--> $DIR/needless_pass_by_value.rs:53:36
|
53 | fn test_destructure(x: Wrapper, y: Wrapper, z: Wrapper) {
| ^^^^^^^
|
help: consider taking a reference instead
| fn test_destructure(x: Wrapper, y: &Wrapper, z: Wrapper) {
Integrate suggestion spans
2017-02-21 10:03:50 +00:00
| let Wrapper(s) = z; // moved
Fix suggestion for `let <pat>`
2017-02-20 09:18:31 +00:00
| let Wrapper(ref t) = *y; // not moved
Use `multispan_sugg`
2017-02-21 09:44:31 +00:00
| let Wrapper(_) = *y; // still not moved
Fix suggestion for `let <pat>`
2017-02-20 09:18:31 +00:00
error: aborting due to 7 previous errors
Rename lint to needless_take_by_value And fixes false-positives for generics and `match`
2017-02-20 03:50:31 +00:00
Reference in a new issue Copy permalink