rust-clippy/tests/ui/needless_pass_by_value.stderr

error: this argument is passed by value, but not consumed in the function body
  --> $DIR/needless_pass_by_value.rs:12:23
   |
12 | fn foo<T: Default>(v: Vec<T>, w: Vec<T>, mut x: Vec<T>, y: Vec<T>) -> Vec<T> {
   |                       ^^^^^^ help: consider changing the type to: `&[T]`
   |
   = note: `-D needless-pass-by-value` implied by `-D warnings`

error: this argument is passed by value, but not consumed in the function body
  --> $DIR/needless_pass_by_value.rs:26:11
   |
26 | fn bar(x: String, y: Wrapper) {
   |           ^^^^^^ help: consider changing the type to: `&str`

error: this argument is passed by value, but not consumed in the function body
  --> $DIR/needless_pass_by_value.rs:26:22
   |
26 | fn bar(x: String, y: Wrapper) {
   |                      ^^^^^^^ help: consider taking a reference instead: `&Wrapper`

error: this argument is passed by value, but not consumed in the function body
  --> $DIR/needless_pass_by_value.rs:32:71
   |
32 | fn test_borrow_trait<T: Borrow<str>, U: AsRef<str>, V>(t: T, u: U, v: V) {
   |                                                                       ^ help: consider taking a reference instead: `&V`

error: this argument is passed by value, but not consumed in the function body
  --> $DIR/needless_pass_by_value.rs:44:18
   |
44 | fn test_match(x: Option<Option<String>>, y: Option<Option<String>>) {
   |                  ^^^^^^^^^^^^^^^^^^^^^^
   |
help: consider taking a reference instead
   |
44 | fn test_match(x: &Option<Option<String>>, y: Option<Option<String>>) {
45 |     match *x {
   |

error: this argument is passed by value, but not consumed in the function body
  --> $DIR/needless_pass_by_value.rs:57:24
   |
57 | fn test_destructure(x: Wrapper, y: Wrapper, z: Wrapper) {
   |                        ^^^^^^^ help: consider taking a reference instead: `&Wrapper`

error: this argument is passed by value, but not consumed in the function body
  --> $DIR/needless_pass_by_value.rs:57:36
   |
57 | fn test_destructure(x: Wrapper, y: Wrapper, z: Wrapper) {
   |                                    ^^^^^^^
   |
help: consider taking a reference instead
   |
57 | fn test_destructure(x: Wrapper, y: &Wrapper, z: Wrapper) {
58 |     let Wrapper(s) = z; // moved
59 |     let Wrapper(ref t) = *y; // not moved
60 |     let Wrapper(_) = *y; // still not moved
   |

error: this argument is passed by value, but not consumed in the function body
  --> $DIR/needless_pass_by_value.rs:73:49
   |
73 | fn test_blanket_ref<T: Foo, S: Serialize>(_foo: T, _serializable: S) {}
   |                                                 ^ help: consider taking a reference instead: `&T`

error: this argument is passed by value, but not consumed in the function body
  --> $DIR/needless_pass_by_value.rs:75:18
   |
75 | fn issue_2114(s: String, t: String, u: Vec<i32>, v: Vec<i32>) {
   |                  ^^^^^^ help: consider taking a reference instead: `&String`

error: this argument is passed by value, but not consumed in the function body
  --> $DIR/needless_pass_by_value.rs:75:29
   |
75 | fn issue_2114(s: String, t: String, u: Vec<i32>, v: Vec<i32>) {
   |                             ^^^^^^
   |
help: consider changing the type to
   |
75 | fn issue_2114(s: String, t: &str, u: Vec<i32>, v: Vec<i32>) {
   |                             ^^^^
help: change `t.clone()` to
   |
77 |     let _ = t.to_string();
   |             ^^^^^^^^^^^^^

error: this argument is passed by value, but not consumed in the function body
  --> $DIR/needless_pass_by_value.rs:75:40
   |
75 | fn issue_2114(s: String, t: String, u: Vec<i32>, v: Vec<i32>) {
   |                                        ^^^^^^^^ help: consider taking a reference instead: `&Vec<i32>`

error: this argument is passed by value, but not consumed in the function body
  --> $DIR/needless_pass_by_value.rs:75:53
   |
75 | fn issue_2114(s: String, t: String, u: Vec<i32>, v: Vec<i32>) {
   |                                                     ^^^^^^^^
   |
help: consider changing the type to
   |
75 | fn issue_2114(s: String, t: String, u: Vec<i32>, v: &[i32]) {
   |                                                     ^^^^^^
help: change `v.clone()` to
   |
79 |     let _ = v.to_owned();
   |             ^^^^^^^^^^^^
Rename lint to needless_take_by_value And fixes false-positives for generics and `match` 2017-02-20 03:50:31 +00:00			`error: this argument is passed by value, but not consumed in the function body`
Reduce false-positives for needless_pass_by_value lint Excluding a type whose reference also fulfills the trait bound. 2017-10-08 01:23:41 +00:00			`--> $DIR/needless_pass_by_value.rs:12:23`
			`\|`
			`12 \| fn foo<T: Default>(v: Vec<T>, w: Vec<T>, mut x: Vec<T>, y: Vec<T>) -> Vec<T> {`
			\| ^^^^^^ help: consider changing the type to: `&[T]`
			`\|`
			= note: `-D needless-pass-by-value` implied by `-D warnings`
Rename lint to needless_take_by_value And fixes false-positives for generics and `match` 2017-02-20 03:50:31 +00:00
			`error: this argument is passed by value, but not consumed in the function body`
Reduce false-positives for needless_pass_by_value lint Excluding a type whose reference also fulfills the trait bound. 2017-10-08 01:23:41 +00:00			`--> $DIR/needless_pass_by_value.rs:26:11`
Rename lint to needless_take_by_value And fixes false-positives for generics and `match` 2017-02-20 03:50:31 +00:00			`\|`
Reduce false-positives for needless_pass_by_value lint Excluding a type whose reference also fulfills the trait bound. 2017-10-08 01:23:41 +00:00			`26 \| fn bar(x: String, y: Wrapper) {`
Fix ui tests 2017-07-21 08:40:23 +00:00			\| ^^^^^^ help: consider changing the type to: `&str`
Rename lint to needless_take_by_value And fixes false-positives for generics and `match` 2017-02-20 03:50:31 +00:00
			`error: this argument is passed by value, but not consumed in the function body`
Reduce false-positives for needless_pass_by_value lint Excluding a type whose reference also fulfills the trait bound. 2017-10-08 01:23:41 +00:00			`--> $DIR/needless_pass_by_value.rs:26:22`
Rename lint to needless_take_by_value And fixes false-positives for generics and `match` 2017-02-20 03:50:31 +00:00			`\|`
Reduce false-positives for needless_pass_by_value lint Excluding a type whose reference also fulfills the trait bound. 2017-10-08 01:23:41 +00:00			`26 \| fn bar(x: String, y: Wrapper) {`
Fix ui tests 2017-07-21 08:40:23 +00:00			\| ^^^^^^^ help: consider taking a reference instead: `&Wrapper`
Rename lint to needless_take_by_value And fixes false-positives for generics and `match` 2017-02-20 03:50:31 +00:00
			`error: this argument is passed by value, but not consumed in the function body`
Reduce false-positives for needless_pass_by_value lint Excluding a type whose reference also fulfills the trait bound. 2017-10-08 01:23:41 +00:00			`--> $DIR/needless_pass_by_value.rs:32:71`
Rename lint to needless_take_by_value And fixes false-positives for generics and `match` 2017-02-20 03:50:31 +00:00			`\|`
Reduce false-positives for needless_pass_by_value lint Excluding a type whose reference also fulfills the trait bound. 2017-10-08 01:23:41 +00:00			`32 \| fn test_borrow_trait<T: Borrow<str>, U: AsRef<str>, V>(t: T, u: U, v: V) {`
			\| ^ help: consider taking a reference instead: `&V`
Rename lint to needless_take_by_value And fixes false-positives for generics and `match` 2017-02-20 03:50:31 +00:00
Support non-moving usages at `match` This `match` is not moving the `String`: ```rust fn foo(x: Option<String>) -> i32 { match x { Some(_) => 1, None => 2, } } ``` With this change, it will be linted and suggested to add `` to deref it. ```rust fn foo(x: &Option<String>) -> i32 { match x { Some(_) => 1, None => 2, } } ``` 2017-02-20 07:45:37 +00:00			`error: this argument is passed by value, but not consumed in the function body`
Reduce false-positives for needless_pass_by_value lint Excluding a type whose reference also fulfills the trait bound. 2017-10-08 01:23:41 +00:00			`--> $DIR/needless_pass_by_value.rs:44:18`
Support non-moving usages at `match` This `match` is not moving the `String`: ```rust fn foo(x: Option<String>) -> i32 { match x { Some(_) => 1, None => 2, } } ``` With this change, it will be linted and suggested to add `` to deref it. ```rust fn foo(x: &Option<String>) -> i32 { match x { Some(_) => 1, None => 2, } } ``` 2017-02-20 07:45:37 +00:00			`\|`
Reduce false-positives for needless_pass_by_value lint Excluding a type whose reference also fulfills the trait bound. 2017-10-08 01:23:41 +00:00			`44 \| fn test_match(x: Option<Option<String>>, y: Option<Option<String>>) {`
Support non-moving usages at `match` This `match` is not moving the `String`: ```rust fn foo(x: Option<String>) -> i32 { match x { Some(_) => 1, None => 2, } } ``` With this change, it will be linted and suggested to add `` to deref it. ```rust fn foo(x: &Option<String>) -> i32 { match x { Some(_) => 1, None => 2, } } ``` 2017-02-20 07:45:37 +00:00			`\| ^^^^^^^^^^^^^^^^^^^^^^`
			`\|`
			`help: consider taking a reference instead`
Update rustc output 2017-07-10 13:29:29 +00:00			`\|`
Reduce false-positives for needless_pass_by_value lint Excluding a type whose reference also fulfills the trait bound. 2017-10-08 01:23:41 +00:00			`44 \| fn test_match(x: &Option<Option<String>>, y: Option<Option<String>>) {`
			`45 \| match *x {`
Update rustc output 2017-07-10 13:29:29 +00:00			`\|`
Support non-moving usages at `match` This `match` is not moving the `String`: ```rust fn foo(x: Option<String>) -> i32 { match x { Some(_) => 1, None => 2, } } ``` With this change, it will be linted and suggested to add `` to deref it. ```rust fn foo(x: &Option<String>) -> i32 { match x { Some(_) => 1, None => 2, } } ``` 2017-02-20 07:45:37 +00:00
			`error: this argument is passed by value, but not consumed in the function body`
Reduce false-positives for needless_pass_by_value lint Excluding a type whose reference also fulfills the trait bound. 2017-10-08 01:23:41 +00:00			`--> $DIR/needless_pass_by_value.rs:57:24`
Support non-moving usages at `match` This `match` is not moving the `String`: ```rust fn foo(x: Option<String>) -> i32 { match x { Some(_) => 1, None => 2, } } ``` With this change, it will be linted and suggested to add `` to deref it. ```rust fn foo(x: &Option<String>) -> i32 { match x { Some(_) => 1, None => 2, } } ``` 2017-02-20 07:45:37 +00:00			`\|`
Reduce false-positives for needless_pass_by_value lint Excluding a type whose reference also fulfills the trait bound. 2017-10-08 01:23:41 +00:00			`57 \| fn test_destructure(x: Wrapper, y: Wrapper, z: Wrapper) {`
Fix ui tests 2017-07-21 08:40:23 +00:00			\| ^^^^^^^ help: consider taking a reference instead: `&Wrapper`
Support non-moving usages at `match` This `match` is not moving the `String`: ```rust fn foo(x: Option<String>) -> i32 { match x { Some(_) => 1, None => 2, } } ``` With this change, it will be linted and suggested to add `` to deref it. ```rust fn foo(x: &Option<String>) -> i32 { match x { Some(_) => 1, None => 2, } } ``` 2017-02-20 07:45:37 +00:00
Fix suggestion for `let <pat>` 2017-02-20 09:18:31 +00:00			`error: this argument is passed by value, but not consumed in the function body`
Reduce false-positives for needless_pass_by_value lint Excluding a type whose reference also fulfills the trait bound. 2017-10-08 01:23:41 +00:00			`--> $DIR/needless_pass_by_value.rs:57:36`
Fix suggestion for `let <pat>` 2017-02-20 09:18:31 +00:00			`\|`
Reduce false-positives for needless_pass_by_value lint Excluding a type whose reference also fulfills the trait bound. 2017-10-08 01:23:41 +00:00			`57 \| fn test_destructure(x: Wrapper, y: Wrapper, z: Wrapper) {`
Fix suggestion for `let <pat>` 2017-02-20 09:18:31 +00:00			`\| ^^^^^^^`
			`\|`
			`help: consider taking a reference instead`
Update rustc output 2017-07-10 13:29:29 +00:00			`\|`
Reduce false-positives for needless_pass_by_value lint Excluding a type whose reference also fulfills the trait bound. 2017-10-08 01:23:41 +00:00			`57 \| fn test_destructure(x: Wrapper, y: &Wrapper, z: Wrapper) {`
			`58 \| let Wrapper(s) = z; // moved`
			`59 \| let Wrapper(ref t) = *y; // not moved`
			`60 \| let Wrapper(_) = *y; // still not moved`
			`\|`

			`error: this argument is passed by value, but not consumed in the function body`
			`--> $DIR/needless_pass_by_value.rs:73:49`
Update rustc output 2017-07-10 13:29:29 +00:00			`\|`
Reduce false-positives for needless_pass_by_value lint Excluding a type whose reference also fulfills the trait bound. 2017-10-08 01:23:41 +00:00			`73 \| fn test_blanket_ref<T: Foo, S: Serialize>(_foo: T, _serializable: S) {}`
			\| ^ help: consider taking a reference instead: `&T`
Fix suggestion for `let <pat>` 2017-02-20 09:18:31 +00:00
Duplicate ptr_arg's suggestion logic 2017-10-08 08:51:44 +00:00			`error: this argument is passed by value, but not consumed in the function body`
			`--> $DIR/needless_pass_by_value.rs:75:18`
			`\|`
			`75 \| fn issue_2114(s: String, t: String, u: Vec<i32>, v: Vec<i32>) {`
			\| ^^^^^^ help: consider taking a reference instead: `&String`

			`error: this argument is passed by value, but not consumed in the function body`
			`--> $DIR/needless_pass_by_value.rs:75:29`
			`\|`
			`75 \| fn issue_2114(s: String, t: String, u: Vec<i32>, v: Vec<i32>) {`
			`\| ^^^^^^`
			`\|`
			`help: consider changing the type to`
			`\|`
			`75 \| fn issue_2114(s: String, t: &str, u: Vec<i32>, v: Vec<i32>) {`
			`\| ^^^^`
			help: change `t.clone()` to
			`\|`
			`77 \| let _ = t.to_string();`
			`\| ^^^^^^^^^^^^^`

			`error: this argument is passed by value, but not consumed in the function body`
			`--> $DIR/needless_pass_by_value.rs:75:40`
			`\|`
			`75 \| fn issue_2114(s: String, t: String, u: Vec<i32>, v: Vec<i32>) {`
			\| ^^^^^^^^ help: consider taking a reference instead: `&Vec<i32>`

			`error: this argument is passed by value, but not consumed in the function body`
			`--> $DIR/needless_pass_by_value.rs:75:53`
			`\|`
			`75 \| fn issue_2114(s: String, t: String, u: Vec<i32>, v: Vec<i32>) {`
			`\| ^^^^^^^^`
			`\|`
			`help: consider changing the type to`
			`\|`
			`75 \| fn issue_2114(s: String, t: String, u: Vec<i32>, v: &[i32]) {`
			`\| ^^^^^^`
			help: change `v.clone()` to
			`\|`
			`79 \| let _ = v.to_owned();`
			`\| ^^^^^^^^^^^^`