rust-clippy/clippy_lints/src/cognitive_complexity.rs

168 lines
5.1 KiB
Rust
Raw Normal View History

//! calculate cognitive complexity and warn about overly complex functions
use clippy_utils::diagnostics::span_lint_and_help;
use clippy_utils::source::snippet_opt;
use clippy_utils::ty::is_type_diagnostic_item;
use clippy_utils::LimitStack;
2020-03-01 03:23:33 +00:00
use rustc_ast::ast::Attribute;
2022-01-15 22:07:52 +00:00
use rustc_hir::intravisit::{walk_expr, FnKind, Visitor};
2020-02-21 08:39:38 +00:00
use rustc_hir::{Body, Expr, ExprKind, FnDecl, HirId};
2020-01-12 06:08:41 +00:00
use rustc_lint::{LateContext, LateLintPass, LintContext};
2020-01-11 11:37:08 +00:00
use rustc_session::{declare_tool_lint, impl_lint_pass};
use rustc_span::source_map::Span;
use rustc_span::{sym, BytePos};
2018-03-28 13:24:26 +00:00
declare_clippy_lint! {
/// ### What it does
/// Checks for methods with high cognitive complexity.
///
/// ### Why is this bad?
/// Methods of high cognitive complexity tend to be hard to
/// both read and maintain. Also LLVM will tend to optimize small methods better.
///
/// ### Known problems
/// Sometimes it's hard to find a way to reduce the
/// complexity.
///
/// ### Example
/// No. You'll see it when you get the warning.
#[clippy::version = "1.35.0"]
pub COGNITIVE_COMPLEXITY,
2020-04-06 22:46:40 +00:00
nursery,
"functions that should be split up into multiple functions"
}
pub struct CognitiveComplexity {
limit: LimitStack,
}
impl CognitiveComplexity {
#[must_use]
pub fn new(limit: u64) -> Self {
2017-09-05 09:33:04 +00:00
Self {
limit: LimitStack::new(limit),
}
}
}
2019-04-08 20:43:55 +00:00
impl_lint_pass!(CognitiveComplexity => [COGNITIVE_COMPLEXITY]);
impl CognitiveComplexity {
#[allow(clippy::cast_possible_truncation)]
fn check<'tcx>(
&mut self,
cx: &LateContext<'tcx>,
kind: FnKind<'tcx>,
2019-12-30 04:02:10 +00:00
decl: &'tcx FnDecl<'_>,
2019-12-22 14:42:41 +00:00
body: &'tcx Body<'_>,
body_span: Span,
) {
if body_span.from_expansion() {
2016-01-04 04:26:12 +00:00
return;
}
let expr = &body.value;
2019-09-08 10:39:42 +00:00
let mut helper = CcHelper { cc: 1, returns: 0 };
helper.visit_expr(expr);
let CcHelper { cc, returns } = helper;
2020-07-17 08:47:04 +00:00
let ret_ty = cx.typeck_results().node_type(expr.hir_id);
2021-10-02 23:51:01 +00:00
let ret_adjust = if is_type_diagnostic_item(cx, ret_ty, sym::Result) {
2016-04-23 12:30:05 +00:00
returns
} else {
2019-06-11 16:53:12 +00:00
#[allow(clippy::integer_division)]
(returns / 2)
2016-04-23 12:30:05 +00:00
};
2019-09-08 10:39:42 +00:00
let mut rust_cc = cc;
// prevent degenerate cases where unreachable code contains `return` statements
if rust_cc >= ret_adjust {
rust_cc -= ret_adjust;
}
2019-09-08 10:39:42 +00:00
if rust_cc > self.limit.limit() {
let fn_span = match kind {
2020-11-27 08:24:42 +00:00
FnKind::ItemFn(ident, _, _, _) | FnKind::Method(ident, _, _) => ident.span,
FnKind::Closure => {
let header_span = body_span.with_hi(decl.output.span().lo());
let pos = snippet_opt(cx, header_span).and_then(|snip| {
let low_offset = snip.find('|')?;
let high_offset = 1 + snip.get(low_offset + 1..)?.find('|')?;
let low = header_span.lo() + BytePos(low_offset as u32);
let high = low + BytePos(high_offset as u32 + 1);
Some((low, high))
});
if let Some((low, high)) = pos {
2021-04-18 12:27:04 +00:00
Span::new(low, high, header_span.ctxt(), header_span.parent())
} else {
return;
}
},
};
span_lint_and_help(
2017-08-11 12:11:46 +00:00
cx,
2019-09-08 10:39:42 +00:00
COGNITIVE_COMPLEXITY,
fn_span,
2019-09-08 10:39:42 +00:00
&format!(
"the function has a cognitive complexity of ({}/{})",
rust_cc,
self.limit.limit()
),
None,
2019-09-08 10:39:42 +00:00
"you could split it up into multiple smaller functions",
2017-08-11 12:11:46 +00:00
);
}
}
}
impl<'tcx> LateLintPass<'tcx> for CognitiveComplexity {
2017-01-13 16:04:56 +00:00
fn check_fn(
&mut self,
cx: &LateContext<'tcx>,
kind: FnKind<'tcx>,
2019-12-30 04:02:10 +00:00
decl: &'tcx FnDecl<'_>,
2019-12-22 14:42:41 +00:00
body: &'tcx Body<'_>,
2017-01-13 16:04:56 +00:00
span: Span,
2019-02-20 10:11:11 +00:00
hir_id: HirId,
2017-01-13 16:04:56 +00:00
) {
let def_id = cx.tcx.hir().local_def_id(hir_id);
if !cx.tcx.has_attr(def_id.to_def_id(), sym::test) {
self.check(cx, kind, decl, body, span);
}
}
fn enter_lint_attrs(&mut self, cx: &LateContext<'tcx>, attrs: &'tcx [Attribute]) {
self.limit.push_attrs(cx.sess(), attrs, "cognitive_complexity");
}
fn exit_lint_attrs(&mut self, cx: &LateContext<'tcx>, attrs: &'tcx [Attribute]) {
self.limit.pop_attrs(cx.sess(), attrs, "cognitive_complexity");
}
}
struct CcHelper {
2019-09-08 10:39:42 +00:00
cc: u64,
2016-04-23 12:30:05 +00:00
returns: u64,
}
impl<'tcx> Visitor<'tcx> for CcHelper {
2019-12-27 07:12:26 +00:00
fn visit_expr(&mut self, e: &'tcx Expr<'_>) {
2019-09-08 10:39:42 +00:00
walk_expr(self, e);
2019-09-27 15:16:06 +00:00
match e.kind {
2021-01-01 18:38:11 +00:00
ExprKind::If(_, _, _) => {
self.cc += 1;
},
ExprKind::Match(_, arms, _) => {
2019-09-25 19:00:17 +00:00
if arms.len() > 1 {
2019-09-08 10:39:42 +00:00
self.cc += 1;
}
2019-09-08 10:39:42 +00:00
self.cc += arms.iter().filter(|arm| arm.guard.is_some()).count() as u64;
2016-12-20 17:21:30 +00:00
},
2018-07-12 07:30:57 +00:00
ExprKind::Ret(_) => self.returns += 1,
2019-09-08 10:39:42 +00:00
_ => {},
}
}
}