2021-03-25 18:29:11 +00:00
|
|
|
use clippy_utils::diagnostics::span_lint;
|
|
|
|
use clippy_utils::ty::contains_ty;
|
2020-02-18 13:28:18 +00:00
|
|
|
use rustc_hir::intravisit;
|
2021-01-15 09:56:44 +00:00
|
|
|
use rustc_hir::{self, AssocItemKind, Body, FnDecl, HirId, HirIdSet, Impl, ItemKind, Node};
|
2020-02-17 02:07:26 +00:00
|
|
|
use rustc_infer::infer::TyCtxtInferExt;
|
2020-01-12 06:08:41 +00:00
|
|
|
use rustc_lint::{LateContext, LateLintPass};
|
2021-02-25 20:33:18 +00:00
|
|
|
use rustc_middle::mir::FakeReadCause;
|
2021-08-30 14:38:27 +00:00
|
|
|
use rustc_middle::ty::layout::LayoutOf;
|
2021-01-15 09:56:44 +00:00
|
|
|
use rustc_middle::ty::{self, TraitRef, Ty};
|
2020-01-11 11:37:08 +00:00
|
|
|
use rustc_session::{declare_tool_lint, impl_lint_pass};
|
2020-01-04 10:00:00 +00:00
|
|
|
use rustc_span::source_map::Span;
|
2021-01-15 09:56:44 +00:00
|
|
|
use rustc_span::symbol::kw;
|
2020-10-09 10:45:29 +00:00
|
|
|
use rustc_target::spec::abi::Abi;
|
2021-07-14 06:21:08 +00:00
|
|
|
use rustc_typeck::expr_use_visitor::{Delegate, ExprUseVisitor, PlaceBase, PlaceWithHirId};
|
2015-12-04 10:12:53 +00:00
|
|
|
|
2019-04-08 20:43:55 +00:00
|
|
|
#[derive(Copy, Clone)]
|
|
|
|
pub struct BoxedLocal {
|
2016-07-10 13:23:50 +00:00
|
|
|
pub too_large_for_stack: u64,
|
|
|
|
}
|
2015-12-04 10:12:53 +00:00
|
|
|
|
2018-03-28 13:24:26 +00:00
|
|
|
declare_clippy_lint! {
|
2021-07-29 10:16:06 +00:00
|
|
|
/// ### What it does
|
|
|
|
/// Checks for usage of `Box<T>` where an unboxed `T` would
|
2019-03-05 16:50:33 +00:00
|
|
|
/// work fine.
|
|
|
|
///
|
2021-07-29 10:16:06 +00:00
|
|
|
/// ### Why is this bad?
|
|
|
|
/// This is an unnecessary allocation, and bad for
|
2019-03-05 16:50:33 +00:00
|
|
|
/// performance. It is only necessary to allocate if you wish to move the box
|
|
|
|
/// into something.
|
|
|
|
///
|
2021-07-29 10:16:06 +00:00
|
|
|
/// ### Example
|
2019-03-05 16:50:33 +00:00
|
|
|
/// ```rust
|
2019-08-03 06:01:27 +00:00
|
|
|
/// # fn foo(bar: usize) {}
|
2020-06-09 14:36:01 +00:00
|
|
|
/// // Bad
|
2019-08-03 06:01:27 +00:00
|
|
|
/// let x = Box::new(1);
|
|
|
|
/// foo(*x);
|
|
|
|
/// println!("{}", *x);
|
2020-06-09 14:36:01 +00:00
|
|
|
///
|
|
|
|
/// // Good
|
|
|
|
/// let x = 1;
|
|
|
|
/// foo(x);
|
|
|
|
/// println!("{}", x);
|
2019-03-05 16:50:33 +00:00
|
|
|
/// ```
|
2021-12-06 11:33:31 +00:00
|
|
|
#[clippy::version = "pre 1.29.0"]
|
2016-08-06 08:18:36 +00:00
|
|
|
pub BOXED_LOCAL,
|
2018-03-28 13:24:26 +00:00
|
|
|
perf,
|
2016-08-06 08:18:36 +00:00
|
|
|
"using `Box<T>` where unnecessary"
|
2016-02-05 23:13:29 +00:00
|
|
|
}
|
2015-12-04 10:12:53 +00:00
|
|
|
|
2018-07-23 11:01:12 +00:00
|
|
|
fn is_non_trait_box(ty: Ty<'_>) -> bool {
|
2017-02-03 10:52:13 +00:00
|
|
|
ty.is_box() && !ty.boxed_ty().is_trait()
|
2015-12-28 14:12:57 +00:00
|
|
|
}
|
|
|
|
|
2019-06-19 18:36:23 +00:00
|
|
|
struct EscapeDelegate<'a, 'tcx> {
|
2020-06-25 20:41:36 +00:00
|
|
|
cx: &'a LateContext<'tcx>,
|
2019-03-01 12:26:06 +00:00
|
|
|
set: HirIdSet,
|
2021-07-17 14:43:23 +00:00
|
|
|
trait_self_ty: Option<Ty<'tcx>>,
|
2016-07-10 13:23:50 +00:00
|
|
|
too_large_for_stack: u64,
|
2015-12-04 10:12:53 +00:00
|
|
|
}
|
|
|
|
|
2019-04-08 20:43:55 +00:00
|
|
|
impl_lint_pass!(BoxedLocal => [BOXED_LOCAL]);
|
2019-01-26 19:40:55 +00:00
|
|
|
|
2020-06-25 20:41:36 +00:00
|
|
|
impl<'tcx> LateLintPass<'tcx> for BoxedLocal {
|
2016-12-21 09:25:14 +00:00
|
|
|
fn check_fn(
|
2016-12-21 11:14:54 +00:00
|
|
|
&mut self,
|
2020-06-25 20:41:36 +00:00
|
|
|
cx: &LateContext<'tcx>,
|
2020-10-09 10:45:29 +00:00
|
|
|
fn_kind: intravisit::FnKind<'tcx>,
|
2019-12-30 04:02:10 +00:00
|
|
|
_: &'tcx FnDecl<'_>,
|
2019-12-22 14:42:41 +00:00
|
|
|
body: &'tcx Body<'_>,
|
2016-12-21 11:14:54 +00:00
|
|
|
_: Span,
|
2019-02-20 10:11:11 +00:00
|
|
|
hir_id: HirId,
|
2016-12-21 09:25:14 +00:00
|
|
|
) {
|
2020-10-09 10:45:29 +00:00
|
|
|
if let Some(header) = fn_kind.header() {
|
|
|
|
if header.abi != Abi::Rust {
|
|
|
|
return;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2019-02-20 10:11:11 +00:00
|
|
|
let parent_id = cx.tcx.hir().get_parent_item(hir_id);
|
2021-10-21 17:41:47 +00:00
|
|
|
let parent_node = cx.tcx.hir().find_by_def_id(parent_id);
|
2018-10-15 18:20:50 +00:00
|
|
|
|
2021-01-15 09:56:44 +00:00
|
|
|
let mut trait_self_ty = None;
|
2018-10-15 18:20:50 +00:00
|
|
|
if let Some(Node::Item(item)) = parent_node {
|
2021-01-15 09:56:44 +00:00
|
|
|
// If the method is an impl for a trait, don't warn.
|
2020-11-22 22:46:21 +00:00
|
|
|
if let ItemKind::Impl(Impl { of_trait: Some(_), .. }) = item.kind {
|
2018-10-15 18:20:50 +00:00
|
|
|
return;
|
|
|
|
}
|
2021-01-15 09:56:44 +00:00
|
|
|
|
|
|
|
// find `self` ty for this trait if relevant
|
|
|
|
if let ItemKind::Trait(_, _, _, _, items) = item.kind {
|
|
|
|
for trait_item in items {
|
2021-01-30 19:46:50 +00:00
|
|
|
if trait_item.id.hir_id() == hir_id {
|
2021-01-15 09:56:44 +00:00
|
|
|
// be sure we have `self` parameter in this function
|
2021-10-07 09:21:30 +00:00
|
|
|
if trait_item.kind == (AssocItemKind::Fn { has_self: true }) {
|
2021-09-28 17:03:12 +00:00
|
|
|
trait_self_ty = Some(
|
|
|
|
TraitRef::identity(cx.tcx, trait_item.id.def_id.to_def_id())
|
|
|
|
.self_ty()
|
|
|
|
.skip_binder(),
|
|
|
|
);
|
2021-01-15 09:56:44 +00:00
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
2018-10-15 18:20:50 +00:00
|
|
|
}
|
|
|
|
|
2015-12-04 10:12:53 +00:00
|
|
|
let mut v = EscapeDelegate {
|
2018-03-15 15:07:15 +00:00
|
|
|
cx,
|
2019-03-01 12:26:06 +00:00
|
|
|
set: HirIdSet::default(),
|
2021-01-15 09:56:44 +00:00
|
|
|
trait_self_ty,
|
2016-07-10 13:23:50 +00:00
|
|
|
too_large_for_stack: self.too_large_for_stack,
|
2015-12-04 10:12:53 +00:00
|
|
|
};
|
2016-05-12 17:11:13 +00:00
|
|
|
|
2019-07-06 03:52:51 +00:00
|
|
|
let fn_def_id = cx.tcx.hir().local_def_id(hir_id);
|
2019-11-29 10:12:19 +00:00
|
|
|
cx.tcx.infer_ctxt().enter(|infcx| {
|
2020-07-17 08:47:04 +00:00
|
|
|
ExprUseVisitor::new(&mut v, &infcx, fn_def_id, cx.param_env, cx.typeck_results()).consume_body(body);
|
2019-11-29 10:12:19 +00:00
|
|
|
});
|
2016-05-12 17:11:13 +00:00
|
|
|
|
2019-02-22 05:06:51 +00:00
|
|
|
for node in v.set {
|
2017-08-09 07:30:56 +00:00
|
|
|
span_lint(
|
|
|
|
cx,
|
|
|
|
BOXED_LOCAL,
|
2019-06-18 09:15:47 +00:00
|
|
|
cx.tcx.hir().span(node),
|
2017-08-09 07:30:56 +00:00
|
|
|
"local variable doesn't need to be boxed here",
|
|
|
|
);
|
2015-12-04 10:12:53 +00:00
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2019-07-30 04:37:49 +00:00
|
|
|
// TODO: Replace with Map::is_argument(..) when it's fixed
|
2020-03-30 09:02:14 +00:00
|
|
|
fn is_argument(map: rustc_middle::hir::map::Map<'_>, id: HirId) -> bool {
|
2019-07-30 04:37:49 +00:00
|
|
|
match map.find(id) {
|
|
|
|
Some(Node::Binding(_)) => (),
|
|
|
|
_ => return false,
|
|
|
|
}
|
|
|
|
|
2020-07-14 12:59:59 +00:00
|
|
|
matches!(map.find(map.get_parent_node(id)), Some(Node::Param(_)))
|
2019-07-30 04:37:49 +00:00
|
|
|
}
|
|
|
|
|
2017-06-11 02:34:47 +00:00
|
|
|
impl<'a, 'tcx> Delegate<'tcx> for EscapeDelegate<'a, 'tcx> {
|
2021-07-14 06:21:08 +00:00
|
|
|
fn consume(&mut self, cmt: &PlaceWithHirId<'tcx>, _: HirId) {
|
2020-06-17 22:13:05 +00:00
|
|
|
if cmt.place.projections.is_empty() {
|
|
|
|
if let PlaceBase::Local(lid) = cmt.place.base {
|
2021-07-14 06:21:08 +00:00
|
|
|
self.set.remove(&lid);
|
2019-11-29 11:57:10 +00:00
|
|
|
let map = &self.cx.tcx.hir();
|
|
|
|
if let Some(Node::Binding(_)) = map.find(cmt.hir_id) {
|
|
|
|
if self.set.contains(&lid) {
|
|
|
|
// let y = x where x is known
|
|
|
|
// remove x, insert y
|
|
|
|
self.set.insert(cmt.hir_id);
|
|
|
|
self.set.remove(&lid);
|
|
|
|
}
|
|
|
|
}
|
2015-12-04 10:12:53 +00:00
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
2019-10-04 12:24:47 +00:00
|
|
|
|
2020-11-01 07:15:22 +00:00
|
|
|
fn borrow(&mut self, cmt: &PlaceWithHirId<'tcx>, _: HirId, _: ty::BorrowKind) {
|
2020-06-17 22:13:05 +00:00
|
|
|
if cmt.place.projections.is_empty() {
|
|
|
|
if let PlaceBase::Local(lid) = cmt.place.base {
|
2019-11-29 11:57:10 +00:00
|
|
|
self.set.remove(&lid);
|
|
|
|
}
|
2015-12-04 10:12:53 +00:00
|
|
|
}
|
|
|
|
}
|
2019-10-04 12:24:47 +00:00
|
|
|
|
2020-11-01 07:15:22 +00:00
|
|
|
fn mutate(&mut self, cmt: &PlaceWithHirId<'tcx>, _: HirId) {
|
2020-06-17 22:13:05 +00:00
|
|
|
if cmt.place.projections.is_empty() {
|
2019-11-29 11:57:10 +00:00
|
|
|
let map = &self.cx.tcx.hir();
|
2020-03-15 22:41:20 +00:00
|
|
|
if is_argument(*map, cmt.hir_id) {
|
2019-11-29 11:57:10 +00:00
|
|
|
// Skip closure arguments
|
|
|
|
let parent_id = map.get_parent_node(cmt.hir_id);
|
|
|
|
if let Some(Node::Expr(..)) = map.find(map.get_parent_node(parent_id)) {
|
|
|
|
return;
|
|
|
|
}
|
2019-10-06 12:49:26 +00:00
|
|
|
|
2021-01-15 09:56:44 +00:00
|
|
|
// skip if there is a `self` parameter binding to a type
|
|
|
|
// that contains `Self` (i.e.: `self: Box<Self>`), see #4804
|
|
|
|
if let Some(trait_self_ty) = self.trait_self_ty {
|
2022-01-12 03:19:52 +00:00
|
|
|
if map.name(cmt.hir_id) == kw::SelfLower && contains_ty(cmt.place.ty(), trait_self_ty) {
|
2021-01-15 09:56:44 +00:00
|
|
|
return;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2020-06-24 20:33:31 +00:00
|
|
|
if is_non_trait_box(cmt.place.ty()) && !self.is_large_box(cmt.place.ty()) {
|
2019-11-29 11:57:10 +00:00
|
|
|
self.set.insert(cmt.hir_id);
|
|
|
|
}
|
2019-10-06 12:49:26 +00:00
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
2021-02-25 20:33:18 +00:00
|
|
|
|
2021-03-25 18:29:11 +00:00
|
|
|
fn fake_read(&mut self, _: rustc_typeck::expr_use_visitor::Place<'tcx>, _: FakeReadCause, _: HirId) {}
|
2015-12-04 10:12:53 +00:00
|
|
|
}
|
2016-07-10 13:23:50 +00:00
|
|
|
|
2017-06-11 02:34:47 +00:00
|
|
|
impl<'a, 'tcx> EscapeDelegate<'a, 'tcx> {
|
2017-06-11 02:57:25 +00:00
|
|
|
fn is_large_box(&self, ty: Ty<'tcx>) -> bool {
|
2019-01-31 01:15:29 +00:00
|
|
|
// Large types need to be boxed to avoid stack overflows.
|
2017-02-03 10:52:13 +00:00
|
|
|
if ty.is_box() {
|
2019-11-26 14:14:28 +00:00
|
|
|
self.cx.layout_of(ty.boxed_ty()).map_or(0, |l| l.size.bytes()) > self.too_large_for_stack
|
2017-06-11 02:34:47 +00:00
|
|
|
} else {
|
|
|
|
false
|
2016-07-10 13:23:50 +00:00
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|