rust-clippy/tests/ui/or_fun_call.stderr

error: function call inside of `unwrap_or`
  --> tests/ui/or_fun_call.rs:52:22
   |
LL |     with_constructor.unwrap_or(make());
   |                      ^^^^^^^^^^^^^^^^^ help: try: `unwrap_or_else(make)`
   |
   = note: `-D clippy::or-fun-call` implied by `-D warnings`
   = help: to override `-D warnings` add `#[allow(clippy::or_fun_call)]`

error: use of `unwrap_or` to construct default value
  --> tests/ui/or_fun_call.rs:55:14
   |
LL |     with_new.unwrap_or(Vec::new());
   |              ^^^^^^^^^^^^^^^^^^^^^ help: try: `unwrap_or_default()`
   |
   = note: `-D clippy::unwrap-or-default` implied by `-D warnings`
   = help: to override `-D warnings` add `#[allow(clippy::unwrap_or_default)]`

error: function call inside of `unwrap_or`
  --> tests/ui/or_fun_call.rs:58:21
   |
LL |     with_const_args.unwrap_or(Vec::with_capacity(12));
   |                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `unwrap_or_else(|| Vec::with_capacity(12))`

error: function call inside of `unwrap_or`
  --> tests/ui/or_fun_call.rs:61:14
   |
LL |     with_err.unwrap_or(make());
   |              ^^^^^^^^^^^^^^^^^ help: try: `unwrap_or_else(|_| make())`

error: function call inside of `unwrap_or`
  --> tests/ui/or_fun_call.rs:64:19
   |
LL |     with_err_args.unwrap_or(Vec::with_capacity(12));
   |                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `unwrap_or_else(|_| Vec::with_capacity(12))`

error: use of `unwrap_or` to construct default value
  --> tests/ui/or_fun_call.rs:67:24
   |
LL |     with_default_trait.unwrap_or(Default::default());
   |                        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `unwrap_or_default()`

error: use of `unwrap_or` to construct default value
  --> tests/ui/or_fun_call.rs:70:23
   |
LL |     with_default_type.unwrap_or(u64::default());
   |                       ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `unwrap_or_default()`

error: function call inside of `unwrap_or`
  --> tests/ui/or_fun_call.rs:73:18
   |
LL |     self_default.unwrap_or(<FakeDefault>::default());
   |                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `unwrap_or_else(<FakeDefault>::default)`

error: use of `unwrap_or` to construct default value
  --> tests/ui/or_fun_call.rs:76:18
   |
LL |     real_default.unwrap_or(<FakeDefault as Default>::default());
   |                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `unwrap_or_default()`

error: use of `unwrap_or` to construct default value
  --> tests/ui/or_fun_call.rs:79:14
   |
LL |     with_vec.unwrap_or(vec![]);
   |              ^^^^^^^^^^^^^^^^^ help: try: `unwrap_or_default()`

error: function call inside of `unwrap_or`
  --> tests/ui/or_fun_call.rs:82:21
   |
LL |     without_default.unwrap_or(Foo::new());
   |                     ^^^^^^^^^^^^^^^^^^^^^ help: try: `unwrap_or_else(Foo::new)`

error: use of `or_insert` to construct default value
  --> tests/ui/or_fun_call.rs:85:19
   |
LL |     map.entry(42).or_insert(String::new());
   |                   ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `or_default()`

error: use of `or_insert` to construct default value
  --> tests/ui/or_fun_call.rs:88:23
   |
LL |     map_vec.entry(42).or_insert(vec![]);
   |                       ^^^^^^^^^^^^^^^^^ help: try: `or_default()`

error: use of `or_insert` to construct default value
  --> tests/ui/or_fun_call.rs:91:21
   |
LL |     btree.entry(42).or_insert(String::new());
   |                     ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `or_default()`

error: use of `or_insert` to construct default value
  --> tests/ui/or_fun_call.rs:94:25
   |
LL |     btree_vec.entry(42).or_insert(vec![]);
   |                         ^^^^^^^^^^^^^^^^^ help: try: `or_default()`

error: use of `unwrap_or` to construct default value
  --> tests/ui/or_fun_call.rs:97:21
   |
LL |     let _ = stringy.unwrap_or(String::new());
   |                     ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `unwrap_or_default()`

error: function call inside of `ok_or`
  --> tests/ui/or_fun_call.rs:101:17
   |
LL |     let _ = opt.ok_or(format!("{} world.", hello));
   |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `ok_or_else(|| format!("{} world.", hello))`

error: function call inside of `unwrap_or`
  --> tests/ui/or_fun_call.rs:105:21
   |
LL |     let _ = Some(1).unwrap_or(map[&1]);
   |                     ^^^^^^^^^^^^^^^^^^ help: try: `unwrap_or_else(|| map[&1])`

error: function call inside of `unwrap_or`
  --> tests/ui/or_fun_call.rs:107:21
   |
LL |     let _ = Some(1).unwrap_or(map[&1]);
   |                     ^^^^^^^^^^^^^^^^^^ help: try: `unwrap_or_else(|| map[&1])`

error: function call inside of `or`
  --> tests/ui/or_fun_call.rs:131:35
   |
LL |     let _ = Some("a".to_string()).or(Some("b".to_string()));
   |                                   ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `or_else(|| Some("b".to_string()))`

error: function call inside of `unwrap_or`
  --> tests/ui/or_fun_call.rs:170:14
   |
LL |         None.unwrap_or(ptr_to_ref(s));
   |              ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `unwrap_or_else(|| ptr_to_ref(s))`

error: function call inside of `unwrap_or`
  --> tests/ui/or_fun_call.rs:176:14
   |
LL |         None.unwrap_or(unsafe { ptr_to_ref(s) });
   |              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `unwrap_or_else(|| unsafe { ptr_to_ref(s) })`

error: function call inside of `unwrap_or`
  --> tests/ui/or_fun_call.rs:178:14
   |
LL |         None.unwrap_or( unsafe { ptr_to_ref(s) }    );
   |              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `unwrap_or_else(|| unsafe { ptr_to_ref(s) })`

error: function call inside of `map_or`
  --> tests/ui/or_fun_call.rs:253:25
   |
LL |         let _ = Some(4).map_or(g(), |v| v);
   |                         ^^^^^^^^^^^^^^^^^^ help: try: `map_or_else(g, |v| v)`

error: function call inside of `map_or`
  --> tests/ui/or_fun_call.rs:254:25
   |
LL |         let _ = Some(4).map_or(g(), f);
   |                         ^^^^^^^^^^^^^^ help: try: `map_or_else(g, f)`

error: use of `unwrap_or_else` to construct default value
  --> tests/ui/or_fun_call.rs:285:18
   |
LL |         with_new.unwrap_or_else(Vec::new);
   |                  ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `unwrap_or_default()`

error: use of `unwrap_or_else` to construct default value
  --> tests/ui/or_fun_call.rs:288:28
   |
LL |         with_default_trait.unwrap_or_else(Default::default);
   |                            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `unwrap_or_default()`

error: use of `unwrap_or_else` to construct default value
  --> tests/ui/or_fun_call.rs:291:27
   |
LL |         with_default_type.unwrap_or_else(u64::default);
   |                           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `unwrap_or_default()`

error: use of `unwrap_or_else` to construct default value
  --> tests/ui/or_fun_call.rs:294:22
   |
LL |         real_default.unwrap_or_else(<FakeDefault as Default>::default);
   |                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `unwrap_or_default()`

error: use of `or_insert_with` to construct default value
  --> tests/ui/or_fun_call.rs:297:23
   |
LL |         map.entry(42).or_insert_with(String::new);
   |                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `or_default()`

error: use of `or_insert_with` to construct default value
  --> tests/ui/or_fun_call.rs:300:25
   |
LL |         btree.entry(42).or_insert_with(String::new);
   |                         ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `or_default()`

error: use of `unwrap_or_else` to construct default value
  --> tests/ui/or_fun_call.rs:303:25
   |
LL |         let _ = stringy.unwrap_or_else(String::new);
   |                         ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `unwrap_or_default()`

error: function call inside of `unwrap_or`
  --> tests/ui/or_fun_call.rs:345:17
   |
LL |     let _ = opt.unwrap_or({ f() }); // suggest `.unwrap_or_else(f)`
   |                 ^^^^^^^^^^^^^^^^^^ help: try: `unwrap_or_else(f)`

error: function call inside of `unwrap_or`
  --> tests/ui/or_fun_call.rs:348:17
   |
LL |     let _ = opt.unwrap_or(f() + 1); // suggest `.unwrap_or_else(|| f() + 1)`
   |                 ^^^^^^^^^^^^^^^^^^ help: try: `unwrap_or_else(|| f() + 1)`

error: function call inside of `unwrap_or`
  --> tests/ui/or_fun_call.rs:351:17
   |
LL |       let _ = opt.unwrap_or({
   |  _________________^
LL | |         let x = f();
LL | |         x + 1
LL | |     });
   | |______^
   |
help: try
   |
LL ~     let _ = opt.unwrap_or_else(|| {
LL +         let x = f();
LL +         x + 1
LL ~     });
   |

error: function call inside of `map_or`
  --> tests/ui/or_fun_call.rs:356:17
   |
LL |     let _ = opt.map_or(f() + 1, |v| v); // suggest `.map_or_else(|| f() + 1, |v| v)`
   |                 ^^^^^^^^^^^^^^^^^^^^^^ help: try: `map_or_else(|| f() + 1, |v| v)`

error: use of `unwrap_or` to construct default value
  --> tests/ui/or_fun_call.rs:359:17
   |
LL |     let _ = opt.unwrap_or({ i32::default() });
   |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `unwrap_or_default()`

error: function call inside of `unwrap_or`
  --> tests/ui/or_fun_call.rs:365:21
   |
LL |     let _ = opt_foo.unwrap_or(Foo { val: String::default() });
   |                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `unwrap_or_else(|| Foo { val: String::default() })`

error: aborting due to 38 previous errors