2021-03-16 00:55:45 +00:00
|
|
|
use clippy_utils::diagnostics::{span_lint_and_help, span_lint_and_sugg};
|
2021-03-14 23:17:44 +00:00
|
|
|
use clippy_utils::source::snippet_opt;
|
2020-03-01 03:23:33 +00:00
|
|
|
use rustc_ast::ast;
|
|
|
|
use rustc_ast::tokenstream::TokenStream;
|
2019-02-03 09:28:42 +00:00
|
|
|
use rustc_errors::Applicability;
|
2020-01-12 06:08:41 +00:00
|
|
|
use rustc_lint::{EarlyContext, EarlyLintPass};
|
2020-01-11 11:37:08 +00:00
|
|
|
use rustc_session::{declare_lint_pass, declare_tool_lint};
|
2020-01-04 10:00:00 +00:00
|
|
|
use rustc_span::source_map::Span;
|
2019-01-30 17:39:38 +00:00
|
|
|
|
|
|
|
declare_clippy_lint! {
|
2021-07-02 18:37:11 +00:00
|
|
|
/// ### What it does
|
|
|
|
/// Checks for usage of dbg!() macro.
|
2019-03-05 16:50:33 +00:00
|
|
|
///
|
2021-07-02 18:37:11 +00:00
|
|
|
/// ### Why is this bad?
|
|
|
|
/// `dbg!` macro is intended as a debugging tool. It
|
2019-03-05 16:50:33 +00:00
|
|
|
/// should not be in version control.
|
|
|
|
///
|
2021-12-03 18:29:57 +00:00
|
|
|
/// ### Known problems
|
|
|
|
/// * The lint level is unaffected by crate attributes. The level can still
|
|
|
|
/// be set for functions, modules and other items. To change the level for
|
|
|
|
/// the entire crate, please use command line flags. More information and a
|
|
|
|
/// configuration example can be found in [clippy#6610].
|
|
|
|
///
|
|
|
|
/// [clippy#6610]: https://github.com/rust-lang/rust-clippy/issues/6610#issuecomment-977120558
|
|
|
|
///
|
2021-07-02 18:37:11 +00:00
|
|
|
/// ### Example
|
2019-03-05 16:50:33 +00:00
|
|
|
/// ```rust,ignore
|
|
|
|
/// // Bad
|
|
|
|
/// dbg!(true)
|
|
|
|
///
|
|
|
|
/// // Good
|
|
|
|
/// true
|
|
|
|
/// ```
|
Added `clippy::version` attribute to all normal lints
So, some context for this, well, more a story. I'm not used to scripting, I've never really scripted anything, even if it's a valuable skill. I just never really needed it. Now, `@flip1995` correctly suggested using a script for this in `rust-clippy#7813`...
And I decided to write a script using nushell because why not? This was a mistake... I spend way more time on this than I would like to admit. It has definitely been more than 4 hours. It shouldn't take that long, but me being new to scripting and nushell just wasn't a good mixture... Anyway, here is the script that creates another script which adds the versions. Fun...
Just execute this on the `gh-pages` branch and the resulting `replacer.sh` in `clippy_lints` and it should all work.
```nu
mv v0.0.212 rust-1.00.0;
mv beta rust-1.57.0;
mv master rust-1.58.0;
let paths = (open ./rust-1.58.0/lints.json | select id id_span | flatten | select id path);
let versions = (
ls | where name =~ "rust-" | select name | format {name}/lints.json |
each { open $it | select id | insert version $it | str substring "5,11" version} |
group-by id | rotate counter-clockwise id version |
update version {get version | first 1} | flatten | select id version);
$paths | each { |row|
let version = ($versions | where id == ($row.id) | format {version})
let idu = ($row.id | str upcase)
$"sed -i '0,/($idu),/{s/pub ($idu),/#[clippy::version = "($version)"]\n pub ($idu),/}' ($row.path)"
} | str collect ";" | str find-replace --all '1.00.0' 'pre 1.29.0' | save "replacer.sh";
```
And this still has some problems, but at this point I just want to be done -.-
2021-10-21 19:06:26 +00:00
|
|
|
#[clippy::version = "1.34.0"]
|
2019-01-30 17:39:38 +00:00
|
|
|
pub DBG_MACRO,
|
2019-02-01 00:23:40 +00:00
|
|
|
restriction,
|
2019-01-30 17:39:38 +00:00
|
|
|
"`dbg!` macro is intended as a debugging tool"
|
|
|
|
}
|
|
|
|
|
2019-04-08 20:43:55 +00:00
|
|
|
declare_lint_pass!(DbgMacro => [DBG_MACRO]);
|
2019-01-30 17:39:38 +00:00
|
|
|
|
2019-04-08 20:43:55 +00:00
|
|
|
impl EarlyLintPass for DbgMacro {
|
2020-03-15 17:23:43 +00:00
|
|
|
fn check_mac(&mut self, cx: &EarlyContext<'_>, mac: &ast::MacCall) {
|
2019-08-16 02:30:38 +00:00
|
|
|
if mac.path == sym!(dbg) {
|
2019-12-03 16:54:32 +00:00
|
|
|
if let Some(sugg) = tts_span(mac.args.inner_tokens()).and_then(|span| snippet_opt(cx, span)) {
|
2019-02-03 09:50:00 +00:00
|
|
|
span_lint_and_sugg(
|
|
|
|
cx,
|
|
|
|
DBG_MACRO,
|
2019-12-03 16:54:32 +00:00
|
|
|
mac.span(),
|
2019-02-03 09:50:00 +00:00
|
|
|
"`dbg!` macro is intended as a debugging tool",
|
|
|
|
"ensure to avoid having uses of it in version control",
|
|
|
|
sugg,
|
|
|
|
Applicability::MaybeIncorrect,
|
|
|
|
);
|
|
|
|
} else {
|
2020-01-27 01:56:22 +00:00
|
|
|
span_lint_and_help(
|
2019-02-03 09:50:00 +00:00
|
|
|
cx,
|
|
|
|
DBG_MACRO,
|
2019-12-03 16:54:32 +00:00
|
|
|
mac.span(),
|
2019-02-03 09:50:00 +00:00
|
|
|
"`dbg!` macro is intended as a debugging tool",
|
2020-04-18 10:28:29 +00:00
|
|
|
None,
|
2019-02-03 09:50:00 +00:00
|
|
|
"ensure to avoid having uses of it in version control",
|
|
|
|
);
|
|
|
|
}
|
2019-01-30 17:39:38 +00:00
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
2019-02-03 09:28:42 +00:00
|
|
|
|
|
|
|
// Get span enclosing entire the token stream.
|
|
|
|
fn tts_span(tts: TokenStream) -> Option<Span> {
|
|
|
|
let mut cursor = tts.into_trees();
|
|
|
|
let first = cursor.next()?.span();
|
2019-09-04 14:19:59 +00:00
|
|
|
let span = cursor.last().map_or(first, |tree| first.to(tree.span()));
|
2019-02-03 09:28:42 +00:00
|
|
|
Some(span)
|
|
|
|
}
|