2021-03-25 18:29:11 +00:00
|
|
|
use clippy_utils::diagnostics::span_lint_and_then;
|
2022-01-13 12:18:19 +00:00
|
|
|
use clippy_utils::macros::{is_panic, root_macro_call_first_node};
|
|
|
|
use clippy_utils::method_chain_args;
|
2021-03-25 18:29:11 +00:00
|
|
|
use clippy_utils::ty::is_type_diagnostic_item;
|
2018-11-27 20:14:15 +00:00
|
|
|
use if_chain::if_chain;
|
2020-01-06 16:39:50 +00:00
|
|
|
use rustc_hir as hir;
|
2020-01-12 06:08:41 +00:00
|
|
|
use rustc_lint::{LateContext, LateLintPass};
|
2020-04-12 13:23:07 +00:00
|
|
|
use rustc_middle::ty;
|
2020-01-11 11:37:08 +00:00
|
|
|
use rustc_session::{declare_lint_pass, declare_tool_lint};
|
2020-11-05 13:29:48 +00:00
|
|
|
use rustc_span::{sym, Span};
|
2017-10-16 21:06:31 +00:00
|
|
|
|
2018-03-28 13:24:26 +00:00
|
|
|
declare_clippy_lint! {
|
2021-07-29 10:16:06 +00:00
|
|
|
/// ### What it does
|
|
|
|
/// Checks for impls of `From<..>` that contain `panic!()` or `unwrap()`
|
2019-03-05 16:50:33 +00:00
|
|
|
///
|
2021-07-29 10:16:06 +00:00
|
|
|
/// ### Why is this bad?
|
|
|
|
/// `TryFrom` should be used if there's a possibility of failure.
|
2019-03-05 16:50:33 +00:00
|
|
|
///
|
2021-07-29 10:16:06 +00:00
|
|
|
/// ### Example
|
2019-03-05 16:50:33 +00:00
|
|
|
/// ```rust
|
|
|
|
/// struct Foo(i32);
|
2020-06-09 14:36:01 +00:00
|
|
|
///
|
|
|
|
/// // Bad
|
2019-03-05 16:50:33 +00:00
|
|
|
/// impl From<String> for Foo {
|
|
|
|
/// fn from(s: String) -> Self {
|
|
|
|
/// Foo(s.parse().unwrap())
|
|
|
|
/// }
|
|
|
|
/// }
|
|
|
|
/// ```
|
2020-06-09 14:36:01 +00:00
|
|
|
///
|
|
|
|
/// ```rust
|
|
|
|
/// // Good
|
|
|
|
/// struct Foo(i32);
|
|
|
|
///
|
|
|
|
/// impl TryFrom<String> for Foo {
|
|
|
|
/// type Error = ();
|
|
|
|
/// fn try_from(s: String) -> Result<Self, Self::Error> {
|
|
|
|
/// if let Ok(parsed) = s.parse() {
|
|
|
|
/// Ok(Foo(parsed))
|
|
|
|
/// } else {
|
|
|
|
/// Err(())
|
|
|
|
/// }
|
|
|
|
/// }
|
|
|
|
/// }
|
|
|
|
/// ```
|
2021-12-06 11:33:31 +00:00
|
|
|
#[clippy::version = "pre 1.29.0"]
|
2018-03-28 13:24:26 +00:00
|
|
|
pub FALLIBLE_IMPL_FROM,
|
|
|
|
nursery,
|
2017-10-17 16:09:10 +00:00
|
|
|
"Warn on impls of `From<..>` that contain `panic!()` or `unwrap()`"
|
2017-10-16 21:06:31 +00:00
|
|
|
}
|
|
|
|
|
2019-04-08 20:43:55 +00:00
|
|
|
declare_lint_pass!(FallibleImplFrom => [FALLIBLE_IMPL_FROM]);
|
2017-10-16 21:06:31 +00:00
|
|
|
|
2020-06-25 20:41:36 +00:00
|
|
|
impl<'tcx> LateLintPass<'tcx> for FallibleImplFrom {
|
|
|
|
fn check_item(&mut self, cx: &LateContext<'tcx>, item: &'tcx hir::Item<'_>) {
|
2017-10-16 21:06:31 +00:00
|
|
|
// check for `impl From<???> for ..`
|
2017-10-23 19:18:02 +00:00
|
|
|
if_chain! {
|
2020-11-22 22:46:21 +00:00
|
|
|
if let hir::ItemKind::Impl(impl_) = &item.kind;
|
2021-01-30 16:47:51 +00:00
|
|
|
if let Some(impl_trait_ref) = cx.tcx.impl_trait_ref(item.def_id);
|
2021-10-02 23:51:01 +00:00
|
|
|
if cx.tcx.is_diagnostic_item(sym::From, impl_trait_ref.def_id);
|
2017-10-23 19:18:02 +00:00
|
|
|
then {
|
2020-11-22 22:46:21 +00:00
|
|
|
lint_impl_body(cx, item.span, impl_.items);
|
2017-10-23 19:18:02 +00:00
|
|
|
}
|
|
|
|
}
|
2017-10-16 21:06:31 +00:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2021-07-15 20:19:39 +00:00
|
|
|
fn lint_impl_body<'tcx>(cx: &LateContext<'tcx>, impl_span: Span, impl_items: &[hir::ImplItemRef]) {
|
2022-01-15 22:07:52 +00:00
|
|
|
use rustc_hir::intravisit::{self, Visitor};
|
2022-01-13 12:18:19 +00:00
|
|
|
use rustc_hir::{Expr, ImplItemKind};
|
2017-10-16 21:06:31 +00:00
|
|
|
|
2019-06-19 18:36:23 +00:00
|
|
|
struct FindPanicUnwrap<'a, 'tcx> {
|
2020-06-25 20:41:36 +00:00
|
|
|
lcx: &'a LateContext<'tcx>,
|
2020-07-17 08:47:04 +00:00
|
|
|
typeck_results: &'tcx ty::TypeckResults<'tcx>,
|
2017-10-16 21:06:31 +00:00
|
|
|
result: Vec<Span>,
|
|
|
|
}
|
|
|
|
|
2019-06-19 18:36:23 +00:00
|
|
|
impl<'a, 'tcx> Visitor<'tcx> for FindPanicUnwrap<'a, 'tcx> {
|
2019-12-27 07:12:26 +00:00
|
|
|
fn visit_expr(&mut self, expr: &'tcx Expr<'_>) {
|
2022-01-13 12:18:19 +00:00
|
|
|
if let Some(macro_call) = root_macro_call_first_node(self.lcx, expr) {
|
|
|
|
if is_panic(self.lcx, macro_call.def_id) {
|
2017-10-23 19:18:02 +00:00
|
|
|
self.result.push(expr.span);
|
|
|
|
}
|
|
|
|
}
|
2017-10-16 21:06:31 +00:00
|
|
|
|
|
|
|
// check for `unwrap`
|
2019-05-17 21:53:54 +00:00
|
|
|
if let Some(arglists) = method_chain_args(expr, &["unwrap"]) {
|
2022-03-16 12:12:30 +00:00
|
|
|
let receiver_ty = self.typeck_results.expr_ty(&arglists[0][0]).peel_refs();
|
|
|
|
if is_type_diagnostic_item(self.lcx, receiver_ty, sym::Option)
|
|
|
|
|| is_type_diagnostic_item(self.lcx, receiver_ty, sym::Result)
|
2020-04-12 13:23:54 +00:00
|
|
|
{
|
2017-10-16 21:06:31 +00:00
|
|
|
self.result.push(expr.span);
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
// and check sub-expressions
|
|
|
|
intravisit::walk_expr(self, expr);
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
for impl_item in impl_items {
|
2017-10-23 19:18:02 +00:00
|
|
|
if_chain! {
|
2020-11-05 13:29:48 +00:00
|
|
|
if impl_item.ident.name == sym::from;
|
2020-03-16 15:00:16 +00:00
|
|
|
if let ImplItemKind::Fn(_, body_id) =
|
2019-09-27 15:16:06 +00:00
|
|
|
cx.tcx.hir().impl_item(impl_item.id).kind;
|
2017-10-23 19:18:02 +00:00
|
|
|
then {
|
|
|
|
// check the body for `begin_panic` or `unwrap`
|
2018-12-08 00:56:03 +00:00
|
|
|
let body = cx.tcx.hir().body(body_id);
|
2017-10-23 19:18:02 +00:00
|
|
|
let mut fpu = FindPanicUnwrap {
|
2019-04-07 17:44:10 +00:00
|
|
|
lcx: cx,
|
2021-01-30 22:25:03 +00:00
|
|
|
typeck_results: cx.tcx.typeck(impl_item.id.def_id),
|
2017-10-23 19:18:02 +00:00
|
|
|
result: Vec::new(),
|
|
|
|
};
|
|
|
|
fpu.visit_expr(&body.value);
|
2017-11-04 19:55:56 +00:00
|
|
|
|
2017-10-23 19:18:02 +00:00
|
|
|
// if we've found one, lint
|
|
|
|
if !fpu.result.is_empty() {
|
|
|
|
span_lint_and_then(
|
|
|
|
cx,
|
|
|
|
FALLIBLE_IMPL_FROM,
|
|
|
|
impl_span,
|
|
|
|
"consider implementing `TryFrom` instead",
|
2020-04-17 06:08:00 +00:00
|
|
|
move |diag| {
|
|
|
|
diag.help(
|
2017-10-23 19:18:02 +00:00
|
|
|
"`From` is intended for infallible conversions only. \
|
2021-03-12 14:30:50 +00:00
|
|
|
Use `TryFrom` if there's a possibility for the conversion to fail");
|
2020-04-17 06:08:00 +00:00
|
|
|
diag.span_note(fpu.result, "potential failure(s)");
|
2017-10-23 19:18:02 +00:00
|
|
|
});
|
|
|
|
}
|
2017-10-16 21:06:31 +00:00
|
|
|
}
|
2017-10-23 19:18:02 +00:00
|
|
|
}
|
2017-10-16 21:06:31 +00:00
|
|
|
}
|
|
|
|
}
|