mirror of
https://github.com/rust-lang/rust-clippy
synced 2024-12-22 19:13:29 +00:00
109 lines
2.1 KiB
Text
109 lines
2.1 KiB
Text
|
error: needless use of `for_each`
|
||
|
--> $DIR/needless_for_each_fixable.rs:10:5
|
||
|
|
|
||
|
LL | / v.iter().for_each(|elem| {
|
||
|
LL | | acc += elem;
|
||
|
LL | | });
|
||
|
| |_______^
|
||
|
|
|
||
|
= note: `-D clippy::needless-for-each` implied by `-D warnings`
|
||
|
help: try
|
||
|
|
|
||
|
LL | for elem in v.iter() {
|
||
|
LL | acc += elem;
|
||
|
LL | }
|
||
|
|
|
||
|
|
||
|
error: needless use of `for_each`
|
||
|
--> $DIR/needless_for_each_fixable.rs:13:5
|
||
|
|
|
||
|
LL | / v.into_iter().for_each(|elem| {
|
||
|
LL | | acc += elem;
|
||
|
LL | | });
|
||
|
| |_______^
|
||
|
|
|
||
|
help: try
|
||
|
|
|
||
|
LL | for elem in v.into_iter() {
|
||
|
LL | acc += elem;
|
||
|
LL | }
|
||
|
|
|
||
|
|
||
|
error: needless use of `for_each`
|
||
|
--> $DIR/needless_for_each_fixable.rs:18:5
|
||
|
|
|
||
|
LL | / hash_map.iter().for_each(|(k, v)| {
|
||
|
LL | | acc += k + v;
|
||
|
LL | | });
|
||
|
| |_______^
|
||
|
|
|
||
|
help: try
|
||
|
|
|
||
|
LL | for (k, v) in hash_map.iter() {
|
||
|
LL | acc += k + v;
|
||
|
LL | }
|
||
|
|
|
||
|
|
||
|
error: needless use of `for_each`
|
||
|
--> $DIR/needless_for_each_fixable.rs:21:5
|
||
|
|
|
||
|
LL | / hash_map.iter_mut().for_each(|(k, v)| {
|
||
|
LL | | acc += *k + *v;
|
||
|
LL | | });
|
||
|
| |_______^
|
||
|
|
|
||
|
help: try
|
||
|
|
|
||
|
LL | for (k, v) in hash_map.iter_mut() {
|
||
|
LL | acc += *k + *v;
|
||
|
LL | }
|
||
|
|
|
||
|
|
||
|
error: needless use of `for_each`
|
||
|
--> $DIR/needless_for_each_fixable.rs:24:5
|
||
|
|
|
||
|
LL | / hash_map.keys().for_each(|k| {
|
||
|
LL | | acc += k;
|
||
|
LL | | });
|
||
|
| |_______^
|
||
|
|
|
||
|
help: try
|
||
|
|
|
||
|
LL | for k in hash_map.keys() {
|
||
|
LL | acc += k;
|
||
|
LL | }
|
||
|
|
|
||
|
|
||
|
error: needless use of `for_each`
|
||
|
--> $DIR/needless_for_each_fixable.rs:27:5
|
||
|
|
|
||
|
LL | / hash_map.values().for_each(|v| {
|
||
|
LL | | acc += v;
|
||
|
LL | | });
|
||
|
| |_______^
|
||
|
|
|
||
|
help: try
|
||
|
|
|
||
|
LL | for v in hash_map.values() {
|
||
|
LL | acc += v;
|
||
|
LL | }
|
||
|
|
|
||
|
|
||
|
error: needless use of `for_each`
|
||
|
--> $DIR/needless_for_each_fixable.rs:34:5
|
||
|
|
|
||
|
LL | / my_vec().iter().for_each(|elem| {
|
||
|
LL | | acc += elem;
|
||
|
LL | | });
|
||
|
| |_______^
|
||
|
|
|
||
|
help: try
|
||
|
|
|
||
|
LL | for elem in my_vec().iter() {
|
||
|
LL | acc += elem;
|
||
|
LL | }
|
||
|
|
|
||
|
|
||
|
error: aborting due to 7 previous errors
|
||
|
|