2015-11-18 11:35:18 +00:00
|
|
|
//! calculate cyclomatic complexity and warn about overly complex functions
|
|
|
|
|
2016-03-27 18:59:02 +00:00
|
|
|
use rustc::cfg::CFG;
|
2016-04-05 15:29:14 +00:00
|
|
|
use rustc::lint::*;
|
2016-03-27 18:59:02 +00:00
|
|
|
use rustc::ty;
|
2016-04-07 15:46:48 +00:00
|
|
|
use rustc::hir::*;
|
2016-12-06 10:32:21 +00:00
|
|
|
use rustc::hir::intravisit::{Visitor, walk_expr, NestedVisitorMap};
|
2016-02-24 16:38:57 +00:00
|
|
|
use syntax::ast::Attribute;
|
2016-04-05 15:29:14 +00:00
|
|
|
use syntax::attr;
|
2016-02-24 16:38:57 +00:00
|
|
|
use syntax::codemap::Span;
|
2015-11-18 11:35:18 +00:00
|
|
|
|
2016-04-23 12:30:05 +00:00
|
|
|
use utils::{in_macro, LimitStack, span_help_and_lint, paths, match_type};
|
2015-11-18 11:35:18 +00:00
|
|
|
|
2016-08-06 07:55:04 +00:00
|
|
|
/// **What it does:** Checks for methods with high cyclomatic complexity.
|
2015-12-14 21:16:56 +00:00
|
|
|
///
|
2016-08-06 07:55:04 +00:00
|
|
|
/// **Why is this bad?** Methods of high cyclomatic complexity tend to be badly
|
|
|
|
/// readable. Also LLVM will usually optimize small methods better.
|
2015-12-14 21:16:56 +00:00
|
|
|
///
|
2016-08-06 07:55:04 +00:00
|
|
|
/// **Known problems:** Sometimes it's hard to find a way to reduce the complexity.
|
2015-12-14 21:16:56 +00:00
|
|
|
///
|
|
|
|
/// **Example:** No. You'll see it when you get the warning.
|
2016-02-05 23:13:29 +00:00
|
|
|
declare_lint! {
|
2016-08-06 08:18:36 +00:00
|
|
|
pub CYCLOMATIC_COMPLEXITY,
|
|
|
|
Warn,
|
|
|
|
"functions that should be split up into multiple functions"
|
2016-02-05 23:13:29 +00:00
|
|
|
}
|
2015-11-18 11:35:18 +00:00
|
|
|
|
|
|
|
pub struct CyclomaticComplexity {
|
|
|
|
limit: LimitStack,
|
|
|
|
}
|
|
|
|
|
|
|
|
impl CyclomaticComplexity {
|
|
|
|
pub fn new(limit: u64) -> Self {
|
2016-01-04 04:26:12 +00:00
|
|
|
CyclomaticComplexity { limit: LimitStack::new(limit) }
|
2015-11-18 11:35:18 +00:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
impl LintPass for CyclomaticComplexity {
|
|
|
|
fn get_lints(&self) -> LintArray {
|
|
|
|
lint_array!(CYCLOMATIC_COMPLEXITY)
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
impl CyclomaticComplexity {
|
2016-12-06 10:32:21 +00:00
|
|
|
fn check<'a, 'tcx: 'a>(&mut self, cx: &'a LateContext<'a, 'tcx>, expr: &'tcx Expr, span: Span) {
|
2016-01-04 04:26:12 +00:00
|
|
|
if in_macro(cx, span) {
|
|
|
|
return;
|
|
|
|
}
|
2016-04-05 15:29:14 +00:00
|
|
|
|
2016-11-16 20:57:56 +00:00
|
|
|
let cfg = CFG::new(cx.tcx, expr);
|
2015-11-18 11:35:18 +00:00
|
|
|
let n = cfg.graph.len_nodes() as u64;
|
|
|
|
let e = cfg.graph.len_edges() as u64;
|
2016-03-14 16:24:55 +00:00
|
|
|
if e + 2 < n {
|
|
|
|
// the function has unreachable code, other lints should catch this
|
|
|
|
return;
|
|
|
|
}
|
2015-11-18 11:35:18 +00:00
|
|
|
let cc = e + 2 - n;
|
2016-03-04 15:27:03 +00:00
|
|
|
let mut helper = CCHelper {
|
|
|
|
match_arms: 0,
|
|
|
|
divergence: 0,
|
2016-03-08 14:10:02 +00:00
|
|
|
short_circuits: 0,
|
2016-04-23 12:30:05 +00:00
|
|
|
returns: 0,
|
2016-12-06 10:32:21 +00:00
|
|
|
cx: cx,
|
2016-03-04 15:27:03 +00:00
|
|
|
};
|
2016-11-16 20:57:56 +00:00
|
|
|
helper.visit_expr(expr);
|
2016-04-23 12:30:05 +00:00
|
|
|
let CCHelper { match_arms, divergence, short_circuits, returns, .. } = helper;
|
2016-11-16 20:57:56 +00:00
|
|
|
let ret_ty = cx.tcx.tables().node_id_to_type(expr.id);
|
2016-04-23 12:30:05 +00:00
|
|
|
let ret_adjust = if match_type(cx, ret_ty, &paths::RESULT) {
|
|
|
|
returns
|
|
|
|
} else {
|
|
|
|
returns / 2
|
|
|
|
};
|
2016-03-04 15:27:03 +00:00
|
|
|
|
2016-06-05 23:42:39 +00:00
|
|
|
if cc + divergence < match_arms + short_circuits {
|
2016-04-23 12:30:05 +00:00
|
|
|
report_cc_bug(cx, cc, match_arms, divergence, short_circuits, ret_adjust, span);
|
2015-12-05 08:53:00 +00:00
|
|
|
} else {
|
2016-04-23 12:30:05 +00:00
|
|
|
let mut rust_cc = cc + divergence - match_arms - short_circuits;
|
|
|
|
// prevent degenerate cases where unreachable code contains `return` statements
|
|
|
|
if rust_cc >= ret_adjust {
|
|
|
|
rust_cc -= ret_adjust;
|
|
|
|
}
|
2015-12-05 08:53:00 +00:00
|
|
|
if rust_cc > self.limit.limit() {
|
2016-01-04 04:26:12 +00:00
|
|
|
span_help_and_lint(cx,
|
|
|
|
CYCLOMATIC_COMPLEXITY,
|
|
|
|
span,
|
2016-02-05 20:54:29 +00:00
|
|
|
&format!("the function has a cyclomatic complexity of {}", rust_cc),
|
|
|
|
"you could split it up into multiple smaller functions");
|
2015-12-05 08:53:00 +00:00
|
|
|
}
|
2015-11-18 11:35:18 +00:00
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
impl LateLintPass for CyclomaticComplexity {
|
2016-12-06 10:32:21 +00:00
|
|
|
fn check_item<'a, 'tcx: 'a>(&mut self, cx: &LateContext<'a, 'tcx>, item: &'tcx Item) {
|
|
|
|
if let ItemFn(_, _, _, _, _, eid) = item.node {
|
2016-04-05 15:29:14 +00:00
|
|
|
if !attr::contains_name(&item.attrs, "test") {
|
2016-12-06 10:32:21 +00:00
|
|
|
self.check(cx, cx.tcx.map.expr(eid), item.span);
|
2016-04-05 15:29:14 +00:00
|
|
|
}
|
2015-11-18 11:35:18 +00:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2016-12-06 10:32:21 +00:00
|
|
|
fn check_impl_item<'a, 'tcx: 'a>(&mut self, cx: &LateContext<'a, 'tcx>, item: &'tcx ImplItem) {
|
|
|
|
if let ImplItemKind::Method(_, eid) = item.node {
|
|
|
|
self.check(cx, cx.tcx.map.expr(eid), item.span);
|
2015-11-18 11:35:18 +00:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2016-12-06 10:32:21 +00:00
|
|
|
fn check_trait_item<'a, 'tcx: 'a>(&mut self, cx: &LateContext<'a, 'tcx>, item: &'tcx TraitItem) {
|
|
|
|
if let MethodTraitItem(_, Some(eid)) = item.node {
|
|
|
|
self.check(cx, cx.tcx.map.expr(eid), item.span);
|
2015-11-18 11:35:18 +00:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2016-12-06 10:32:21 +00:00
|
|
|
fn enter_lint_attrs<'a, 'tcx: 'a>(&mut self, cx: &LateContext<'a, 'tcx>, attrs: &'tcx [Attribute]) {
|
2015-11-18 11:35:18 +00:00
|
|
|
self.limit.push_attrs(cx.sess(), attrs, "cyclomatic_complexity");
|
|
|
|
}
|
2016-12-06 10:32:21 +00:00
|
|
|
fn exit_lint_attrs<'a, 'tcx: 'a>(&mut self, cx: &LateContext<'a, 'tcx>, attrs: &'tcx [Attribute]) {
|
2015-11-18 11:35:18 +00:00
|
|
|
self.limit.pop_attrs(cx.sess(), attrs, "cyclomatic_complexity");
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2016-12-06 10:32:21 +00:00
|
|
|
struct CCHelper<'a, 'tcx: 'a> {
|
2016-03-04 15:27:03 +00:00
|
|
|
match_arms: u64,
|
|
|
|
divergence: u64,
|
2016-04-23 12:30:05 +00:00
|
|
|
returns: u64,
|
2016-03-08 14:10:02 +00:00
|
|
|
short_circuits: u64, // && and ||
|
2016-12-06 10:32:21 +00:00
|
|
|
cx: &'a LateContext<'a, 'tcx>,
|
2016-03-04 15:27:03 +00:00
|
|
|
}
|
2015-11-18 11:35:18 +00:00
|
|
|
|
2016-12-06 10:32:21 +00:00
|
|
|
impl<'a, 'tcx> Visitor<'tcx> for CCHelper<'a, 'tcx> {
|
|
|
|
fn visit_expr(&mut self, e: &'tcx Expr) {
|
2015-11-18 11:35:18 +00:00
|
|
|
match e.node {
|
|
|
|
ExprMatch(_, ref arms, _) => {
|
|
|
|
walk_expr(self, e);
|
|
|
|
let arms_n: u64 = arms.iter().map(|arm| arm.pats.len() as u64).sum();
|
2015-12-14 13:29:20 +00:00
|
|
|
if arms_n > 1 {
|
2016-03-04 15:27:03 +00:00
|
|
|
self.match_arms += arms_n - 2;
|
2015-12-14 13:29:20 +00:00
|
|
|
}
|
2016-01-04 04:26:12 +00:00
|
|
|
}
|
2015-12-14 13:29:20 +00:00
|
|
|
ExprCall(ref callee, _) => {
|
|
|
|
walk_expr(self, e);
|
2016-12-06 10:32:21 +00:00
|
|
|
let ty = self.cx.tcx.tables().node_id_to_type(callee.id);
|
2016-03-10 17:13:49 +00:00
|
|
|
match ty.sty {
|
2016-04-14 18:14:03 +00:00
|
|
|
ty::TyFnDef(_, _, ty) |
|
2016-08-17 15:58:15 +00:00
|
|
|
ty::TyFnPtr(ty) if ty.sig.skip_binder().output.sty == ty::TyNever => {
|
2016-03-04 15:27:03 +00:00
|
|
|
self.divergence += 1;
|
2015-12-14 13:29:20 +00:00
|
|
|
}
|
2016-03-10 17:13:49 +00:00
|
|
|
_ => (),
|
2015-11-18 11:35:18 +00:00
|
|
|
}
|
2016-01-04 04:26:12 +00:00
|
|
|
}
|
2016-03-10 17:13:49 +00:00
|
|
|
ExprClosure(..) => (),
|
2016-03-08 14:10:02 +00:00
|
|
|
ExprBinary(op, _, _) => {
|
|
|
|
walk_expr(self, e);
|
|
|
|
match op.node {
|
|
|
|
BiAnd | BiOr => self.short_circuits += 1,
|
2016-04-14 18:14:03 +00:00
|
|
|
_ => (),
|
2016-03-08 14:10:02 +00:00
|
|
|
}
|
|
|
|
}
|
2016-04-23 12:30:05 +00:00
|
|
|
ExprRet(_) => self.returns += 1,
|
2015-11-18 11:35:18 +00:00
|
|
|
_ => walk_expr(self, e),
|
|
|
|
}
|
|
|
|
}
|
2016-12-06 10:32:21 +00:00
|
|
|
fn nested_visit_map<'this>(&'this mut self) -> NestedVisitorMap<'this, 'tcx> {
|
|
|
|
NestedVisitorMap::None
|
|
|
|
}
|
2015-11-18 11:35:18 +00:00
|
|
|
}
|
2015-12-05 08:53:00 +00:00
|
|
|
|
|
|
|
#[cfg(feature="debugging")]
|
2016-04-23 12:30:05 +00:00
|
|
|
fn report_cc_bug(_: &LateContext, cc: u64, narms: u64, div: u64, shorts: u64, returns: u64, span: Span) {
|
2016-04-03 15:16:53 +00:00
|
|
|
span_bug!(span,
|
|
|
|
"Clippy encountered a bug calculating cyclomatic complexity: cc = {}, arms = {}, \
|
2016-04-23 12:30:05 +00:00
|
|
|
div = {}, shorts = {}, returns = {}. Please file a bug report.",
|
2016-04-14 18:14:03 +00:00
|
|
|
cc,
|
|
|
|
narms,
|
|
|
|
div,
|
2016-04-23 12:30:05 +00:00
|
|
|
shorts,
|
|
|
|
returns);
|
2015-12-05 08:53:00 +00:00
|
|
|
}
|
|
|
|
#[cfg(not(feature="debugging"))]
|
2016-04-23 12:30:05 +00:00
|
|
|
fn report_cc_bug(cx: &LateContext, cc: u64, narms: u64, div: u64, shorts: u64, returns: u64, span: Span) {
|
2015-12-05 08:53:00 +00:00
|
|
|
if cx.current_level(CYCLOMATIC_COMPLEXITY) != Level::Allow {
|
2015-12-31 20:39:03 +00:00
|
|
|
cx.sess().span_note_without_error(span,
|
|
|
|
&format!("Clippy encountered a bug calculating cyclomatic complexity \
|
2016-06-05 23:42:39 +00:00
|
|
|
(hide this message with `#[allow(cyclomatic_complexity)]`): \
|
|
|
|
cc = {}, arms = {}, div = {}, shorts = {}, returns = {}. \
|
|
|
|
Please file a bug report.",
|
2016-01-04 04:26:12 +00:00
|
|
|
cc,
|
|
|
|
narms,
|
2016-03-08 14:10:02 +00:00
|
|
|
div,
|
2016-04-23 12:30:05 +00:00
|
|
|
shorts,
|
|
|
|
returns));
|
2015-12-05 08:53:00 +00:00
|
|
|
}
|
|
|
|
}
|