mirror of
https://github.com/rust-lang/rust-clippy
synced 2024-12-25 12:33:30 +00:00
96 lines
2.4 KiB
Rust
96 lines
2.4 KiB
Rust
|
//@compile-flags: --test
|
||
|
|
||
|
#![allow(
|
||
|
unused_mut,
|
||
|
clippy::get_first,
|
||
|
clippy::from_iter_instead_of_collect,
|
||
|
clippy::useless_vec
|
||
|
)]
|
||
|
#![warn(clippy::unwrap_used)]
|
||
|
#![warn(clippy::get_unwrap)]
|
||
|
|
||
|
use std::collections::{BTreeMap, HashMap, VecDeque};
|
||
|
|
||
|
struct GetFalsePositive {
|
||
|
arr: [u32; 3],
|
||
|
}
|
||
|
|
||
|
impl GetFalsePositive {
|
||
|
fn get(&self, pos: usize) -> Option<&u32> {
|
||
|
self.arr.get(pos)
|
||
|
}
|
||
|
fn get_mut(&mut self, pos: usize) -> Option<&mut u32> {
|
||
|
self.arr.get_mut(pos)
|
||
|
}
|
||
|
}
|
||
|
|
||
|
fn main() {
|
||
|
let mut boxed_slice: Box<[u8]> = Box::new([0, 1, 2, 3]);
|
||
|
let mut some_slice = &mut [0, 1, 2, 3];
|
||
|
let mut some_vec = vec![0, 1, 2, 3];
|
||
|
let mut some_vecdeque: VecDeque<_> = some_vec.iter().cloned().collect();
|
||
|
let mut some_hashmap: HashMap<u8, char> = HashMap::from_iter(vec![(1, 'a'), (2, 'b')]);
|
||
|
let mut some_btreemap: BTreeMap<u8, char> = BTreeMap::from_iter(vec![(1, 'a'), (2, 'b')]);
|
||
|
let mut false_positive = GetFalsePositive { arr: [0, 1, 2] };
|
||
|
|
||
|
{
|
||
|
// Test `get().unwrap()`
|
||
|
let _ = &boxed_slice[1];
|
||
|
let _ = &some_slice[0];
|
||
|
let _ = &some_vec[0];
|
||
|
let _ = &some_vecdeque[0];
|
||
|
let _ = &some_hashmap[&1];
|
||
|
let _ = &some_btreemap[&1];
|
||
|
#[allow(clippy::unwrap_used)]
|
||
|
let _ = false_positive.get(0).unwrap();
|
||
|
// Test with deref
|
||
|
let _: u8 = boxed_slice[1];
|
||
|
}
|
||
|
|
||
|
{
|
||
|
// Test `get_mut().unwrap()`
|
||
|
boxed_slice[0] = 1;
|
||
|
some_slice[0] = 1;
|
||
|
some_vec[0] = 1;
|
||
|
some_vecdeque[0] = 1;
|
||
|
// Check false positives
|
||
|
#[allow(clippy::unwrap_used)]
|
||
|
{
|
||
|
*some_hashmap.get_mut(&1).unwrap() = 'b';
|
||
|
*some_btreemap.get_mut(&1).unwrap() = 'b';
|
||
|
*false_positive.get_mut(0).unwrap() = 1;
|
||
|
}
|
||
|
}
|
||
|
|
||
|
{
|
||
|
// Test `get().unwrap().foo()` and `get_mut().unwrap().bar()`
|
||
|
let _ = some_vec[0..1].to_vec();
|
||
|
let _ = some_vec[0..1].to_vec();
|
||
|
}
|
||
|
}
|
||
|
|
||
|
#[test]
|
||
|
fn test() {
|
||
|
let boxed_slice: Box<[u8]> = Box::new([0, 1, 2, 3]);
|
||
|
let _ = &boxed_slice[1];
|
||
|
}
|
||
|
|
||
|
#[cfg(test)]
|
||
|
mod issue9612 {
|
||
|
// should not lint in `#[cfg(test)]` modules
|
||
|
#[test]
|
||
|
fn test_fn() {
|
||
|
let _a: u8 = 2.try_into().unwrap();
|
||
|
let _a: u8 = 3.try_into().expect("");
|
||
|
|
||
|
util();
|
||
|
}
|
||
|
|
||
|
fn util() {
|
||
|
let _a: u8 = 4.try_into().unwrap();
|
||
|
let _a: u8 = 5.try_into().expect("");
|
||
|
// should still warn
|
||
|
let _ = &Box::new([0])[1];
|
||
|
}
|
||
|
}
|