rust-clippy/tests/ui/needless_pass_by_value.stderr

189 lines
7.2 KiB
Text
Raw Normal View History

error: this argument is passed by value, but not consumed in the function body
2018-05-29 08:56:58 +00:00
--> $DIR/needless_pass_by_value.rs:9:23
|
9 | fn foo<T: Default>(v: Vec<T>, w: Vec<T>, mut x: Vec<T>, y: Vec<T>) -> Vec<T> {
| ^^^^^^ help: consider changing the type to: `&[T]`
|
= note: `-D needless-pass-by-value` implied by `-D warnings`
error: this argument is passed by value, but not consumed in the function body
2018-05-29 08:56:58 +00:00
--> $DIR/needless_pass_by_value.rs:23:11
|
2018-05-29 08:56:58 +00:00
23 | fn bar(x: String, y: Wrapper) {
2017-07-21 08:40:23 +00:00
| ^^^^^^ help: consider changing the type to: `&str`
error: this argument is passed by value, but not consumed in the function body
2018-05-29 08:56:58 +00:00
--> $DIR/needless_pass_by_value.rs:23:22
|
2018-05-29 08:56:58 +00:00
23 | fn bar(x: String, y: Wrapper) {
2017-07-21 08:40:23 +00:00
| ^^^^^^^ help: consider taking a reference instead: `&Wrapper`
error: this argument is passed by value, but not consumed in the function body
2018-05-29 08:56:58 +00:00
--> $DIR/needless_pass_by_value.rs:29:71
|
2018-05-29 08:56:58 +00:00
29 | fn test_borrow_trait<T: Borrow<str>, U: AsRef<str>, V>(t: T, u: U, v: V) {
| ^ help: consider taking a reference instead: `&V`
error: this argument is passed by value, but not consumed in the function body
2018-05-29 08:56:58 +00:00
--> $DIR/needless_pass_by_value.rs:41:18
|
2018-05-29 08:56:58 +00:00
41 | fn test_match(x: Option<Option<String>>, y: Option<Option<String>>) {
| ^^^^^^^^^^^^^^^^^^^^^^
help: consider taking a reference instead
2017-07-10 13:29:29 +00:00
|
2018-05-29 08:56:58 +00:00
41 | fn test_match(x: &Option<Option<String>>, y: Option<Option<String>>) {
42 | match *x {
2017-07-10 13:29:29 +00:00
|
error: this argument is passed by value, but not consumed in the function body
2018-05-29 08:56:58 +00:00
--> $DIR/needless_pass_by_value.rs:54:24
|
2018-05-29 08:56:58 +00:00
54 | fn test_destructure(x: Wrapper, y: Wrapper, z: Wrapper) {
2017-07-21 08:40:23 +00:00
| ^^^^^^^ help: consider taking a reference instead: `&Wrapper`
2017-02-20 09:18:31 +00:00
error: this argument is passed by value, but not consumed in the function body
2018-05-29 08:56:58 +00:00
--> $DIR/needless_pass_by_value.rs:54:36
2017-02-20 09:18:31 +00:00
|
2018-05-29 08:56:58 +00:00
54 | fn test_destructure(x: Wrapper, y: Wrapper, z: Wrapper) {
2017-02-20 09:18:31 +00:00
| ^^^^^^^
help: consider taking a reference instead
2017-07-10 13:29:29 +00:00
|
2018-05-29 08:56:58 +00:00
54 | fn test_destructure(x: Wrapper, y: &Wrapper, z: Wrapper) {
55 | let Wrapper(s) = z; // moved
56 | let Wrapper(ref t) = *y; // not moved
57 | let Wrapper(_) = *y; // still not moved
|
error: this argument is passed by value, but not consumed in the function body
2018-05-29 08:56:58 +00:00
--> $DIR/needless_pass_by_value.rs:70:49
2017-07-10 13:29:29 +00:00
|
2018-05-29 08:56:58 +00:00
70 | fn test_blanket_ref<T: Foo, S: Serialize>(_foo: T, _serializable: S) {}
| ^ help: consider taking a reference instead: `&T`
2017-02-20 09:18:31 +00:00
2017-10-08 08:51:44 +00:00
error: this argument is passed by value, but not consumed in the function body
2018-05-29 08:56:58 +00:00
--> $DIR/needless_pass_by_value.rs:72:18
2017-10-08 08:51:44 +00:00
|
2018-05-29 08:56:58 +00:00
72 | fn issue_2114(s: String, t: String, u: Vec<i32>, v: Vec<i32>) {
2017-10-08 08:51:44 +00:00
| ^^^^^^ help: consider taking a reference instead: `&String`
error: this argument is passed by value, but not consumed in the function body
2018-05-29 08:56:58 +00:00
--> $DIR/needless_pass_by_value.rs:72:29
2017-10-08 08:51:44 +00:00
|
2018-05-29 08:56:58 +00:00
72 | fn issue_2114(s: String, t: String, u: Vec<i32>, v: Vec<i32>) {
2017-10-08 08:51:44 +00:00
| ^^^^^^
help: consider changing the type to
|
2018-05-29 08:56:58 +00:00
72 | fn issue_2114(s: String, t: &str, u: Vec<i32>, v: Vec<i32>) {
2017-10-08 08:51:44 +00:00
| ^^^^
help: change `t.clone()` to
|
2018-05-29 08:56:58 +00:00
74 | let _ = t.to_string();
2017-10-08 08:51:44 +00:00
| ^^^^^^^^^^^^^
error: this argument is passed by value, but not consumed in the function body
2018-05-29 08:56:58 +00:00
--> $DIR/needless_pass_by_value.rs:72:40
2017-10-08 08:51:44 +00:00
|
2018-05-29 08:56:58 +00:00
72 | fn issue_2114(s: String, t: String, u: Vec<i32>, v: Vec<i32>) {
2017-10-08 08:51:44 +00:00
| ^^^^^^^^ help: consider taking a reference instead: `&Vec<i32>`
error: this argument is passed by value, but not consumed in the function body
2018-05-29 08:56:58 +00:00
--> $DIR/needless_pass_by_value.rs:72:53
2017-10-08 08:51:44 +00:00
|
2018-05-29 08:56:58 +00:00
72 | fn issue_2114(s: String, t: String, u: Vec<i32>, v: Vec<i32>) {
2017-10-08 08:51:44 +00:00
| ^^^^^^^^
help: consider changing the type to
|
2018-05-29 08:56:58 +00:00
72 | fn issue_2114(s: String, t: String, u: Vec<i32>, v: &[i32]) {
2017-10-08 08:51:44 +00:00
| ^^^^^^
help: change `v.clone()` to
|
2018-05-29 08:56:58 +00:00
76 | let _ = v.to_owned();
2017-10-08 08:51:44 +00:00
| ^^^^^^^^^^^^
error: this argument is passed by value, but not consumed in the function body
2018-05-29 08:56:58 +00:00
--> $DIR/needless_pass_by_value.rs:84:12
|
2018-05-29 08:56:58 +00:00
84 | s: String,
| ^^^^^^ help: consider changing the type to: `&str`
error: this argument is passed by value, but not consumed in the function body
2018-05-29 08:56:58 +00:00
--> $DIR/needless_pass_by_value.rs:85:12
|
2018-05-29 08:56:58 +00:00
85 | t: String,
| ^^^^^^ help: consider taking a reference instead: `&String`
error: this argument is passed by value, but not consumed in the function body
2018-05-29 08:56:58 +00:00
--> $DIR/needless_pass_by_value.rs:97:13
|
97 | _u: U,
| ^ help: consider taking a reference instead: `&U`
2017-11-03 08:56:26 +00:00
error: this argument is passed by value, but not consumed in the function body
2018-05-29 08:56:58 +00:00
--> $DIR/needless_pass_by_value.rs:98:13
|
98 | _s: Self,
| ^^^^ help: consider taking a reference instead: `&Self`
error: this argument is passed by value, but not consumed in the function body
2018-05-29 08:56:58 +00:00
--> $DIR/needless_pass_by_value.rs:120:24
|
2018-05-29 08:56:58 +00:00
120 | fn bar_copy(x: u32, y: CopyWrapper) {
| ^^^^^^^^^^^ help: consider taking a reference instead: `&CopyWrapper`
|
help: consider marking this type as Copy
2018-05-29 08:56:58 +00:00
--> $DIR/needless_pass_by_value.rs:118:1
|
2018-05-29 08:56:58 +00:00
118 | struct CopyWrapper(u32);
| ^^^^^^^^^^^^^^^^^^^^^^^^
error: this argument is passed by value, but not consumed in the function body
2018-05-29 08:56:58 +00:00
--> $DIR/needless_pass_by_value.rs:126:29
|
2018-05-29 08:56:58 +00:00
126 | fn test_destructure_copy(x: CopyWrapper, y: CopyWrapper, z: CopyWrapper) {
| ^^^^^^^^^^^ help: consider taking a reference instead: `&CopyWrapper`
|
help: consider marking this type as Copy
2018-05-29 08:56:58 +00:00
--> $DIR/needless_pass_by_value.rs:118:1
|
2018-05-29 08:56:58 +00:00
118 | struct CopyWrapper(u32);
| ^^^^^^^^^^^^^^^^^^^^^^^^
error: this argument is passed by value, but not consumed in the function body
2018-05-29 08:56:58 +00:00
--> $DIR/needless_pass_by_value.rs:126:45
|
2018-05-29 08:56:58 +00:00
126 | fn test_destructure_copy(x: CopyWrapper, y: CopyWrapper, z: CopyWrapper) {
| ^^^^^^^^^^^
|
help: consider marking this type as Copy
2018-05-29 08:56:58 +00:00
--> $DIR/needless_pass_by_value.rs:118:1
|
2018-05-29 08:56:58 +00:00
118 | struct CopyWrapper(u32);
| ^^^^^^^^^^^^^^^^^^^^^^^^
help: consider taking a reference instead
|
2018-05-29 08:56:58 +00:00
126 | fn test_destructure_copy(x: CopyWrapper, y: &CopyWrapper, z: CopyWrapper) {
127 | let CopyWrapper(s) = z; // moved
128 | let CopyWrapper(ref t) = *y; // not moved
129 | let CopyWrapper(_) = *y; // still not moved
|
error: this argument is passed by value, but not consumed in the function body
2018-05-29 08:56:58 +00:00
--> $DIR/needless_pass_by_value.rs:126:61
|
2018-05-29 08:56:58 +00:00
126 | fn test_destructure_copy(x: CopyWrapper, y: CopyWrapper, z: CopyWrapper) {
| ^^^^^^^^^^^
|
help: consider marking this type as Copy
2018-05-29 08:56:58 +00:00
--> $DIR/needless_pass_by_value.rs:118:1
|
2018-05-29 08:56:58 +00:00
118 | struct CopyWrapper(u32);
| ^^^^^^^^^^^^^^^^^^^^^^^^
help: consider taking a reference instead
|
2018-05-29 08:56:58 +00:00
126 | fn test_destructure_copy(x: CopyWrapper, y: CopyWrapper, z: &CopyWrapper) {
127 | let CopyWrapper(s) = *z; // moved
|
2017-11-03 08:56:26 +00:00
error: aborting due to 20 previous errors
2018-01-16 16:06:27 +00:00