rust-clippy/clippy_lints/src/exit.rs

60 lines
2.1 KiB
Rust
Raw Normal View History

use clippy_utils::diagnostics::span_lint;
use clippy_utils::{is_entrypoint_fn, match_def_path, paths};
2019-10-18 19:09:42 +00:00
use if_chain::if_chain;
2020-01-06 16:39:50 +00:00
use rustc_hir::{Expr, ExprKind, Item, ItemKind, Node};
2020-01-12 06:08:41 +00:00
use rustc_lint::{LateContext, LateLintPass};
2020-01-11 11:37:08 +00:00
use rustc_session::{declare_lint_pass, declare_tool_lint};
2019-10-18 19:09:42 +00:00
declare_clippy_lint! {
/// ### What it does
2022-11-25 20:50:38 +00:00
/// Detects calls to the `exit()` function which terminates the program.
2019-10-18 19:09:42 +00:00
///
/// ### Why is this bad?
2022-11-25 20:50:38 +00:00
/// Exit terminates the program at the location it is called. For unrecoverable
/// errors `panics` should be used to provide a stacktrace and potentualy other
/// information. A normal termination or one with an error code should happen in
2019-10-18 19:09:42 +00:00
/// the main function.
///
/// ### Example
2022-11-25 20:50:38 +00:00
/// ```
2019-10-18 19:09:42 +00:00
/// std::process::exit(0)
/// ```
2022-11-25 20:50:38 +00:00
///
/// Use instead:
///
/// ```ignore
/// // To provide a stacktrace and additional information
/// panic!("message");
///
/// // or a main method with a return
/// fn main() -> Result<(), i32> {
/// Ok(())
/// }
/// ```
#[clippy::version = "1.41.0"]
2019-10-18 19:09:42 +00:00
pub EXIT,
restriction,
2022-11-25 20:50:38 +00:00
"detects `std::process::exit` calls"
2019-10-18 19:09:42 +00:00
}
declare_lint_pass!(Exit => [EXIT]);
impl<'tcx> LateLintPass<'tcx> for Exit {
fn check_expr(&mut self, cx: &LateContext<'tcx>, e: &'tcx Expr<'_>) {
2019-10-18 19:09:42 +00:00
if_chain! {
if let ExprKind::Call(path_expr, _args) = e.kind;
2019-10-18 19:09:42 +00:00
if let ExprKind::Path(ref path) = path_expr.kind;
2021-01-18 19:36:32 +00:00
if let Some(def_id) = cx.qpath_res(path, path_expr.hir_id).opt_def_id();
2019-10-18 19:09:42 +00:00
if match_def_path(cx, def_id, &paths::EXIT);
let parent = cx.tcx.hir().get_parent_item(e.hir_id).def_id;
if let Some(Node::Item(Item{kind: ItemKind::Fn(..), ..})) = cx.tcx.hir().find_by_def_id(parent);
// If the next item up is a function we check if it is an entry point
// and only then emit a linter warning
if !is_entrypoint_fn(cx, parent.to_def_id());
2019-10-18 19:09:42 +00:00
then {
span_lint(cx, EXIT, e.span, "usage of `process::exit`");
2019-10-18 19:09:42 +00:00
}
}
}
}