2018-10-06 16:18:06 +00:00
|
|
|
// Copyright 2014-2018 The Rust Project Developers. See the COPYRIGHT
|
|
|
|
// file at the top-level directory of this distribution.
|
|
|
|
//
|
|
|
|
// Licensed under the Apache License, Version 2.0 <LICENSE-APACHE or
|
|
|
|
// http://www.apache.org/licenses/LICENSE-2.0> or the MIT license
|
|
|
|
// <LICENSE-MIT or http://opensource.org/licenses/MIT>, at your
|
|
|
|
// option. This file may not be copied, modified, or distributed
|
|
|
|
// except according to those terms.
|
|
|
|
|
2018-11-20 13:06:29 +00:00
|
|
|
use crate::consts::constant;
|
2018-11-27 14:13:57 +00:00
|
|
|
use crate::utils::{higher, is_copy, snippet_with_applicability, span_lint_and_sugg};
|
2018-11-20 13:06:29 +00:00
|
|
|
use if_chain::if_chain;
|
2018-12-29 15:04:45 +00:00
|
|
|
use rustc::hir::*;
|
|
|
|
use rustc::lint::{LateContext, LateLintPass, LintArray, LintPass};
|
|
|
|
use rustc::ty::{self, Ty};
|
|
|
|
use rustc::{declare_tool_lint, lint_array};
|
|
|
|
use rustc_errors::Applicability;
|
|
|
|
use syntax::source_map::Span;
|
2016-01-29 00:54:10 +00:00
|
|
|
|
2016-08-06 07:55:04 +00:00
|
|
|
/// **What it does:** Checks for usage of `&vec![..]` when using `&[..]` would
|
|
|
|
/// be possible.
|
2016-01-29 00:54:10 +00:00
|
|
|
///
|
|
|
|
/// **Why is this bad?** This is less efficient.
|
|
|
|
///
|
|
|
|
/// **Known problems:** None.
|
|
|
|
///
|
|
|
|
/// **Example:**
|
2016-01-29 21:49:48 +00:00
|
|
|
/// ```rust,ignore
|
2016-01-29 00:54:10 +00:00
|
|
|
/// foo(&vec![1, 2])
|
|
|
|
/// ```
|
2018-03-28 13:24:26 +00:00
|
|
|
declare_clippy_lint! {
|
2016-01-29 00:54:10 +00:00
|
|
|
pub USELESS_VEC,
|
2018-03-28 13:24:26 +00:00
|
|
|
perf,
|
2016-01-29 00:54:10 +00:00
|
|
|
"useless `vec!`"
|
|
|
|
}
|
|
|
|
|
|
|
|
#[derive(Copy, Clone, Debug)]
|
2016-06-10 14:17:20 +00:00
|
|
|
pub struct Pass;
|
2016-01-29 00:54:10 +00:00
|
|
|
|
2016-06-10 14:17:20 +00:00
|
|
|
impl LintPass for Pass {
|
2016-01-29 00:54:10 +00:00
|
|
|
fn get_lints(&self) -> LintArray {
|
|
|
|
lint_array!(USELESS_VEC)
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2016-12-07 12:13:40 +00:00
|
|
|
impl<'a, 'tcx> LateLintPass<'a, 'tcx> for Pass {
|
|
|
|
fn check_expr(&mut self, cx: &LateContext<'a, 'tcx>, expr: &'tcx Expr) {
|
2016-03-03 19:09:31 +00:00
|
|
|
// search for `&vec![_]` expressions where the adjusted type is `&[_]`
|
2017-10-23 19:18:02 +00:00
|
|
|
if_chain! {
|
2018-08-22 21:34:52 +00:00
|
|
|
if let ty::Ref(_, ty, _) = cx.tables.expr_ty_adjusted(expr).sty;
|
|
|
|
if let ty::Slice(..) = ty.sty;
|
2018-07-12 07:30:57 +00:00
|
|
|
if let ExprKind::AddrOf(_, ref addressee) = expr.node;
|
2017-10-23 19:18:02 +00:00
|
|
|
if let Some(vec_args) = higher::vec_macro(cx, addressee);
|
|
|
|
then {
|
|
|
|
check_vec_macro(cx, &vec_args, expr.span);
|
|
|
|
}
|
|
|
|
}
|
2016-03-28 21:32:55 +00:00
|
|
|
|
|
|
|
// search for `for _ in vec![…]`
|
2017-10-23 19:18:02 +00:00
|
|
|
if_chain! {
|
|
|
|
if let Some((_, arg, _)) = higher::for_loop(expr);
|
|
|
|
if let Some(vec_args) = higher::vec_macro(cx, arg);
|
|
|
|
if is_copy(cx, vec_type(cx.tables.expr_ty_adjusted(arg)));
|
|
|
|
then {
|
|
|
|
// report the error around the `vec!` not inside `<std macros>:`
|
2017-11-04 19:56:05 +00:00
|
|
|
let span = arg.span
|
|
|
|
.ctxt()
|
|
|
|
.outer()
|
|
|
|
.expn_info()
|
|
|
|
.map(|info| info.call_site)
|
|
|
|
.expect("unable to get call_site");
|
2017-10-23 19:18:02 +00:00
|
|
|
check_vec_macro(cx, &vec_args, span);
|
|
|
|
}
|
|
|
|
}
|
2016-03-28 21:32:55 +00:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2017-09-13 13:34:04 +00:00
|
|
|
fn check_vec_macro<'a, 'tcx>(cx: &LateContext<'a, 'tcx>, vec_args: &higher::VecArgs<'tcx>, span: Span) {
|
2018-11-27 14:13:57 +00:00
|
|
|
let mut applicability = Applicability::MachineApplicable;
|
2016-07-14 17:31:17 +00:00
|
|
|
let snippet = match *vec_args {
|
|
|
|
higher::VecArgs::Repeat(elem, len) => {
|
2018-05-13 11:16:31 +00:00
|
|
|
if constant(cx, cx.tables, len).is_some() {
|
2018-11-27 14:13:57 +00:00
|
|
|
format!(
|
|
|
|
"&[{}; {}]",
|
|
|
|
snippet_with_applicability(cx, elem.span, "elem", &mut applicability),
|
|
|
|
snippet_with_applicability(cx, len.span, "len", &mut applicability)
|
|
|
|
)
|
2016-07-14 17:31:17 +00:00
|
|
|
} else {
|
|
|
|
return;
|
2016-03-28 21:32:55 +00:00
|
|
|
}
|
2016-12-20 17:21:30 +00:00
|
|
|
},
|
2018-11-27 20:14:15 +00:00
|
|
|
higher::VecArgs::Vec(args) => {
|
|
|
|
if let Some(last) = args.iter().last() {
|
|
|
|
let span = args[0].span.to(last.span);
|
2016-01-29 00:54:10 +00:00
|
|
|
|
2018-11-27 20:14:15 +00:00
|
|
|
format!("&[{}]", snippet_with_applicability(cx, span, "..", &mut applicability))
|
|
|
|
} else {
|
|
|
|
"&[]".into()
|
|
|
|
}
|
2016-12-20 17:21:30 +00:00
|
|
|
},
|
2016-07-14 17:31:17 +00:00
|
|
|
};
|
2016-01-29 00:54:10 +00:00
|
|
|
|
2017-08-09 07:30:56 +00:00
|
|
|
span_lint_and_sugg(
|
|
|
|
cx,
|
|
|
|
USELESS_VEC,
|
|
|
|
span,
|
|
|
|
"useless use of `vec!`",
|
|
|
|
"you can use a slice directly",
|
|
|
|
snippet,
|
2018-11-27 14:13:57 +00:00
|
|
|
applicability,
|
2017-08-09 07:30:56 +00:00
|
|
|
);
|
2016-01-29 00:54:10 +00:00
|
|
|
}
|
|
|
|
|
2016-07-14 17:31:17 +00:00
|
|
|
/// Return the item type of the vector (ie. the `T` in `Vec<T>`).
|
2018-07-23 11:01:12 +00:00
|
|
|
fn vec_type(ty: Ty<'_>) -> Ty<'_> {
|
2018-08-22 21:34:52 +00:00
|
|
|
if let ty::Adt(_, substs) = ty.sty {
|
2016-08-28 15:25:41 +00:00
|
|
|
substs.type_at(0)
|
2016-07-14 17:31:17 +00:00
|
|
|
} else {
|
|
|
|
panic!("The type of `vec!` is a not a struct?");
|
|
|
|
}
|
|
|
|
}
|