2016-04-14 16:13:15 +00:00
|
|
|
use rustc::hir::*;
|
2016-04-07 15:46:48 +00:00
|
|
|
use rustc::hir::map::Node::NodeItem;
|
2016-02-20 16:35:07 +00:00
|
|
|
use rustc::lint::*;
|
2017-06-11 02:57:25 +00:00
|
|
|
use rustc::ty;
|
2016-02-20 20:15:05 +00:00
|
|
|
use syntax::ast::LitKind;
|
2016-11-23 20:19:03 +00:00
|
|
|
use syntax::symbol::InternedString;
|
2016-04-14 16:13:15 +00:00
|
|
|
use utils::paths;
|
2016-10-22 14:16:38 +00:00
|
|
|
use utils::{is_expn_of, match_def_path, match_type, resolve_node, span_lint, walk_ptrs_ty};
|
2016-02-20 16:35:07 +00:00
|
|
|
|
2016-08-06 07:55:04 +00:00
|
|
|
/// **What it does:** Checks for the use of `format!("string literal with no
|
|
|
|
/// argument")` and `format!("{}", foo)` where `foo` is a string.
|
2016-02-20 16:35:07 +00:00
|
|
|
///
|
2016-08-06 07:55:04 +00:00
|
|
|
/// **Why is this bad?** There is no point of doing that. `format!("too")` can
|
|
|
|
/// be replaced by `"foo".to_owned()` if you really need a `String`. The even
|
|
|
|
/// worse `&format!("foo")` is often encountered in the wild. `format!("{}",
|
|
|
|
/// foo)` can be replaced by `foo.clone()` if `foo: String` or `foo.to_owned()`
|
2016-11-24 09:10:22 +00:00
|
|
|
/// if `foo: &str`.
|
2016-02-20 16:35:07 +00:00
|
|
|
///
|
|
|
|
/// **Known problems:** None.
|
|
|
|
///
|
2016-08-06 07:55:04 +00:00
|
|
|
/// **Examples:**
|
|
|
|
/// ```rust
|
|
|
|
/// format!("foo")
|
|
|
|
/// format!("{}", foo)
|
|
|
|
/// ```
|
2016-02-20 16:35:07 +00:00
|
|
|
declare_lint! {
|
|
|
|
pub USELESS_FORMAT,
|
|
|
|
Warn,
|
|
|
|
"useless use of `format!`"
|
|
|
|
}
|
|
|
|
|
|
|
|
#[derive(Copy, Clone, Debug)]
|
2016-06-10 14:17:20 +00:00
|
|
|
pub struct Pass;
|
2016-02-20 16:35:07 +00:00
|
|
|
|
2016-06-10 14:17:20 +00:00
|
|
|
impl LintPass for Pass {
|
2016-02-20 16:35:07 +00:00
|
|
|
fn get_lints(&self) -> LintArray {
|
|
|
|
lint_array![USELESS_FORMAT]
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2016-12-07 12:13:40 +00:00
|
|
|
impl<'a, 'tcx> LateLintPass<'a, 'tcx> for Pass {
|
|
|
|
fn check_expr(&mut self, cx: &LateContext<'a, 'tcx>, expr: &'tcx Expr) {
|
2017-03-31 22:14:04 +00:00
|
|
|
if let Some(span) = is_expn_of(expr.span, "format") {
|
2016-02-20 20:15:05 +00:00
|
|
|
match expr.node {
|
|
|
|
// `format!("{}", foo)` expansion
|
|
|
|
ExprCall(ref fun, ref args) => {
|
|
|
|
if_let_chain!{[
|
2016-12-01 21:31:56 +00:00
|
|
|
let ExprPath(ref qpath) = fun.node,
|
2016-02-20 20:15:05 +00:00
|
|
|
args.len() == 2,
|
2017-01-13 16:04:56 +00:00
|
|
|
match_def_path(cx.tcx, resolve_node(cx, qpath, fun.id).def_id(), &paths::FMT_ARGUMENTS_NEWV1),
|
2016-02-20 20:15:05 +00:00
|
|
|
// ensure the format string is `"{..}"` with only one argument and no text
|
|
|
|
check_static_str(cx, &args[0]),
|
|
|
|
// ensure the format argument is `{}` ie. Display with no fancy option
|
2016-02-22 16:54:46 +00:00
|
|
|
check_arg_is_display(cx, &args[1])
|
2016-02-20 20:15:05 +00:00
|
|
|
], {
|
2016-02-20 20:20:56 +00:00
|
|
|
span_lint(cx, USELESS_FORMAT, span, "useless use of `format!`");
|
2016-02-20 20:15:05 +00:00
|
|
|
}}
|
2016-12-20 17:21:30 +00:00
|
|
|
},
|
2016-02-20 20:15:05 +00:00
|
|
|
// `format!("foo")` expansion contains `match () { () => [], }`
|
|
|
|
ExprMatch(ref matchee, _, _) => {
|
|
|
|
if let ExprTup(ref tup) = matchee.node {
|
|
|
|
if tup.is_empty() {
|
2016-02-20 20:20:56 +00:00
|
|
|
span_lint(cx, USELESS_FORMAT, span, "useless use of `format!`");
|
2016-02-20 20:15:05 +00:00
|
|
|
}
|
|
|
|
}
|
2016-12-20 17:21:30 +00:00
|
|
|
},
|
2016-02-20 20:15:05 +00:00
|
|
|
_ => (),
|
2016-02-20 16:35:07 +00:00
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
2016-02-20 20:15:05 +00:00
|
|
|
|
2016-08-05 15:52:58 +00:00
|
|
|
/// Returns the slice of format string parts in an `Arguments::new_v1` call.
|
|
|
|
/// Public because it's shared with a lint in print.rs.
|
2016-12-20 17:21:30 +00:00
|
|
|
pub fn get_argument_fmtstr_parts<'a, 'b>(cx: &LateContext<'a, 'b>, expr: &'a Expr) -> Option<Vec<InternedString>> {
|
2016-02-20 20:15:05 +00:00
|
|
|
if_let_chain! {[
|
|
|
|
let ExprBlock(ref block) = expr.node,
|
|
|
|
block.stmts.len() == 1,
|
|
|
|
let StmtDecl(ref decl, _) = block.stmts[0].node,
|
|
|
|
let DeclItem(ref decl) = decl.node,
|
2017-02-02 16:53:28 +00:00
|
|
|
let Some(NodeItem(decl)) = cx.tcx.hir.find(decl.id),
|
2017-03-30 08:21:13 +00:00
|
|
|
decl.name == "__STATIC_FMTSTR",
|
2016-02-20 20:15:05 +00:00
|
|
|
let ItemStatic(_, _, ref expr) = decl.node,
|
2017-02-02 16:53:28 +00:00
|
|
|
let ExprAddrOf(_, ref expr) = cx.tcx.hir.body(*expr).value.node, // &["…", "…", …]
|
2016-09-30 13:35:24 +00:00
|
|
|
let ExprArray(ref exprs) = expr.node,
|
2016-02-20 20:15:05 +00:00
|
|
|
], {
|
2016-08-05 15:52:58 +00:00
|
|
|
let mut result = Vec::new();
|
|
|
|
for expr in exprs {
|
|
|
|
if let ExprLit(ref lit) = expr.node {
|
|
|
|
if let LitKind::Str(ref lit, _) = lit.node {
|
2016-11-23 20:19:03 +00:00
|
|
|
result.push(lit.as_str());
|
2016-08-05 15:52:58 +00:00
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
return Some(result);
|
2016-02-20 20:15:05 +00:00
|
|
|
}}
|
2016-08-05 15:52:58 +00:00
|
|
|
None
|
|
|
|
}
|
2016-02-20 20:15:05 +00:00
|
|
|
|
2016-08-05 15:52:58 +00:00
|
|
|
/// Checks if the expressions matches
|
2017-04-11 12:10:11 +00:00
|
|
|
/// ```rust, ignore
|
2017-08-09 07:30:56 +00:00
|
|
|
/// { static __STATIC_FMTSTR: &'static[&'static str] = &["a", "b", c];
|
|
|
|
/// __STATIC_FMTSTR }
|
2016-08-05 15:52:58 +00:00
|
|
|
/// ```
|
|
|
|
fn check_static_str(cx: &LateContext, expr: &Expr) -> bool {
|
|
|
|
if let Some(expr) = get_argument_fmtstr_parts(cx, expr) {
|
|
|
|
expr.len() == 1 && expr[0].is_empty()
|
|
|
|
} else {
|
|
|
|
false
|
|
|
|
}
|
2016-02-20 20:15:05 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
/// Checks if the expressions matches
|
2017-04-10 13:10:29 +00:00
|
|
|
/// ```rust,ignore
|
2016-02-20 20:15:05 +00:00
|
|
|
/// &match (&42,) {
|
2017-08-09 07:30:56 +00:00
|
|
|
/// (__arg0,) => [::std::fmt::ArgumentV1::new(__arg0,
|
|
|
|
/// ::std::fmt::Display::fmt)],
|
2017-04-10 13:10:29 +00:00
|
|
|
/// }
|
2016-02-20 20:15:05 +00:00
|
|
|
/// ```
|
2016-02-22 16:54:46 +00:00
|
|
|
fn check_arg_is_display(cx: &LateContext, expr: &Expr) -> bool {
|
2016-02-20 20:15:05 +00:00
|
|
|
if_let_chain! {[
|
|
|
|
let ExprAddrOf(_, ref expr) = expr.node,
|
|
|
|
let ExprMatch(_, ref arms, _) = expr.node,
|
|
|
|
arms.len() == 1,
|
2016-02-22 16:54:46 +00:00
|
|
|
arms[0].pats.len() == 1,
|
2016-05-27 12:24:28 +00:00
|
|
|
let PatKind::Tuple(ref pat, None) = arms[0].pats[0].node,
|
2016-02-22 16:54:46 +00:00
|
|
|
pat.len() == 1,
|
2016-09-30 13:35:24 +00:00
|
|
|
let ExprArray(ref exprs) = arms[0].body.node,
|
2016-02-20 20:15:05 +00:00
|
|
|
exprs.len() == 1,
|
|
|
|
let ExprCall(_, ref args) = exprs[0].node,
|
|
|
|
args.len() == 2,
|
2016-12-01 21:31:56 +00:00
|
|
|
let ExprPath(ref qpath) = args[1].node,
|
2017-01-13 16:04:56 +00:00
|
|
|
match_def_path(cx.tcx, resolve_node(cx, qpath, args[1].id).def_id(), &paths::DISPLAY_FMT_METHOD),
|
2016-02-20 20:15:05 +00:00
|
|
|
], {
|
2017-01-13 16:04:56 +00:00
|
|
|
let ty = walk_ptrs_ty(cx.tables.pat_ty(&pat[0]));
|
2016-02-22 16:54:46 +00:00
|
|
|
|
2017-06-11 02:57:25 +00:00
|
|
|
return ty.sty == ty::TyStr || match_type(cx, ty, &paths::STRING);
|
2016-02-20 20:15:05 +00:00
|
|
|
}}
|
|
|
|
|
|
|
|
false
|
|
|
|
}
|